In OnLogCommand(), leverage TIMER_ANIMSTOP_ID to set the idle icon through the 'appli...

Apparently the functions called by SetIdleIcon() aren't
thread-safe and their interaction can cause deadlocks.

An earlier version of the patch has been tested by Lee and
doesn't seem to cause obvious regressions other than the
icon change being delayed by (at least) the 10 milliseconds
until the timer fires.

This is expected to fix #3525694 reported by Tim H.

diff --git a/w32log.c b/w32log.c
index 3ca29e4..7372136 100644 (file)
--- a/w32log.c
+++ b/w32log.c
@@ -1,4 +1,4 @@
-const char w32log_rcs[] = "$Id: w32log.c,v 1.44 2012/05/24 14:59:59 fabiankeil Exp $";
+const char w32log_rcs[] = "$Id: w32log.c,v 1.45 2012/05/24 15:05:17 fabiankeil Exp $";
 /*********************************************************************
  *
  * File        :  $Source: /cvsroot/ijbswa/current/w32log.c,v $
@@ -948,7 +948,13 @@ void OnLogCommand(int nCommand)
          global_toggle_state = !global_toggle_state;
          log_error(LOG_LEVEL_INFO,
             "Now toggled %s", global_toggle_state ? "ON" : "OFF");
-         SetIdleIcon();
+         /*
+          * Overload TIMER_ANIMSTOP_ID to set the idle icon through the
+          * "application queue". According to MSDN, 10 milliseconds are
+          * the lowest value possible and seem to be close enough to
+          * "instantly".
+          */
+         SetTimer(g_hwndLogFrame, TIMER_ANIMSTOP_ID, 10, NULL);
          break;
 #endif /* def FEATURE_TOGGLE */