privoxy.git
12 years agoRemove an unreasonable parameter limit in parse_cgi_parameters()
Fabian Keil [Fri, 8 Jun 2012 15:08:33 +0000 (15:08 +0000)]
Remove an unreasonable parameter limit in parse_cgi_parameters()

The new parameter limit depends on the memory available and
is currently unlikely to be reachable, due to other limits in
both Privoxy and common clients.

So the limit is actually still there, but at least it's no
longer unreasonable, is properly handled, and should be high
enough for anybody.

Reported by Andrew on ijbswa-users@.

12 years agoCatch ssplit() failures in parse_cgi_parameters()
Fabian Keil [Fri, 8 Jun 2012 15:07:53 +0000 (15:07 +0000)]
Catch ssplit() failures in parse_cgi_parameters()

12 years agoAdd #104: The code to modify global_toggle_state should be factored out into a separa...
Fabian Keil [Sun, 27 May 2012 15:51:34 +0000 (15:51 +0000)]
Add #104: The code to modify global_toggle_state should be factored out into a separate function

12 years agoRemove debug code that crept in with the previous "fix"
Fabian Keil [Sun, 27 May 2012 15:45:05 +0000 (15:45 +0000)]
Remove debug code that crept in with the previous "fix"

D'oh.

12 years agoFinish the previous commit, the added comment wasn't the final version
Fabian Keil [Sun, 27 May 2012 15:38:53 +0000 (15:38 +0000)]
Finish the previous commit, the added comment wasn't the final version

12 years agoIn OnLogCommand(), leverage TIMER_ANIMSTOP_ID to set the idle icon through the 'appli...
Fabian Keil [Sun, 27 May 2012 15:36:15 +0000 (15:36 +0000)]
In OnLogCommand(), leverage TIMER_ANIMSTOP_ID to set the idle icon through the 'application queue'

Apparently the functions called by SetIdleIcon() aren't
thread-safe and their interaction can cause deadlocks.

An earlier version of the patch has been tested by Lee and
doesn't seem to cause obvious regressions other than the
icon change being delayed by (at least) the 10 milliseconds
until the timer fires.

This is expected to fix #3525694 reported by Tim H.

12 years agoRemove a duplicated 'the'
Fabian Keil [Sun, 27 May 2012 15:31:24 +0000 (15:31 +0000)]
Remove a duplicated 'the'

Spotted by igor.

12 years agoFix lyrics in LogWindowProc()
Fabian Keil [Thu, 24 May 2012 15:05:17 +0000 (15:05 +0000)]
Fix lyrics in LogWindowProc()

12 years agoDeclare pcrs_get_delimiter()'s delimiters[] static const
Fabian Keil [Thu, 24 May 2012 15:04:34 +0000 (15:04 +0000)]
Declare pcrs_get_delimiter()'s delimiters[] static const

12 years agoIn pcrs_get_delimiter(), do not use delimiters ouside the ASCII range
Fabian Keil [Thu, 24 May 2012 15:02:38 +0000 (15:02 +0000)]
In pcrs_get_delimiter(), do not use delimiters ouside the ASCII range

Fixes a clang complaint.

12 years agoCleanup variable initialization in print_non_clf_message()
Fabian Keil [Thu, 24 May 2012 15:02:00 +0000 (15:02 +0000)]
Cleanup variable initialization in print_non_clf_message()

12 years agoShift subroutine arguments more consistently
Fabian Keil [Thu, 24 May 2012 15:01:05 +0000 (15:01 +0000)]
Shift subroutine arguments more consistently

12 years agoChange a two-argument open() call to use three arguments
Fabian Keil [Thu, 24 May 2012 15:00:46 +0000 (15:00 +0000)]
Change a two-argument open() call to use three arguments

12 years agoChange a couple of two-argument open() calls to use three arguments
Fabian Keil [Thu, 24 May 2012 15:00:27 +0000 (15:00 +0000)]
Change a couple of two-argument open() calls to use three arguments

12 years agoRemove a superfluous comment in OnLogCommand()
Fabian Keil [Thu, 24 May 2012 14:59:59 +0000 (14:59 +0000)]
Remove a superfluous comment in OnLogCommand()

12 years agoMerge two log_error() calls in OnLogCommand()
Fabian Keil [Thu, 24 May 2012 14:59:41 +0000 (14:59 +0000)]
Merge two log_error() calls in OnLogCommand()

12 years agoRemove dead code in SetIdleIcon()
Fabian Keil [Thu, 24 May 2012 14:59:25 +0000 (14:59 +0000)]
Remove dead code in SetIdleIcon()

12 years agoAccept a socket-timeout value of 0 seconds.
Fabian Keil [Thu, 24 May 2012 14:58:16 +0000 (14:58 +0000)]
Accept a socket-timeout value of 0 seconds.

Impatience isn't necessarily a syntax problem.

12 years agoAccept a default-server-timeout of 0. It's the default after all.
Fabian Keil [Thu, 24 May 2012 14:57:49 +0000 (14:57 +0000)]
Accept a default-server-timeout of 0. It's the default after all.

12 years agoUnblock '/.*Bugtracker'
Fabian Keil [Sun, 29 Apr 2012 16:18:39 +0000 (16:18 +0000)]
Unblock '/.*Bugtracker'

Reported by pwhk in #3522341.

12 years agoLog to STDOUT instead of STDERR
Fabian Keil [Sun, 29 Apr 2012 16:18:01 +0000 (16:18 +0000)]
Log to STDOUT instead of STDERR

STDOUT isn't used for anything else and logging to STDERR makes
piping unpleasant without any benefit (that I remember).

12 years agoReduce the likelihood that the google filter messes up HTML-generating JavaScript
Fabian Keil [Sun, 22 Apr 2012 12:17:08 +0000 (12:17 +0000)]
Reduce the likelihood that the google filter messes up HTML-generating JavaScript

Reported by Zeno Kugy in #3520260.

12 years agoRemove an obsolete newstuff marker
Fabian Keil [Sun, 22 Apr 2012 12:16:24 +0000 (12:16 +0000)]
Remove an obsolete newstuff marker

12 years agoFix an URL in the "Privoxy with Tor" FAQ
Fabian Keil [Sun, 22 Apr 2012 12:16:09 +0000 (12:16 +0000)]
Fix an URL in the "Privoxy with Tor" FAQ

12 years agoUse another client-header-tagger{} example: disable filtering for range requests
Fabian Keil [Sun, 22 Apr 2012 12:15:53 +0000 (12:15 +0000)]
Use another client-header-tagger{} example: disable filtering for range requests

12 years agoAdd #103: Potential performance improvement for large action files
Fabian Keil [Sun, 22 Apr 2012 12:15:33 +0000 (12:15 +0000)]
Add #103: Potential performance improvement for large action files

12 years agoTests with mostly invalid range request
Fabian Keil [Sun, 22 Apr 2012 12:14:46 +0000 (12:14 +0000)]
Tests with mostly invalid range request

12 years agoBump copyright and note that the tests now require 3.0.20 or later to work
Fabian Keil [Fri, 6 Apr 2012 15:18:12 +0000 (15:18 +0000)]
Bump copyright and note that the tests now require 3.0.20 or later to work

12 years agoAdditional tests for range requests with filtering enabled
Fabian Keil [Fri, 6 Apr 2012 15:17:41 +0000 (15:17 +0000)]
Additional tests for range requests with filtering enabled

12 years agoIn client_range(), let headers pass if the range starts at the beginning
Fabian Keil [Fri, 6 Apr 2012 15:17:10 +0000 (15:17 +0000)]
In client_range(), let headers pass if the range starts at the beginning

Could work around (or at least reduce the) video playback
issues with various Apple clients as reported in #3426305.

12 years agoWe use XXX not FIXME
Fabian Keil [Tue, 20 Mar 2012 13:05:55 +0000 (13:05 +0000)]
We use XXX not FIXME

12 years agoRemove bogus section about long and short being preferable to int
Fabian Keil [Tue, 20 Mar 2012 13:05:39 +0000 (13:05 +0000)]
Remove bogus section about long and short being preferable to int

12 years agoAdjust whitespace in examples to be closer to our style
Fabian Keil [Tue, 20 Mar 2012 13:05:14 +0000 (13:05 +0000)]
Adjust whitespace in examples to be closer to our style

12 years agoIJB is dead, long live Privoxy
Fabian Keil [Tue, 20 Mar 2012 13:04:54 +0000 (13:04 +0000)]
IJB is dead, long live Privoxy

12 years agoThe redhat-dok target no longer exists so there's no point documenting it
Fabian Keil [Tue, 20 Mar 2012 13:04:41 +0000 (13:04 +0000)]
The redhat-dok target no longer exists so there's no point documenting it

12 years agoWe no longer build PDFs so stop pretending
Fabian Keil [Tue, 20 Mar 2012 13:04:19 +0000 (13:04 +0000)]
We no longer build PDFs so stop pretending

12 years agoComment out references to multiple branches
Fabian Keil [Tue, 20 Mar 2012 13:04:03 +0000 (13:04 +0000)]
Comment out references to multiple branches

We currently don't use any.

12 years agoBump copyright date
Fabian Keil [Tue, 20 Mar 2012 13:03:05 +0000 (13:03 +0000)]
Bump copyright date

12 years agoUpdate the list of supported operating systems
Fabian Keil [Tue, 20 Mar 2012 13:02:50 +0000 (13:02 +0000)]
Update the list of supported operating systems

Clarify that all Windows versions after 95 are expected to
work and note that the platform-specific code for AmigaOS
and QNX currently isn't maintained.

12 years agoMultiple listen-address directives are supported since 3.0.18, stop pretending they...
Fabian Keil [Mon, 19 Mar 2012 12:56:41 +0000 (12:56 +0000)]
Multiple listen-address directives are supported since 3.0.18, stop pretending they aren't

12 years agoAdd missing spaces in the listen-address section
Fabian Keil [Mon, 19 Mar 2012 12:56:26 +0000 (12:56 +0000)]
Add missing spaces in the listen-address section

12 years agoUntabify
Fabian Keil [Mon, 19 Mar 2012 12:56:08 +0000 (12:56 +0000)]
Untabify

12 years agoUpdate an error message that still tried to print directive_hash as long
Fabian Keil [Sun, 18 Mar 2012 15:48:59 +0000 (15:48 +0000)]
Update an error message that still tried to print directive_hash as long

12 years agoChange RA_MODE from 0664 to 0644
Fabian Keil [Sun, 18 Mar 2012 15:47:54 +0000 (15:47 +0000)]
Change RA_MODE from 0664 to 0644

Suggested by Markus Dittrich in #3505445.

12 years agoAdd a referer tagger
Fabian Keil [Sun, 18 Mar 2012 15:45:44 +0000 (15:45 +0000)]
Add a referer tagger

12 years agoAdd #102: Add an include directive to split the config file into several parts.
Fabian Keil [Sun, 18 Mar 2012 15:44:57 +0000 (15:44 +0000)]
Add #102: Add an include directive to split the config file into several parts.

12 years agoRebuilt HTML for 3.0.20 UNRELEASED with Ian's recent changes
Fabian Keil [Sun, 18 Mar 2012 15:44:20 +0000 (15:44 +0000)]
Rebuilt HTML for 3.0.20 UNRELEASED with Ian's recent changes

12 years agoDo not let the dok-tidy target taint the docs with a tidy-mark
Fabian Keil [Sun, 18 Mar 2012 15:42:44 +0000 (15:42 +0000)]
Do not let the dok-tidy target taint the docs with a tidy-mark

The resulting markup is really nothing to be proud of.

12 years agoBump entities to 3.0.20 UNRELEASED
Fabian Keil [Sun, 18 Mar 2012 15:41:49 +0000 (15:41 +0000)]
Bump entities to 3.0.20 UNRELEASED

12 years agoFix a typo in the no-zlib-support complaint
Fabian Keil [Sun, 18 Mar 2012 13:48:27 +0000 (13:48 +0000)]
Fix a typo in the no-zlib-support complaint

Patch submitted by Matthew Fischer in #3507304.

12 years agoFix an error message in get_last_url() nobody is supposed to see
Fabian Keil [Sun, 18 Mar 2012 13:47:33 +0000 (13:47 +0000)]
Fix an error message in get_last_url() nobody is supposed to see

Reported by Matthew Fischer in #3507301.

12 years agoBump version to 1.2.1
Fabian Keil [Sun, 18 Mar 2012 13:47:11 +0000 (13:47 +0000)]
Bump version to 1.2.1

12 years agoBump generated Firefox version to 10.0.3
Fabian Keil [Sun, 18 Mar 2012 13:46:54 +0000 (13:46 +0000)]
Bump generated Firefox version to 10.0.3

12 years agoBrought OS X section up to date, deprecating the osxsetup module and adding a section...
Ian Silvester [Sun, 18 Mar 2012 01:16:35 +0000 (01:16 +0000)]
Brought OS X section up to date, deprecating the osxsetup module and adding a section referring to the OSXPackageBuilder module

12 years agoAdded OS X testers to documentation
Ian Silvester [Wed, 14 Mar 2012 17:58:47 +0000 (17:58 +0000)]
Added OS X testers to documentation

12 years agoUpdated user manual to refer to both packaged and source install options for OS X
Ian Silvester [Sun, 11 Mar 2012 19:03:42 +0000 (19:03 +0000)]
Updated user manual to refer to both packaged and source install options for OS X

12 years agoAccept and highlight: Stopping to watch the client socket. There's already another...
Fabian Keil [Sat, 10 Mar 2012 11:15:15 +0000 (11:15 +0000)]
Accept and highlight: Stopping to watch the client socket. There's already another request waiting.

It's emitted by Privoxy versions before 3.0.20 and the
previous commit was supposed to cover it but didn't due
to a trailing space in the regex.

12 years agoAccept and highlight: Stopping to watch the client socket 5. There's already another...
Fabian Keil [Sat, 10 Mar 2012 11:08:44 +0000 (11:08 +0000)]
Accept and highlight: Stopping to watch the client socket 5. There's already another request waiting.

12 years agoWhen stopping to watch a client socket due to pipelining, additionally log the socket...
Fabian Keil [Sat, 10 Mar 2012 11:08:10 +0000 (11:08 +0000)]
When stopping to watch a client socket due to pipelining, additionally log the socket number

12 years agoIn case of SOCKS5 failures, do not explicitly log the server's response
Fabian Keil [Sat, 10 Mar 2012 11:06:09 +0000 (11:06 +0000)]
In case of SOCKS5 failures, do not explicitly log the server's response

It hasn't helped so far and the response can already
be logged by enabling "debug 32768" anyway.

This reverts v1.81 and the follow-up bug fix v1.84.

12 years agoRelocate two parentheses I misplaced in the previous commit. No functional change...
Fabian Keil [Fri, 9 Mar 2012 18:06:13 +0000 (18:06 +0000)]
Relocate two parentheses I misplaced in the previous commit. No functional change intended.

12 years agoUnwrap a memcpy() call in resolve_hostname_to_ip()
Fabian Keil [Fri, 9 Mar 2012 17:56:41 +0000 (17:56 +0000)]
Unwrap a memcpy() call in resolve_hostname_to_ip()

12 years agoAdd some parentheses. No intended functional change.
Fabian Keil [Fri, 9 Mar 2012 17:56:21 +0000 (17:56 +0000)]
Add some parentheses. No intended functional change.

12 years agoFollow-up fixes for the previous white-space changes
Fabian Keil [Fri, 9 Mar 2012 17:55:50 +0000 (17:55 +0000)]
Follow-up fixes for the previous white-space changes

Clearly the commits belong together, but somebody failed to squash them.

12 years agoAdd missing white-space behind if's and the following parentheses
Fabian Keil [Fri, 9 Mar 2012 16:24:36 +0000 (16:24 +0000)]
Add missing white-space behind if's and the following parentheses

12 years agoFix white-space around parentheses
Fabian Keil [Fri, 9 Mar 2012 16:23:50 +0000 (16:23 +0000)]
Fix white-space around parentheses

12 years agoAdd #101: Forward known client headers in a predefined order
Fabian Keil [Fri, 9 Mar 2012 16:22:24 +0000 (16:22 +0000)]
Add #101: Forward known client headers in a predefined order

12 years agoUnblock adjamblog.wordpress.com/ and adjamblog.files.wordpress.com/
Fabian Keil [Tue, 6 Mar 2012 18:36:02 +0000 (18:36 +0000)]
Unblock adjamblog.wordpress.com/ and adjamblog.files.wordpress.com/

Reported by Ryan Farmer in #3496116.

12 years agoAdd Ian to the team
Ian Silvester [Mon, 5 Mar 2012 00:37:40 +0000 (00:37 +0000)]
Add Ian to the team

12 years agoAdd Ian to the team
Fabian Keil [Sun, 4 Mar 2012 11:55:42 +0000 (11:55 +0000)]
Add Ian to the team

12 years agoBump copyright
Fabian Keil [Sun, 4 Mar 2012 11:54:22 +0000 (11:54 +0000)]
Bump copyright

12 years agoUpdate 'Signals' section, the only explicitly handled signals are SIGINT, SIGTERM...
Fabian Keil [Sun, 4 Mar 2012 11:54:00 +0000 (11:54 +0000)]
Update 'Signals' section, the only explicitly handled signals are SIGINT, SIGTERM and SIGHUP

12 years agoReplace strdup() calls with strdup_or_die() calls where it's safe and simplifies...
Fabian Keil [Sun, 4 Mar 2012 11:53:26 +0000 (11:53 +0000)]
Replace strdup() calls with strdup_or_die() calls where it's safe and simplifies the code

12 years agoAdd strdup_or_die() which will allow to simplify code paths were strdup() failures...
Fabian Keil [Sun, 4 Mar 2012 11:52:45 +0000 (11:52 +0000)]
Add strdup_or_die() which will allow to simplify code paths were strdup() failures don't need to be handled gracefully

12 years agoUse privoxy_tolower() instead of vanilla tolower() with manual casting of the argument
Fabian Keil [Sun, 4 Mar 2012 11:51:49 +0000 (11:51 +0000)]
Use privoxy_tolower() instead of vanilla tolower() with manual casting of the argument

12 years agoRename ijb_foo macros to privoxy_foo
Fabian Keil [Sun, 4 Mar 2012 11:51:25 +0000 (11:51 +0000)]
Rename ijb_foo macros to privoxy_foo

12 years agoRelocate ijb_isdigit()'s definition to project.h
Fabian Keil [Sun, 4 Mar 2012 11:50:32 +0000 (11:50 +0000)]
Relocate ijb_isdigit()'s definition to project.h

12 years agoRephrase a comment
Fabian Keil [Sun, 4 Mar 2012 11:49:44 +0000 (11:49 +0000)]
Rephrase a comment

12 years agoRelocate ijb_isupper()'s definition to project.h and get the ijb_tolower() definition...
Fabian Keil [Sun, 4 Mar 2012 11:49:24 +0000 (11:49 +0000)]
Relocate ijb_isupper()'s definition to project.h and get the ijb_tolower() definition from there, too

12 years agoShorten bindup()
Fabian Keil [Sun, 4 Mar 2012 11:48:54 +0000 (11:48 +0000)]
Shorten bindup()

12 years agoFix hash_string()'s description
Fabian Keil [Sun, 4 Mar 2012 11:48:34 +0000 (11:48 +0000)]
Fix hash_string()'s description

As far as Privoxy is concerned the function only has
one use case. Whether or not it's anyone's favorite
is not particularly important.

Also the documented return code type didn't match reality.

12 years agoRemove the ijb_isupper() and ijb_tolower() macros which aren't used in this file
Fabian Keil [Sun, 4 Mar 2012 11:47:54 +0000 (11:47 +0000)]
Remove the ijb_isupper() and ijb_tolower() macros which aren't used in this file

12 years agoChange the hashes used in load_config() to unsigned int
Fabian Keil [Sun, 4 Mar 2012 11:47:21 +0000 (11:47 +0000)]
Change the hashes used in load_config() to unsigned int

That's what hash_string() actually returns and using
a potentiallly larger type is at best useless.

On my FreeBSD amd64 system this reduces the size of the
binary by only 128 bytes, but with a compiler that sucks
harder at optimization it could be a bit more.

12 years agoShorten zalloc()'s description to the part that makes sense (to me)
Fabian Keil [Sun, 4 Mar 2012 11:41:57 +0000 (11:41 +0000)]
Shorten zalloc()'s description to the part that makes sense (to me)

12 years agoLet enlist_unique_header() verify that the caller didn't pass a header containing...
Fabian Keil [Sun, 4 Mar 2012 11:41:32 +0000 (11:41 +0000)]
Let enlist_unique_header() verify that the caller didn't pass a header containing either \r or \n

12 years agoIn socks5_connect(), do not try to print a negative number ...
Fabian Keil [Wed, 29 Feb 2012 19:35:11 +0000 (19:35 +0000)]
In socks5_connect(), do not try to print a negative number ...

... of socks response bytes if the read() for the socks5
negotiation failed completely.

It's an API violation and can trigger an assert() in
debug builds with "debug 2" enabled. Except for the
assert(), log_error() already handled negative %N values
gracefully so this commit only makes a difference for
debug builds.

12 years agoTurn family mismatches in match_sockaddr() into fatal errors
Fabian Keil [Wed, 29 Feb 2012 19:34:04 +0000 (19:34 +0000)]
Turn family mismatches in match_sockaddr() into fatal errors

12 years agoRename action_name's member takes_value to value_type as it isn't used as boolean
Fabian Keil [Wed, 29 Feb 2012 19:33:07 +0000 (19:33 +0000)]
Rename action_name's member takes_value to value_type as it isn't used as boolean

12 years agoUse an enum for the type of the action value.
Fabian Keil [Wed, 29 Feb 2012 19:31:12 +0000 (19:31 +0000)]
Use an enum for the type of the action value.

12 years agoBlock 'optimize.indieclick.com/' and 'optimized-by.rubiconproject.com/'
Fabian Keil [Wed, 29 Feb 2012 19:28:14 +0000 (19:28 +0000)]
Block 'optimize.indieclick.com/' and 'optimized-by.rubiconproject.com/'

12 years agoFix spelling of 'unknown' in default_exports()
Fabian Keil [Sat, 31 Dec 2011 14:54:28 +0000 (14:54 +0000)]
Fix spelling of 'unknown' in default_exports()

Seen in Roland's 29_typos.dpatch.

12 years agoFix 'resource' spelling in the code as well
Fabian Keil [Sat, 31 Dec 2011 14:54:05 +0000 (14:54 +0000)]
Fix 'resource' spelling in the code as well

12 years agoFix 'resource' spelling in the documentation
Fabian Keil [Sat, 31 Dec 2011 14:53:47 +0000 (14:53 +0000)]
Fix 'resource' spelling in the documentation

Seen in Roland's 29_typos.dpatch.

12 years agoRemove a duplicated dot in a comment
Fabian Keil [Sat, 31 Dec 2011 14:53:18 +0000 (14:53 +0000)]
Remove a duplicated dot in a comment

12 years agoRedirect requests for http://config.privoxy.org/.* to http://www.privoxy.org/config/
Fabian Keil [Sat, 31 Dec 2011 14:52:48 +0000 (14:52 +0000)]
Redirect requests for config.privoxy.org/.* to http://privoxy.org/config/

config.privoxy.org used to be a separate server that was
administrated by Andreas, but will be relocated to the SF
webserver after the domain transfer is done.

Note that the things SF calls VHOSTS all point to the
same root directory, so we can't use a dedicated .htaccess
file for config.privoxy.org.

12 years agoAdjust attribution and fix the URL of this file on the server
Fabian Keil [Sat, 31 Dec 2011 14:51:51 +0000 (14:51 +0000)]
Adjust attribution and fix the URL of this file on the server

12 years agoManually bump the copyright range to 2011
Fabian Keil [Sat, 31 Dec 2011 14:51:15 +0000 (14:51 +0000)]
Manually bump the copyright range to 2011

12 years agoDitch the already-dead update_action_bits_for_all_tags()
Fabian Keil [Sat, 31 Dec 2011 14:50:20 +0000 (14:50 +0000)]
Ditch the already-dead update_action_bits_for_all_tags()

12 years agoFix grammar in get_action_token()'s description
Fabian Keil [Sat, 31 Dec 2011 14:49:58 +0000 (14:49 +0000)]
Fix grammar in get_action_token()'s description

12 years agoFix the description of create_forged_referrer()
Fabian Keil [Sat, 31 Dec 2011 14:49:39 +0000 (14:49 +0000)]
Fix the description of create_forged_referrer()