From: Fabian Keil <fk@fabiankeil.de>
Date: Wed, 6 Aug 2008 18:33:36 +0000 (+0000)
Subject: If the "close fd first" workaround doesn't work,
X-Git-Tag: v_3_0_10~32
X-Git-Url: http://www.privoxy.org/gitweb/templates.html?a=commitdiff_plain;h=1a03aa994447861a55b953bdfdc0882b8d130245;p=privoxy.git

If the "close fd first" workaround doesn't work,
the fatal error message will be lost, so we better
explain the consequences while we still can.
---

diff --git a/errlog.c b/errlog.c
index e8eb994f..047b171e 100644
--- a/errlog.c
+++ b/errlog.c
@@ -1,4 +1,4 @@
-const char errlog_rcs[] = "$Id: errlog.c,v 1.72 2008/07/27 12:04:28 fabiankeil Exp $";
+const char errlog_rcs[] = "$Id: errlog.c,v 1.73 2008/08/04 19:06:55 fabiankeil Exp $";
 /*********************************************************************
  *
  * File        :  $Source: /cvsroot/ijbswa/current/errlog.c,v $
@@ -33,6 +33,11 @@ const char errlog_rcs[] = "$Id: errlog.c,v 1.72 2008/07/27 12:04:28 fabiankeil E
  *
  * Revisions   :
  *    $Log: errlog.c,v $
+ *    Revision 1.73  2008/08/04 19:06:55  fabiankeil
+ *    Add a lame workaround for the "can't open an already open
+ *    logfile on OS/2" problem reported by Maynard in #2028842
+ *    and describe what a real solution would look like.
+ *
  *    Revision 1.72  2008/07/27 12:04:28  fabiankeil
  *    Fix a comment typo.
  *
@@ -639,6 +644,10 @@ void init_error_log(const char *prog_name, const char *logfname)
        * reopen it if the file name changed or if the
        * configuration reloas was caused by a SIGHUP.
        */
+      log_error(LOG_LEVEL_INFO, "Failed to reopen logfile: \'%s\'. "
+         "Retrying after closing the old file descriptor first. If that "
+         "doesn't work, Privoxy will exit without being able to log a message.",
+         logfname);
       lock_logfile();
       fclose(logfp);
       logfp = NULL;