nit: note expected behavior
authorLee <ler762@users.sourceforge.net>
Wed, 7 Jul 2021 02:53:52 +0000 (22:53 -0400)
committerLee <ler762@users.sourceforge.net>
Wed, 7 Jul 2021 02:53:52 +0000 (22:53 -0400)
If building for Windows with -Wimplicit-fallthrough you'll get a warning message about
"this statement may fall through."  Make it clear this is expected.

i686-w64-mingw32-gcc -c -Imbedtls/include -pipe -O2 -fstack-protector-strong -D_FORTIFY_SOURCE=2 -march=native -Wall -Wextra -Wno-missing-field-initializers -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-but-set-variable -Wformat=2 -Wno-format-nonliteral -Wlogical-op -Wshadow -Wuninitialized -Winit-self -DNDEBUG -DWINVER=0x501  -I/source/pcre-8.44/ -I/source/mbedtls-2.16.10/include -I/source/brotli-1.0.9/c/include  -mwindows -Wall  w32log.c -o w32log.o
w32log.c: In function ‘LogWindowProc’:
w32log.c:1190:27: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1190 |          g_bShowLogWindow = wParam;
      |          ~~~~~~~~~~~~~~~~~^~~~~~~~
w32log.c:1191:7: note: here
 1191 |       case WM_SIZE:  /* note: implicit-fallthrough */
      |       ^~~~

w32log.c

index b60eae7..c7e3540 100644 (file)
--- a/w32log.c
+++ b/w32log.c
@@ -1187,7 +1187,7 @@ LRESULT CALLBACK LogWindowProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lPara
 
       case WM_SHOWWINDOW:
          g_bShowLogWindow = wParam;
-      case WM_SIZE:
+      case WM_SIZE:  /* note: implicit-fallthrough */
          /* Resize the logging window to fit the new frame */
          if (g_hwndLogBox)
          {