From b61d113242ae011a41e56ccc915644ce1716ea88 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Wed, 30 Jun 2021 14:58:12 +0200 Subject: [PATCH] mbedTLS get_ciphersuites_from_string(): Use strlcpy() instead of strncpy() Previously the terminating NUL wasn't copied which resulted in a compiler warning. This didn't cause actual problems as the target buffer was initialized by zalloc_or_die() so the last byte of the target buffer was NUL already. Actually copying the terminating NUL seems clearer, though. Reported by: Lee --- ssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ssl.c b/ssl.c index 18661547..afd9af45 100644 --- a/ssl.c +++ b/ssl.c @@ -1977,7 +1977,7 @@ static int *get_ciphersuites_from_string(const char *parameter_string) size_t parameter_len = strlen(parameter_string); ciphersuites_string = zalloc_or_die(parameter_len + 1); - strncpy(ciphersuites_string, parameter_string, parameter_len); + strlcpy(ciphersuites_string, parameter_string, parameter_len + 1); ciphersuites_index = ciphersuites_string; while (*ciphersuites_index) -- 2.39.2