From: Fabian Keil <fk@fabiankeil.de>
Date: Wed, 30 Jun 2021 12:58:12 +0000 (+0200)
Subject: mbedTLS get_ciphersuites_from_string(): Use strlcpy() instead of strncpy()
X-Git-Tag: v_3_0_33~74
X-Git-Url: http://www.privoxy.org/gitweb/contact.html?a=commitdiff_plain;h=b61d113242ae011a41e56ccc915644ce1716ea88;p=privoxy.git

mbedTLS get_ciphersuites_from_string(): Use strlcpy() instead of strncpy()

Previously the terminating NUL wasn't copied which resulted
in a compiler warning. This didn't cause actual problems as
the target buffer was initialized by zalloc_or_die() so the
last byte of the target buffer was NUL already.

Actually copying the terminating NUL seems clearer, though.

Reported by: Lee
---

diff --git a/ssl.c b/ssl.c
index 18661547..afd9af45 100644
--- a/ssl.c
+++ b/ssl.c
@@ -1977,7 +1977,7 @@ static int *get_ciphersuites_from_string(const char *parameter_string)
    size_t parameter_len = strlen(parameter_string);
 
    ciphersuites_string = zalloc_or_die(parameter_len + 1);
-   strncpy(ciphersuites_string, parameter_string, parameter_len);
+   strlcpy(ciphersuites_string, parameter_string, parameter_len + 1);
    ciphersuites_index = ciphersuites_string;
 
    while (*ciphersuites_index)