From: Fabian Keil <fk@fabiankeil.de>
Date: Wed, 3 Feb 2021 18:08:20 +0000 (+0100)
Subject: ssplit(): Remove an assertion
X-Git-Tag: v_3_0_32~14
X-Git-Url: http://www.privoxy.org/gitweb/contact.html?a=commitdiff_plain;h=2256d7b4d67dd9c364386877d5af59943433458b;p=privoxy.git

ssplit(): Remove an assertion

... that could be triggered with a crafted CGI request.

This reverts dc4e311bcf.

OVE-20210203-0001.

Reported by: Joshua Rogers (Opera)
---

diff --git a/ssplit.c b/ssplit.c
index ef40e644..ec0f1db2 100644
--- a/ssplit.c
+++ b/ssplit.c
@@ -36,7 +36,6 @@
 
 #include <string.h>
 #include <stdlib.h>
-#include <assert.h>
 
 #include "ssplit.h"
 #include "miscutil.h"
@@ -150,8 +149,6 @@ int ssplit(char *str, const char *delim, char *vec[], size_t vec_len)
       }
    }
    /* null terminate the substring */
-   /* XXX: this shouldn't be necessary, so assert that it isn't. */
-   assert(*str == '\0');
    *str = '\0';
 
    return(vec_count);