-const char urlmatch_rcs[] = "$Id: urlmatch.c,v 1.83 2014/06/20 09:46:56 fabiankeil Exp $";
+const char urlmatch_rcs[] = "$Id: urlmatch.c,v 1.87 2016/02/26 12:29:39 fabiankeil Exp $";
/*********************************************************************
*
* File : $Source: /cvsroot/ijbswa/current/urlmatch.c,v $
}
+/*********************************************************************
+ *
+ * Function : normalize_http_version
+ *
+ * Description : Take a supported HTTP version string and remove
+ * leading zeroes etc., reject unsupported versions.
+ *
+ * This is an explicit RFC 2616 (3.1) MUST and
+ * RFC 7230 mandates that intermediaries send their
+ * own HTTP-version in forwarded messages.
+ *
+ * Parameters :
+ * 1 : http_version = HTTP version string
+ *
+ * Returns : JB_ERR_OK on success
+ * JB_ERR_PARSE if the HTTP version is unsupported
+ *
+ *********************************************************************/
+jb_err static normalize_http_version(char *http_version)
+{
+ unsigned int major_version;
+ unsigned int minor_version;
+
+ if (2 != sscanf(http_version, "HTTP/%u.%u", &major_version, &minor_version))
+ {
+ log_error(LOG_LEVEL_ERROR, "Unsupported HTTP version: %s", http_version);
+ return JB_ERR_PARSE;
+ }
+
+ if (major_version != 1 || (minor_version != 0 && minor_version != 1))
+ {
+ log_error(LOG_LEVEL_ERROR, "The only supported HTTP "
+ "versions are 1.0 and 1.1. This rules out: %s", http_version);
+ return JB_ERR_PARSE;
+ }
+
+ assert(strlen(http_version) >= 8);
+ snprintf(http_version, 9, "HTTP/%u.%u", major_version, minor_version);
+
+ return JB_ERR_OK;
+
+}
+
+
/*********************************************************************
*
* Function : parse_http_request
return JB_ERR_PARSE;
}
- if (strcmpic(v[2], "HTTP/1.1") && strcmpic(v[2], "HTTP/1.0"))
+ if (JB_ERR_OK != normalize_http_version(v[2]))
{
- log_error(LOG_LEVEL_ERROR, "The only supported HTTP "
- "versions are 1.0 and 1.1. This rules out: %s", v[2]);
freez(buf);
return JB_ERR_PARSE;
}
* 4 : regex = Where the compiled regex should be stored.
*
* Returns : JB_ERR_OK - Success
- * JB_ERR_MEMORY - Out of memory
* JB_ERR_PARSE - Cannot parse regex
*
*********************************************************************/
"Invalid anchoring in compile_pattern %d", anchoring);
}
- *regex = zalloc(sizeof(**regex));
- if (NULL == *regex)
- {
- free_pattern_spec(url);
- return JB_ERR_MEMORY;
- }
+ *regex = zalloc_or_die(sizeof(**regex));
snprintf(rebuf, sizeof(rebuf), fmt, pattern);
const unsigned flag;
} tag_pattern[] = {
{ "TAG:", 4, PATTERN_SPEC_TAG_PATTERN},
+ #ifdef FEATURE_CLIENT_TAGS
+ { "CLIENT-TAG:", 11, PATTERN_SPEC_CLIENT_TAG_PATTERN},
+ #endif
{ "NO-REQUEST-TAG:", 15, PATTERN_SPEC_NO_REQUEST_TAG_PATTERN},
{ "NO-RESPONSE-TAG:", 16, PATTERN_SPEC_NO_RESPONSE_TAG_PATTERN}
};
static int host_matches(const struct http_request *http,
const struct pattern_spec *pattern)
{
+ assert(http->host != NULL);
#ifdef FEATURE_EXTENDED_HOST_PATTERNS
return ((NULL == pattern->pattern.url_spec.host_regex)
|| (0 == regexec(pattern->pattern.url_spec.host_regex, http->host, 0, NULL, 0)));