unload_configfile(): Use unload_forward_spec() instead of doing the work itself
authorFabian Keil <fk@fabiankeil.de>
Mon, 2 Mar 2020 11:36:40 +0000 (12:36 +0100)
committerFabian Keil <fk@fabiankeil.de>
Mon, 2 Mar 2020 17:44:58 +0000 (18:44 +0100)
... poorly. Previously the socks user name and password were leaked.

Sponsored by: Robert Klemme

loadcfg.c

index 0c8b890..7d8c392 100644 (file)
--- a/loadcfg.c
+++ b/loadcfg.c
@@ -239,11 +239,9 @@ static void unload_configfile (void * data)
    while (cur_fwd != NULL)
    {
       struct forward_spec * next_fwd = cur_fwd->next;
-      free_pattern_spec(cur_fwd->url);
 
-      freez(cur_fwd->gateway_host);
-      freez(cur_fwd->forward_host);
-      free(cur_fwd);
+      unload_forward_spec(cur_fwd);
+
       cur_fwd = next_fwd;
    }
    config->forward = NULL;