From: Fabian Keil <fk@fabiankeil.de>
Date: Wed, 31 May 2023 10:29:18 +0000 (+0200)
Subject: log_error() Win32: Only call LogShowActivity() for debug level LOG_LEVEL_REQUEST
X-Git-Tag: v_4_0_0~188
X-Git-Url: http://www.privoxy.org/gitweb/@default-cgi@/static/user-manual/faq/@default-cgi@send-stylesheet?a=commitdiff_plain;h=70e904f66cfd8198f4e7325d0fb06405dd2f5038;p=privoxy.git

log_error() Win32: Only call LogShowActivity() for debug level LOG_LEVEL_REQUEST

As of b94bbe62a950, which was part of Privoxy 3.0.29,
LOG_LEVEL_REQUEST is used for all requests including
crunched ones.

Previously LogShowActivity() was called twice for crunched
requests, (presumably) resulting in an aborted animation.
---

diff --git a/errlog.c b/errlog.c
index e1d99259..27bb4e0c 100644
--- a/errlog.c
+++ b/errlog.c
@@ -659,11 +659,11 @@ void log_error(int loglevel, const char *fmt, ...)
 
 #if defined(_WIN32) && !defined(_WIN_CONSOLE)
    /*
-    * Irrespective of debug setting, a GET/POST/CONNECT makes
-    * the taskbar icon animate.  (There is an option to disable
-    * this but checking that is handled inside LogShowActivity()).
+    * Irrespective of debug setting, a request makes the taskbar icon
+    * animate. (There is an option to disable this but checking that is
+    * handled inside LogShowActivity()).
     */
-   if ((loglevel == LOG_LEVEL_REQUEST) || (loglevel == LOG_LEVEL_CRUNCH))
+   if (loglevel == LOG_LEVEL_REQUEST)
    {
       LogShowActivity();
    }