From 67c8e347acffd64dad57a89df9fd53cc17b7ea80 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 8 May 2016 10:45:32 +0000 Subject: [PATCH 1/1] edit_read_line(): Remove a pointless pointer check coverity complaints about (CID #161211) --- loaders.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/loaders.c b/loaders.c index 92d8cec3..2c84b327 100644 --- a/loaders.c +++ b/loaders.c @@ -1,4 +1,4 @@ -const char loaders_rcs[] = "$Id: loaders.c,v 1.101 2016/02/26 12:29:38 fabiankeil Exp $"; +const char loaders_rcs[] = "$Id: loaders.c,v 1.102 2016/02/26 12:30:46 fabiankeil Exp $"; /********************************************************************* * * File : $Source: /cvsroot/ijbswa/current/loaders.c,v $ @@ -630,15 +630,12 @@ jb_err edit_read_line(FILE *fp, if (*linestart) { is_empty = 0; - if (data) + if (string_append(&data, linestart)) { - if (string_append(&data, linestart)) - { - freez(raw); - freez(prefix); - free(linebuf); - return JB_ERR_MEMORY; - } + freez(raw); + freez(prefix); + free(linebuf); + return JB_ERR_MEMORY; } } -- 2.39.2