privoxy.git
22 months agossl_store_cert(): Handle html_encode() failures
Fabian Keil [Wed, 26 Aug 2020 13:45:47 +0000 (15:45 +0200)]
ssl_store_cert(): Handle html_encode() failures

Sponsored by: Robert Klemme

22 months agossl_send_data(): Prevent endless loop
Fabian Keil [Tue, 25 Aug 2020 18:09:04 +0000 (20:09 +0200)]
ssl_send_data(): Prevent endless loop

... if BIO_write() consistently returns 0.

Sponsored by: Robert Klemme

22 months agocreate_server_ssl_connection(): Improve the error message emitted when the handshake...
Fabian Keil [Mon, 24 Aug 2020 13:02:52 +0000 (15:02 +0200)]
create_server_ssl_connection(): Improve the error message emitted when the handshake fails

Sponsored by: Robert Klemme

22 months agocreate_client_ssl_connection(): Improve the error message emitted when the handshake...
Fabian Keil [Mon, 24 Aug 2020 09:23:28 +0000 (11:23 +0200)]
create_client_ssl_connection(): Improve the error message emitted when the handshake fails

Sponsored by: Robert Klemme

22 months agolog_ssl_errors(): Refer to TLS/SSL errors instead of just SSL errors
Fabian Keil [Mon, 24 Aug 2020 09:13:04 +0000 (11:13 +0200)]
log_ssl_errors(): Refer to TLS/SSL errors instead of just SSL errors

Sponsored by: Robert Klemme

22 months agossl_send_certificate_error(): Fix spelling in the error message
Fabian Keil [Fri, 21 Aug 2020 11:45:49 +0000 (13:45 +0200)]
ssl_send_certificate_error(): Fix spelling in the error message

Sponsored by: Robert Klemme

22 months agoExpand Source tag
Fabian Keil [Thu, 20 Aug 2020 21:33:29 +0000 (23:33 +0200)]
Expand Source tag

Sponsored by: Robert Klemme

22 months agoAdjust Source tags
Fabian Keil [Thu, 20 Aug 2020 21:32:00 +0000 (23:32 +0200)]
Adjust Source tags

Sponsored by: Robert Klemme

22 months agossl_store_cert(): Fix typo in an error message
Fabian Keil [Wed, 26 Aug 2020 09:25:02 +0000 (11:25 +0200)]
ssl_store_cert(): Fix typo in an error message

22 months agocreate_server_ssl_connection(): Mimic SSL_set1_host() if it does not exist
Fabian Keil [Wed, 26 Aug 2020 08:31:23 +0000 (10:31 +0200)]
create_server_ssl_connection(): Mimic SSL_set1_host() if it does not exist

Sponsored by: Robert Klemme

22 months agossl_store_cert(): Only use X509_get0_tbs_sigalg() on more recent OpenSSL versions
Fabian Keil [Wed, 26 Aug 2020 08:30:36 +0000 (10:30 +0200)]
ssl_store_cert(): Only use X509_get0_tbs_sigalg() on more recent OpenSSL versions

... so the function compiles with OpenSSL 1.0.2.

Sponsored by: Robert Klemme

22 months agoAdd defines for some more X509 functions
Fabian Keil [Wed, 26 Aug 2020 08:17:50 +0000 (10:17 +0200)]
Add defines for some more X509 functions

... that don't exist when using OpenSSL 1.0.2.

Sponsored by: Robert Klemme

22 months agoUse X509_set_notBefore() and X509_set_notAfter()
Fabian Keil [Thu, 20 Aug 2020 20:01:32 +0000 (22:01 +0200)]
Use X509_set_notBefore() and X509_set_notAfter()

... when compiling with OpenSSL versions earlier than 1.1.0.

Sponsored by: Robert Klemme

22 months agoRemove 'const' from set_x509_ext()'s value parameter
Fabian Keil [Thu, 20 Aug 2020 19:31:46 +0000 (21:31 +0200)]
Remove 'const' from set_x509_ext()'s value parameter

Silences the following warning when compiling with OpenSSL 1.0.2t.

     openssl.c:1213:47: warning: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
        ext = X509V3_EXT_conf_nid(NULL, &ctx, nid, value);
                                                   ^~~~~
     /usr/include/openssl/x509v3.h:627:43: note: passing argument to parameter 'value' here
                                         char *value);
                                               ^
Sponsored by: Robert Klemme

22 months agoAdd copyright header for Vaclav and me
Fabian Keil [Thu, 20 Aug 2020 12:15:52 +0000 (14:15 +0200)]
Add copyright header for Vaclav and me

... as the file is based on ssl.c

Sponsored by: Robert Klemme

22 months agoFix a comment typo
Fabian Keil [Thu, 27 Aug 2020 10:59:40 +0000 (12:59 +0200)]
Fix a comment typo

Sponsored by: Robert Klemme

22 months agoFix a couple of 'Parameters' comment sections
Fabian Keil [Thu, 27 Aug 2020 11:04:11 +0000 (13:04 +0200)]
Fix a couple of 'Parameters' comment sections

Sponsored by: Robert Klemme

22 months agoRemove bogus spaces in the ssl_base64_encode() prototype
Fabian Keil [Wed, 26 Aug 2020 17:35:47 +0000 (19:35 +0200)]
Remove bogus spaces in the ssl_base64_encode() prototype

Sponsored by: Robert Klemme

22 months agoRemove commented-out mbedTLS-specific code in the OpenSSL section
Fabian Keil [Tue, 1 Sep 2020 10:07:39 +0000 (12:07 +0200)]
Remove commented-out mbedTLS-specific code in the OpenSSL section

22 months agoStyle fixes for the OpenSSL-specific code
Fabian Keil [Thu, 20 Aug 2020 10:48:56 +0000 (12:48 +0200)]
Style fixes for the OpenSSL-specific code

Sponsored by: Robert Klemme

22 months agoReplace a stray reference to mbedtls with OpenSSL
Fabian Keil [Thu, 20 Aug 2020 10:48:11 +0000 (12:48 +0200)]
Replace a stray reference to mbedtls with OpenSSL

Sponsored by: Robert Klemme

22 months agoAdd OpenSSL support
Maxim Antonov [Mon, 3 Aug 2020 11:11:37 +0000 (18:11 +0700)]
Add OpenSSL support

To enable it, configure with "--with-openssl".

This is mainly useful for platforms that ship with
OpenSSL in the base so the "special exception" from
section 3 of the GPLv2 applies.

The author (Maxim Antonov) reports about 100% more requests
per second when using OpenSSL instead of MbedTLS which the
committer could confirm. For details see:
https://sourceforge.net/p/ijbswa/patches/143/

This commit has a couple of issues that will be addressed
in follow-up commits.

22 months agoget_block_reason_statistics_table(): Add new lines between table rows
Fabian Keil [Mon, 10 Aug 2020 15:55:15 +0000 (17:55 +0200)]
get_block_reason_statistics_table(): Add new lines between table rows

Sponsored by: Robert Klemme

22 months agoRemove references to 'pcrs-suppport' in the show-status template
Fabian Keil [Sun, 9 Aug 2020 10:30:38 +0000 (12:30 +0200)]
Remove references to 'pcrs-suppport' in the show-status template

It no longer exists, pcrs support has been mandatory for a while.

22 months agoRemove reference to 'redirect-url' in the show-status template
Fabian Keil [Sun, 9 Aug 2020 10:14:57 +0000 (12:14 +0200)]
Remove reference to 'redirect-url' in the show-status template

22 months agoRemove reference to 'sourceversions' in the show-status template
Fabian Keil [Sun, 9 Aug 2020 10:12:00 +0000 (12:12 +0200)]
Remove reference to 'sourceversions' in the show-status template

22 months agoGather statistics for block reasons
Fabian Keil [Fri, 7 Aug 2020 09:08:23 +0000 (11:08 +0200)]
Gather statistics for block reasons

... if FEATURE_EXTENDED_STATISTICS is enabled.

Sponsored by: Robert Klemme

22 months agoBump copyright
Fabian Keil [Fri, 7 Aug 2020 08:40:15 +0000 (10:40 +0200)]
Bump copyright

22 months agoAdd FEATURE_EXTENDED_STATISTICS to gather filter statistics
Fabian Keil [Thu, 6 Aug 2020 09:52:19 +0000 (11:52 +0200)]
Add FEATURE_EXTENDED_STATISTICS to gather filter statistics

Sponsored by: Robert Klemme

22 months agoFix indentation of --fuzz description.
Fabian Keil [Fri, 7 Aug 2020 13:27:09 +0000 (15:27 +0200)]
Fix indentation of --fuzz description.

Sponsored by: Robert Klemme

22 months agoFix indentation of --enable-pcre-host-patterns description
Fabian Keil [Fri, 7 Aug 2020 13:24:41 +0000 (15:24 +0200)]
Fix indentation of --enable-pcre-host-patterns description

Sponsored by: Robert Klemme

22 months agoChange two block reasons that previsouly were the same
Fabian Keil [Fri, 7 Aug 2020 10:30:22 +0000 (12:30 +0200)]
Change two block reasons that previsouly were the same

Sponsored by: Robert Klemme

22 months agoRemove www.betrugstest.com from the list of sponsors
Fabian Keil [Fri, 7 Aug 2020 08:17:40 +0000 (10:17 +0200)]
Remove betrugstest.com from the list of sponsors

22 months agoFix typo in error message
Fabian Keil [Thu, 6 Aug 2020 08:44:08 +0000 (10:44 +0200)]
Fix typo in error message

Sponsored by: Robert Klemme

22 months agoRemove #80 which is done
Fabian Keil [Wed, 5 Aug 2020 09:28:44 +0000 (11:28 +0200)]
Remove #80 which is done

22 months agoRegenerate docs
Fabian Keil [Wed, 5 Aug 2020 10:53:56 +0000 (12:53 +0200)]
Regenerate docs

22 months agoDocument the 'PCRE-HOST-PATTERN:' prefix
Fabian Keil [Wed, 5 Aug 2020 10:53:00 +0000 (12:53 +0200)]
Document the 'PCRE-HOST-PATTERN:' prefix

Sponsored by: Robert Klemme

22 months agotools/url-pattern-translator.pl: Detect a couple of pattern prefixes case-insensitively
Fabian Keil [Wed, 5 Aug 2020 10:48:35 +0000 (12:48 +0200)]
tools/url-pattern-translator.pl: Detect a couple of pattern prefixes case-insensitively

Sponsored by: Robert Klemme

22 months agotools/url-pattern-translator.pl: Skip CLIENT-TAG patterns
Fabian Keil [Wed, 5 Aug 2020 10:34:13 +0000 (12:34 +0200)]
tools/url-pattern-translator.pl: Skip CLIENT-TAG patterns

Sponsored by: Robert Klemme

22 months agotools/url-pattern-translator.pl: Skip patterns that have already been converted
Fabian Keil [Wed, 5 Aug 2020 09:23:06 +0000 (11:23 +0200)]
tools/url-pattern-translator.pl: Skip patterns that have already been converted

It should now be safe to "convert" a file multiple times.

Sponsored by: Robert Klemme

22 months agotools/url-pattern-translator.pl: Add the new 'PCRE-HOST-PATTERN:' prefix
Fabian Keil [Wed, 5 Aug 2020 09:21:06 +0000 (11:21 +0200)]
tools/url-pattern-translator.pl: Add the new 'PCRE-HOST-PATTERN:' prefix

Sponsored by: Robert Klemme

22 months agoUpdate configure description of FEATURE_PCRE_HOST_PATTERNS
Fabian Keil [Wed, 5 Aug 2020 09:15:47 +0000 (11:15 +0200)]
Update configure description of FEATURE_PCRE_HOST_PATTERNS

Sponsored by: Robert Klemme

22 months agoRename FEATURE_EXTENDED_HOST_PATTERNS to FEATURE_PCRE_HOST_PATTERNS
Fabian Keil [Wed, 5 Aug 2020 09:13:49 +0000 (11:13 +0200)]
Rename FEATURE_EXTENDED_HOST_PATTERNS to FEATURE_PCRE_HOST_PATTERNS

Sponsored by: Robert Klemme

22 months agoBump copyright
Fabian Keil [Mon, 3 Aug 2020 13:20:52 +0000 (15:20 +0200)]
Bump copyright

22 months agoAllow to use extended host patterns and vanilla host patterns at the same time
Fabian Keil [Mon, 3 Aug 2020 11:12:32 +0000 (13:12 +0200)]
Allow to use extended host patterns and vanilla host patterns at the same time

... by prefixing extended host patterns with "PCRE-HOST-PATTERN:".

Sponsored by: Robert Klemme

22 months agoCollapse two if blocks into one
Fabian Keil [Thu, 23 Jul 2020 12:00:53 +0000 (14:00 +0200)]
Collapse two if blocks into one

Sponsored by: Robert Klemme

23 months agoInstall the GPLv3 with the "install" target
Fabian Keil [Wed, 22 Jul 2020 18:55:32 +0000 (20:55 +0200)]
Install the GPLv3 with the "install" target

... and include it in the tar ball created with the "gen-dist" target.

23 months agoRebuild man page
Fabian Keil [Wed, 22 Jul 2020 12:26:13 +0000 (14:26 +0200)]
Rebuild man page

23 months agoRegenerate docs
Fabian Keil [Wed, 22 Jul 2020 10:27:27 +0000 (12:27 +0200)]
Regenerate docs

23 months agoImprove the "ignore-certificate-errors" description
Fabian Keil [Wed, 22 Jul 2020 12:45:49 +0000 (14:45 +0200)]
Improve the "ignore-certificate-errors" description

23 months agoClarify that Privoxy is licensed under GPLv2 or later
Fabian Keil [Wed, 22 Jul 2020 13:50:30 +0000 (15:50 +0200)]
Clarify that Privoxy is licensed under GPLv2 or later

23 months agoBump copyright
Fabian Keil [Wed, 22 Jul 2020 12:25:30 +0000 (14:25 +0200)]
Bump copyright

23 months agolicense.sgml: Explain that Privoxy has to be distributed under the GPLv3 (or later...
Fabian Keil [Wed, 22 Jul 2020 12:10:06 +0000 (14:10 +0200)]
license.sgml: Explain that Privoxy has to be distributed under the GPLv3 (or later) when linked with mbedTLS

23 months agoInclude the GPLv3 in the user manual
Fabian Keil [Wed, 22 Jul 2020 10:25:41 +0000 (12:25 +0200)]
Include the GPLv3 in the user manual

... and mention that it applies when Privoxy is linked
with mbedTLS.

23 months agoImport the GNU GPLv3
Fabian Keil [Wed, 22 Jul 2020 08:52:22 +0000 (10:52 +0200)]
Import the GNU GPLv3

It can be used when Privoxy is linked to mbedTLS
whose recent versions are only distributed under the
Apache 2.0 license which is incompatible with the
GPLv2 but compatible with the GPLv3.

23 months agopcrs.3: Update pcrs license
Fabian Keil [Wed, 22 Jul 2020 12:00:32 +0000 (14:00 +0200)]
pcrs.3: Update pcrs license

23 months agopcrs.3: Change URL to https://
Fabian Keil [Wed, 22 Jul 2020 11:56:32 +0000 (13:56 +0200)]
pcrs.3: Change URL to https://

23 months agoClarify FEATURE_FORCE_LOAD description
Fabian Keil [Wed, 22 Jul 2020 10:21:27 +0000 (12:21 +0200)]
Clarify FEATURE_FORCE_LOAD description

It allows to bypass blocking not filtering and only
does it if blocks aren't enforced.

Reported by: Robert Klemme

23 months agoOnly use the Subject Alternative Name extension if it isn't an IP address
Fabian Keil [Mon, 20 Jul 2020 13:10:16 +0000 (15:10 +0200)]
Only use the Subject Alternative Name extension if it isn't an IP address

Sponsored by: Robert Klemme

23 months agoRegenerate config file
Fabian Keil [Sun, 19 Jul 2020 12:52:24 +0000 (14:52 +0200)]
Regenerate config file

23 months agoRegenerate docs
Fabian Keil [Sun, 19 Jul 2020 12:45:01 +0000 (14:45 +0200)]
Regenerate docs

23 months agoFix typo
Fabian Keil [Sun, 19 Jul 2020 12:42:29 +0000 (14:42 +0200)]
Fix typo

23 months agoconfig: Rename 'TLS/SSL' section to 'TLS/SSL Inspection'
Fabian Keil [Sun, 19 Jul 2020 12:39:59 +0000 (14:39 +0200)]
config: Rename 'TLS/SSL' section to 'TLS/SSL Inspection'

Suggested by: Lee

23 months agoreceive_encrypted_request(): Use the socket-timeout when waiting for new data
Fabian Keil [Sat, 18 Jul 2020 12:04:11 +0000 (14:04 +0200)]
receive_encrypted_request(): Use the socket-timeout when waiting for new data

Previously the keep-alive-timeout was being used which
was inappropriate as we are waiting for data that belongs
to the same request.

Sponsored by: Robert Klemme

23 months agoreceive_encrypted_request(): Properly deal with pending data
Fabian Keil [Sat, 18 Jul 2020 11:47:36 +0000 (13:47 +0200)]
receive_encrypted_request(): Properly deal with pending data

... that has already been received and is thus invisible to
data_is_available().

Previously encrypted client requests that were too large
to be read with a single ssl_recv_data() call could be
rejected as invalid if all the data arrived quickly enough.

Apparently this happended frequently on gmail due to
large Cookies.

Reported by: Robert Klemme
Sponsored by: Robert Klemme

2 years agoSync with updated 'Cautious' template
Fabian Keil [Fri, 26 Jun 2020 05:15:34 +0000 (07:15 +0200)]
Sync with updated 'Cautious' template

... which no longer enables the 'no-brotli-accepted' client-header filter.

This reverts commit 3e65e04181a1face1f3c3ef6e1481f674aa1a05f.

2 years agoStop enabling 'no-brotli-accepted' client-header filter in all templates again
Fabian Keil [Fri, 26 Jun 2020 05:13:52 +0000 (07:13 +0200)]
Stop enabling 'no-brotli-accepted' client-header filter in all templates again

... as we have FEATURE_BROTLI now.

This reverts commit c39e3b6489041ce5a4fa0c30481dd2cae3f4ce5a.

2 years agoRemove #159 "Support Brotli compression." which is done
Fabian Keil [Thu, 25 Jun 2020 14:59:01 +0000 (16:59 +0200)]
Remove #159 "Support Brotli compression." which is done

2 years agoBump copyright
Fabian Keil [Thu, 25 Jun 2020 09:48:41 +0000 (11:48 +0200)]
Bump copyright

2 years agoBump copyright
Fabian Keil [Thu, 11 Jun 2020 16:31:45 +0000 (18:31 +0200)]
Bump copyright

2 years agoAdd support for Brotli decompression
Fabian Keil [Thu, 11 Jun 2020 09:20:14 +0000 (11:20 +0200)]
Add support for Brotli decompression

Using Google's brotli library:
https://github.com/google/brotli

Sponsored by: Robert Klemme

2 years agoAdd fast-redirects exception for .wikipedia.org/
Fabian Keil [Fri, 19 Jun 2020 15:04:12 +0000 (17:04 +0200)]
Add fast-redirects exception for .wikipedia.org/

2 years agossl_send_certificate_error(): Add a doctype
Fabian Keil [Mon, 15 Jun 2020 08:34:14 +0000 (10:34 +0200)]
ssl_send_certificate_error(): Add a doctype

Sponsored by: Robert Klemme

2 years agossl_send_certificate_error(): Add a page title
Fabian Keil [Fri, 12 Jun 2020 13:08:45 +0000 (15:08 +0200)]
ssl_send_certificate_error(): Add a page title

Sponsored by: Robert Klemme

2 years agoDon't add '-Imbedtls/include' to the CFLAGS when not building with mbedTLS
Fabian Keil [Thu, 11 Jun 2020 18:11:28 +0000 (20:11 +0200)]
Don't add '-Imbedtls/include' to the CFLAGS when not building with mbedTLS

Sponsored by: Robert Klemme

2 years agoconfigure.in: Start --with(out)-mbedtls descriptions with upper-case characters
Fabian Keil [Thu, 11 Jun 2020 16:30:13 +0000 (18:30 +0200)]
configure.in: Start --with(out)-mbedtls descriptions with upper-case characters

Sponsored by: Robert Klemme

2 years agossl_send_certificate_error(): Make it more obvious that the message is coming from...
Fabian Keil [Sat, 6 Jun 2020 07:28:00 +0000 (09:28 +0200)]
ssl_send_certificate_error(): Make it more obvious that the message is coming from Privoxy

Suggested by: Roland
Sponsored by: Robert Klemme

2 years agoDisable fast-redirects for .consensu.org/delivery/pixel\.php and block the requests...
Fabian Keil [Thu, 11 Jun 2020 13:02:34 +0000 (15:02 +0200)]
Disable fast-redirects for .consensu.org/delivery/pixel\.php and block the requests as image instead

2 years agoprivoxy-log-parser.pl: Unbreak the gathering of host statistics with http requests
Fabian Keil [Tue, 9 Jun 2020 08:07:09 +0000 (10:07 +0200)]
privoxy-log-parser.pl: Unbreak the gathering of host statistics with http requests

... and CONNECT requests.

2 years agoprivoxy-log-parser.pl: Make gather_loglevel_clf_stats() more tolerant
Fabian Keil [Tue, 9 Jun 2020 07:26:38 +0000 (09:26 +0200)]
privoxy-log-parser.pl: Make gather_loglevel_clf_stats() more tolerant

While at it, count all CLF messages as requests,
even if the request is invalid.

2 years agoprivoxy-log-parser.pl: Highlight: "Waiting for the next client connection. Currently...
Fabian Keil [Tue, 9 Jun 2020 06:26:29 +0000 (08:26 +0200)]
privoxy-log-parser.pl: Highlight: "Waiting for the next client connection. Currently active threads: 30"

2 years agoAdd a couple of tests for +client-header-filter{no-brotli-accepted}
Fabian Keil [Mon, 8 Jun 2020 16:49:50 +0000 (18:49 +0200)]
Add a couple of tests for +client-header-filter{no-brotli-accepted}

2 years agoRegister dependencies of the ssl object file so it is rebuild when needed
Fabian Keil [Mon, 8 Jun 2020 09:38:43 +0000 (11:38 +0200)]
Register dependencies of the ssl object file so it is rebuild when needed

2 years agoget_clf_timestamp(): Fix locking of localtime()
Fabian Keil [Sun, 7 Jun 2020 17:24:00 +0000 (19:24 +0200)]
get_clf_timestamp(): Fix locking of localtime()

Previously we were only locking the actual localtime()
call while we should keep the lock until the returned
pointer is no longer being used.

2 years agoget_locale_time(): Fix locking of localtime()
Fabian Keil [Sun, 7 Jun 2020 17:23:30 +0000 (19:23 +0200)]
get_locale_time(): Fix locking of localtime()

Previously we were only locking the actual localtime()
call while we should keep the lock until the returned
pointer is no longer being used.

2 years agoget_clf_timestamp(): Use privoxy_gmtime_r()
Fabian Keil [Sun, 7 Jun 2020 17:22:10 +0000 (19:22 +0200)]
get_clf_timestamp(): Use privoxy_gmtime_r()

2 years agoBump copyright
Fabian Keil [Sun, 7 Jun 2020 17:12:59 +0000 (19:12 +0200)]
Bump copyright

2 years agoparse_header_time(): Use privoxy_gmtime_r()
Fabian Keil [Sun, 7 Jun 2020 15:57:40 +0000 (17:57 +0200)]
parse_header_time(): Use privoxy_gmtime_r()

Previously the function would use gmtime() unlocked
if FEATURE_STRPTIME_SANITY_CHECKS was enabled ...

2 years agoclient_if_modified_since(): Use privoxy_gmtime_r()
Fabian Keil [Sun, 7 Jun 2020 15:52:38 +0000 (17:52 +0200)]
client_if_modified_since(): Use privoxy_gmtime_r()

2 years agoserver_last_modified(): Use privoxy_gmtime_r()
Fabian Keil [Sun, 7 Jun 2020 15:51:31 +0000 (17:51 +0200)]
server_last_modified(): Use privoxy_gmtime_r()

2 years agoadd_cookie_expiry_date(): Use privoxy_gmtime_r()
Fabian Keil [Sun, 7 Jun 2020 15:50:23 +0000 (17:50 +0200)]
add_cookie_expiry_date(): Use privoxy_gmtime_r()

2 years agogenerate_certificate_valid_date(): Use privoxy_gmtime_r()
Fabian Keil [Sun, 7 Jun 2020 15:48:52 +0000 (17:48 +0200)]
generate_certificate_valid_date(): Use privoxy_gmtime_r()

2 years agoAdd privoxy_gmtime_r() so we can simplify some code
Fabian Keil [Sun, 7 Jun 2020 15:47:26 +0000 (17:47 +0200)]
Add privoxy_gmtime_r() so we can simplify some code

2 years agowrite_pid_file(): Rename pidfile to pid_file
Fabian Keil [Sun, 7 Jun 2020 15:42:00 +0000 (17:42 +0200)]
write_pid_file(): Rename pidfile to pid_file

So it doesn't shadow the global pidfile.

2 years agoFix the locking of gmtime()
Fabian Keil [Sun, 7 Jun 2020 15:21:16 +0000 (17:21 +0200)]
Fix the locking of gmtime()

Previously we were only locking the actual gmtime()
call while we should keep the lock until the returned
pointer is no longer being used.

2 years agogenerate_certificate_valid_date(): Fall back to using gmtime() if gmtime_r() isn...
Fabian Keil [Sun, 7 Jun 2020 14:56:05 +0000 (16:56 +0200)]
generate_certificate_valid_date(): Fall back to using gmtime() if gmtime_r() isn't available

As Lee reported it's not available on Windows.

2 years agoserver(): Add colons that were missing in a log message
Fabian Keil [Sun, 7 Jun 2020 12:59:28 +0000 (14:59 +0200)]
server(): Add colons that were missing in a log message

2 years agoprivoxy-log-parser.pl: Properly highlight the filter results message
Fabian Keil [Sat, 6 Jun 2020 15:47:58 +0000 (17:47 +0200)]
privoxy-log-parser.pl: Properly highlight the filter results message

Previously a brace got lost.

2 years agoprivoxy-regression-test.pl: Consistently use no space after function names
Fabian Keil [Sun, 7 Jun 2020 09:41:48 +0000 (11:41 +0200)]
privoxy-regression-test.pl: Consistently use no space after function names

2 years agoLog the "Request:" message for unencrypted requests later
Fabian Keil [Sun, 7 Jun 2020 07:53:36 +0000 (09:53 +0200)]
Log the "Request:" message for unencrypted requests later

In b94bbe62a I moved the block in front of the setting
of csp->http->client_ssl which meant the message was emitted
for encrypted requests as well.

This resulted in two "Request:" message instead of one.

Sponsored by: Robert Klemme