11 years agoIn get_log_timestamp(), use the ISO 8601 date format %Y-%m-%d.
Fabian Keil [Sat, 25 Jun 2011 12:39:18 +0000 (12:39 +0000)]
In get_log_timestamp(), use the ISO 8601 date format %Y-%m-%d.

It's only slightly longer than the old format, but contains
the full date including the year and allows sorting by date
(when grepping in multiple log files) without hassle.

11 years agoLet the msn filter hide elements with the id 's_notf_div'.
Fabian Keil [Thu, 23 Jun 2011 14:04:29 +0000 (14:04 +0000)]
Let the msn filter hide elements with the id 's_notf_div'.

They only seem to be used to advertise site 'enhancements'.

11 years agoDisable the range-requests tagger for tests that break if it's enabled
Fabian Keil [Thu, 23 Jun 2011 14:03:38 +0000 (14:03 +0000)]
Disable the range-requests tagger for tests that break if it's enabled

11 years agoDelimit the date in log messages with dashes instead of slashes
Fabian Keil [Thu, 23 Jun 2011 14:02:53 +0000 (14:02 +0000)]
Delimit the date in log messages with dashes instead of slashes

11 years agoAccept and highlight: Added header: Content-Encoding: deflate
Fabian Keil [Thu, 23 Jun 2011 14:02:28 +0000 (14:02 +0000)]
Accept and highlight: Added header: Content-Encoding: deflate

11 years agoAccept and highlight: Compressed content from 29258 to 8630 bytes.
Fabian Keil [Thu, 23 Jun 2011 14:02:02 +0000 (14:02 +0000)]
Accept and highlight: Compressed content from 29258 to 8630 bytes.

11 years agoShow FEATURE_COMPRESSION on the show-status page
Fabian Keil [Thu, 23 Jun 2011 14:01:39 +0000 (14:01 +0000)]
Show FEATURE_COMPRESSION on the show-status page

11 years agoAdd support for (re-)compression of buffered content and CGI responses.
Fabian Keil [Thu, 23 Jun 2011 14:01:01 +0000 (14:01 +0000)]
Add support for (re-)compression of buffered content and CGI responses.

For now it has to be explicitly enabled with the configure option --enable-compression.

11 years agoAdd a fast-redirects exception for '*=cache'
Fabian Keil [Thu, 23 Jun 2011 13:59:56 +0000 (13:59 +0000)]
Add a fast-redirects exception for '*=cache'

11 years agoLet the yahoo filter hide '.ads'
Fabian Keil [Thu, 23 Jun 2011 13:58:53 +0000 (13:58 +0000)]
Let the yahoo filter hide '.ads'

11 years agoRemove a useless check in write_socket()
Fabian Keil [Thu, 23 Jun 2011 13:58:22 +0000 (13:58 +0000)]
Remove a useless check in write_socket()

11 years agoIn decompress_iob() change a buffer limit check from '==' to the '>=' one would expec...
Fabian Keil [Thu, 23 Jun 2011 13:57:47 +0000 (13:57 +0000)]
In decompress_iob() change a buffer limit check from '==' to the '>=' one would expect at first glance.

At the same time explain why we don't really have to.

11 years agoLet the msn filter hide overlay ads for Facebook 'likes' in search results.
Fabian Keil [Sun, 19 Jun 2011 12:17:56 +0000 (12:17 +0000)]
Let the msn filter hide overlay ads for Facebook 'likes' in search results.

11 years agoRemove two more checks that have been commented out for years
Fabian Keil [Fri, 27 May 2011 11:37:57 +0000 (11:37 +0000)]
Remove two more checks that have been commented out for years

11 years agoDo not check for the existence of strerror() and memmove() twice
Fabian Keil [Fri, 27 May 2011 11:37:45 +0000 (11:37 +0000)]
Do not check for the existence of strerror() and memmove() twice

11 years agoDitch two checks that have been commented out for years already, without causing...
Fabian Keil [Fri, 27 May 2011 11:36:36 +0000 (11:36 +0000)]
Ditch two checks that have been commented out for years already, without causing any issues

11 years agoRemove AC_FUNC_SETPGRP as it can cause issues when cross-compiling
Fabian Keil [Fri, 27 May 2011 11:36:15 +0000 (11:36 +0000)]
Remove AC_FUNC_SETPGRP as it can cause issues when cross-compiling

I considered only skipping it when cross-compiling, but given
that Privoxy doesn't use setpgrp(2), why should we care about
its prototype?

There's no justification for the check in the revision log
either, except that it was part of "Al's patch".

11 years agoRemove a useless '+' in main().
Fabian Keil [Fri, 27 May 2011 11:34:39 +0000 (11:34 +0000)]
Remove a useless '+' in main().

11 years agoIn LogPutString(), don't bother looking at pszText when not actually logging anything
Fabian Keil [Fri, 27 May 2011 11:34:16 +0000 (11:34 +0000)]
In LogPutString(), don't bother looking at pszText when not actually logging anything

11 years agoRemove -prevent-compression from the fragile alias
Fabian Keil [Sun, 22 May 2011 10:31:29 +0000 (10:31 +0000)]
Remove -prevent-compression from the fragile alias

We no longer use +prevent-compresssion anywhere by
default and it isn't known to break stuff anyway.

11 years agoGarbage collect the strdup() replacement for mingw32
Fabian Keil [Sun, 22 May 2011 10:30:55 +0000 (10:30 +0000)]
Garbage collect the strdup() replacement for mingw32

Supposedly it was added ten years ago to paper over a mingw32
bug where the returned pointer couldn't be free'd, but I doubt
that the bug still exists assuming the problem was analyzed
correctly in the first place.

If it does, we should notice soon enough as I'd consider
free'ing pointers returned by strdup() a rather common

11 years agoGarbage collect safe_strerror() which isn't used anywhere
Fabian Keil [Sun, 22 May 2011 10:26:45 +0000 (10:26 +0000)]
Garbage collect safe_strerror() which isn't used anywhere

11 years agoIf only one of the strncmpic() arguments has a length the compiler can figure out...
Fabian Keil [Sun, 22 May 2011 10:25:26 +0000 (10:25 +0000)]
If only one of the strncmpic() arguments has a length the compiler can figure out, move it to the second place

This will allow to use a macro to figure out the length later on.

11 years agoChange a ssplit() call to use SZ(array) as the third parameter instead of the hardcoded 3
Fabian Keil [Sun, 22 May 2011 10:21:54 +0000 (10:21 +0000)]
Change a ssplit() call to use SZ(array) as the third parameter instead of the hardcoded 3

Silences a clang complaint now that the ssplit() prototype has been fixed.

11 years agoChange ssplit()'s fourth parameter from int to the proper size_t
Fabian Keil [Sun, 22 May 2011 10:20:05 +0000 (10:20 +0000)]
Change ssplit()'s fourth parameter from int to the proper size_t

As pointed out by clang, size_t's don't necessarily have the
same width as int's and while I'm not aware of any actual
issues caused by this (here), it doesn't hurt to use the right
type anyway.

11 years agoMention some of the fun one can experience when not explicitly configuring a IP addre...
Fabian Keil [Sun, 15 May 2011 10:49:33 +0000 (10:49 +0000)]
Mention some of the fun one can experience when not explicitly configuring a IP addresses to listen to.

11 years agoImprove the listen-address documentation
Fabian Keil [Sun, 15 May 2011 10:48:58 +0000 (10:48 +0000)]
Improve the listen-address documentation

Explicitly mention that hostnames can be used instead of
IP addresses, that only the first address returned will
be used and what happens if the address is invalid.

Requested by Cálestyo in #3302213.

11 years agoAdd a -fast-redirects exception for
Fabian Keil [Sun, 8 May 2011 13:31:05 +0000 (13:31 +0000)]
Add a -fast-redirects exception for

11 years agoFix white-space.
Fabian Keil [Sun, 8 May 2011 13:30:17 +0000 (13:30 +0000)]
Fix white-space.

11 years agoUse a more traditional for loop to iterate over the tests in execute_regression_tests()
Fabian Keil [Sun, 8 May 2011 13:29:59 +0000 (13:29 +0000)]
Use a more traditional for loop to iterate over the tests in execute_regression_tests()

While it doesn't really matter for the number of tests we have,
there's no reason to keep all the test numbers in memory.

11 years agoReduce empty lines in init_our_variables().
Fabian Keil [Sun, 8 May 2011 13:28:13 +0000 (13:28 +0000)]
Reduce empty lines in init_our_variables().

11 years agoSimplify check_header_result() a bit.
Fabian Keil [Sun, 8 May 2011 13:27:53 +0000 (13:27 +0000)]
Simplify check_header_result() a bit.

11 years agoFix spelling in two error messages.
Fabian Keil [Sun, 8 May 2011 13:27:10 +0000 (13:27 +0000)]
Fix spelling in two error messages.

11 years agoAdd a warning that the statistics currently can't be trusted.
Fabian Keil [Sun, 8 May 2011 13:26:24 +0000 (13:26 +0000)]
Add a warning that the statistics currently can't be trusted.

Mention Privoxy-Log-Parser's --statistics option as
an alternative for the time being.

11 years agoAdd: 92) The statistics currently aren't calculated correctly by Privoxy
Fabian Keil [Sun, 8 May 2011 13:25:14 +0000 (13:25 +0000)]
Add: 92) The statistics currently aren't calculated correctly by Privoxy

11 years agoDo not expect a trailing dot in: Request from marked for blocking. limit...
Fabian Keil [Tue, 3 May 2011 10:33:53 +0000 (10:33 +0000)]
Do not expect a trailing dot in: Request from marked for blocking. limit-connect{0} doesn't allow CONNECT requests to

I intended to add one, but decided to go with the submitted version.

11 years agoHighlight the hostport in: Request from marked for blocking. limit-connect...
Fabian Keil [Tue, 3 May 2011 10:19:20 +0000 (10:19 +0000)]
Highlight the hostport in: Request from marked for blocking. limit-connect{0} doesn't allow CONNECT requests to

11 years agoInclude the destination host in the 'Request ... marked for blocking. limit-connect...
Fabian Keil [Tue, 3 May 2011 10:15:54 +0000 (10:15 +0000)]
Include the destination host in the 'Request ... marked for blocking. limit-connect{...} doesn't allow CONNECT ...' message

Patch submitted by Saperski in #3296250.

11 years agoPoint out that the SourceForge messaging system works like a blackhole and should...
Fabian Keil [Tue, 3 May 2011 10:13:21 +0000 (10:13 +0000)]
Point out that the SourceForge messaging system works like a blackhole and should thus not be used

11 years agoIn unbreak_lines_only_loop(), accept ISO 8601 time stamps, too
Fabian Keil [Tue, 3 May 2011 10:12:23 +0000 (10:12 +0000)]
In unbreak_lines_only_loop(), accept ISO 8601 time stamps, too

11 years agoIn rfc2553_connect_to(), prevent a duplicated log message if none of the resolved...
Fabian Keil [Tue, 3 May 2011 10:11:24 +0000 (10:11 +0000)]
In rfc2553_connect_to(), prevent a duplicated log message if none of the resolved IP addresses were connectable

11 years agoPrevent a NULL-pointer dereference in connect_to()
Fabian Keil [Tue, 3 May 2011 09:55:35 +0000 (09:55 +0000)]
Prevent a NULL-pointer dereference in connect_to()

It happened in case of address resolution failures when
there was no forwarding proxy enabled for the request in
the config file and forward-override{} wasn't used at all.

Regression introduced in v1.98 by yours truly.

Patch submitted by saperski in #3296527.

11 years agoIn connect_to(), do not pretent to retry if forwarded-connect-retries is zero or...
Fabian Keil [Wed, 27 Apr 2011 18:11:05 +0000 (18:11 +0000)]
In connect_to(), do not pretent to retry if forwarded-connect-retries is zero or unset.

11 years agoSplit the --user delimiter skipping across two lines and add comments.
Fabian Keil [Tue, 26 Apr 2011 16:55:08 +0000 (16:55 +0000)]
Split the --user delimiter skipping across two lines and add comments.

11 years agoMake a copy of the --user value and only mess with that when splitting user and group.
Fabian Keil [Tue, 26 Apr 2011 16:53:21 +0000 (16:53 +0000)]
Make a copy of the --user value and only mess with that when splitting user and group.

On some operating systems modifying the value directly
is reflected in the output of ps and friends and can
be misleading.

While at it, use a pointer name that gives a hint
what the pointer is actually supposed to point to.

Fixes #3292710 reported by zepard.

11 years agoRemove a harmless but pointless line in the code to handle the --user argument.
Fabian Keil [Tue, 26 Apr 2011 16:50:11 +0000 (16:50 +0000)]
Remove a harmless but pointless line in the code to handle the --user argument.

If p is not NULL, --p already has been set to '\0' previously
and it hadn't, it would be too late now as we are done with p.

11 years agoWhen a specified user or group can't be found, put the name in single-quotes when...
Fabian Keil [Tue, 26 Apr 2011 16:48:56 +0000 (16:48 +0000)]
When a specified user or group can't be found, put the name in single-quotes when logging it.

11 years agoIf the --user argument user[.group] contains a dot, always bail out if no group has...
Fabian Keil [Tue, 26 Apr 2011 16:48:04 +0000 (16:48 +0000)]
If the --user argument user[.group] contains a dot, always bail out if no group has been specified.

Previously the intended, but undocumented, behaviour was to
try interpreting the whole argument as user name, but the
detection was flawed and checked for '0' isntead of '\0',
thus merely preventing group names beginning with a zero.

Remove the incorrect check instead of fixing it to get
the documented behaviour.

11 years agoMerge a typo fix.
Fabian Keil [Tue, 19 Apr 2011 13:18:46 +0000 (13:18 +0000)]
Merge a typo fix.

11 years agoFix spelling errors in the documentation. Found with codespell.
Fabian Keil [Tue, 19 Apr 2011 13:14:10 +0000 (13:14 +0000)]
Fix spelling errors in the documentation. Found with codespell.

11 years agoFix spelling errors found with codespell.
Fabian Keil [Tue, 19 Apr 2011 13:10:11 +0000 (13:10 +0000)]
Fix spelling errors found with codespell.

11 years agoFix a perldoc syntax error.
Fabian Keil [Tue, 19 Apr 2011 13:08:51 +0000 (13:08 +0000)]
Fix a perldoc syntax error.

11 years agoFix various spelling errors in the comments.
Fabian Keil [Tue, 19 Apr 2011 13:00:47 +0000 (13:00 +0000)]
Fix various spelling errors in the comments.

Found with codespell.

11 years agoAdd a --disable-ipv6-support switch for platforms where support is detected but doesn...
Fabian Keil [Tue, 19 Apr 2011 11:42:51 +0000 (11:42 +0000)]
Add a --disable-ipv6-support switch for platforms where support is detected but doesn't actually work.

11 years agoRename the --disable-acl-files switch to --disable-acl-support
Fabian Keil [Tue, 19 Apr 2011 11:42:12 +0000 (11:42 +0000)]
Rename the --disable-acl-files switch to --disable-acl-support

Since about 2001, ACL directives are specified in the standard config file.

11 years agoClarify what kind of directory layout #67 is talking about.
Fabian Keil [Sat, 16 Apr 2011 17:31:35 +0000 (17:31 +0000)]
Clarify what kind of directory layout #67 is talking about.

11 years agoMention #41 in #65
Fabian Keil [Sat, 16 Apr 2011 17:31:24 +0000 (17:31 +0000)]
Mention #41 in #65

11 years agoIn #42, note that the DTrace bible is preordered.
Fabian Keil [Sat, 16 Apr 2011 17:31:11 +0000 (17:31 +0000)]
In #42, note that the DTrace bible is preordered.

11 years agoRephrase #40 which could be easily misunderstood.
Fabian Keil [Sat, 16 Apr 2011 17:30:36 +0000 (17:30 +0000)]
Rephrase #40 which could be easily misunderstood.

11 years agoRemove #39. jarfile support got garbage collected before the 3.0.12 release.
Fabian Keil [Sat, 16 Apr 2011 17:30:23 +0000 (17:30 +0000)]
Remove #39. jarfile support got garbage collected before the 3.0.12 release.

11 years agoRemove #35. The accept_connection() thread does little enough now, I think.
Fabian Keil [Sat, 16 Apr 2011 17:29:38 +0000 (17:29 +0000)]
Remove #35. The accept_connection() thread does little enough now, I think.

11 years agoShorten #14 by removing the logging part.
Fabian Keil [Sat, 16 Apr 2011 17:29:24 +0000 (17:29 +0000)]
Shorten #14 by removing the logging part.

11 years agoRemove #81. The unlimited-config-lines branch has been merged a while ago.
Fabian Keil [Sat, 16 Apr 2011 17:29:12 +0000 (17:29 +0000)]
Remove #81. The unlimited-config-lines branch has been merged a while ago.

11 years agoAdd #91: Add an optional limit for internal redirects.
Fabian Keil [Sat, 16 Apr 2011 17:28:58 +0000 (17:28 +0000)]
Add #91: Add an optional limit for internal redirects.

11 years agoMention why the static PCRE code is actually deprecated.
Fabian Keil [Sat, 16 Apr 2011 17:28:15 +0000 (17:28 +0000)]
Mention why the static PCRE code is actually deprecated.

The URL to the mailing list posting is likely
to get messed up again in the future.

11 years agoUpdate the URL of the 'Removing outdated PCRE version after the next stable release...
Fabian Keil [Sat, 16 Apr 2011 17:27:40 +0000 (17:27 +0000)]
Update the URL of the 'Removing outdated PCRE version after the next stable release' posting.

The old URL stopped working after one of SF's recent layout pessimizations.
Reported by Han Liu.

11 years agoRemove an obsolete paragraph in the forwarded-connect-retries section
Fabian Keil [Sun, 27 Mar 2011 14:14:13 +0000 (14:14 +0000)]
Remove an obsolete paragraph in the forwarded-connect-retries section

The bug that forwarded-connect-retries covered direct connections, too,
has just been fixed (I hope), so there's no need to document it any longer.

11 years agoIf forwarded-connect-retries is set, only retry if the we are actually forwarding...
Fabian Keil [Sun, 27 Mar 2011 14:08:35 +0000 (14:08 +0000)]
If forwarded-connect-retries is set, only retry if the we are actually forwarding the request.

11 years agoFix a theoretical memory leak in a cannot-realistically-happen situation in rfc2553_c...
Fabian Keil [Sun, 27 Mar 2011 14:04:10 +0000 (14:04 +0000)]
Fix a theoretical memory leak in a cannot-realistically-happen situation in rfc2553_connect_to().

11 years agoIn rfc2553_connect_to(), initialize socket_error to 0
Fabian Keil [Sun, 27 Mar 2011 14:03:43 +0000 (14:03 +0000)]
In rfc2553_connect_to(), initialize socket_error to 0

There are a couple of fringe situations where it isn't properly set yet.

11 years agoMark the errno overloading in connect_to() as questionable, too
Fabian Keil [Sun, 27 Mar 2011 14:03:25 +0000 (14:03 +0000)]
Mark the errno overloading in connect_to() as questionable, too

11 years agoZero out the timeval struct in rfc2553_connect_to() completely and rename it to timeout
Fabian Keil [Sun, 27 Mar 2011 14:02:53 +0000 (14:02 +0000)]
Zero out the timeval struct in rfc2553_connect_to() completely and rename it to timeout

It's not used for anything else so there's not need for a generic name.
While at it, use a struct instead of an array of a single struct.

11 years agoRemove useless parentheses in get_destination_from_headers()
Fabian Keil [Sun, 27 Mar 2011 14:01:46 +0000 (14:01 +0000)]
Remove useless parentheses in get_destination_from_headers()

11 years agoFactor the Content-Encoding header ditching out of server_content_encoding() into...
Fabian Keil [Sun, 27 Mar 2011 14:01:18 +0000 (14:01 +0000)]
Factor the Content-Encoding header ditching out of server_content_encoding() into server_adjust_content_encoding()

11 years agoIn socks4_connect(), don't comment on connect_to() failures.
Fabian Keil [Sun, 27 Mar 2011 14:00:36 +0000 (14:00 +0000)]
In socks4_connect(), don't comment on connect_to() failures.

The failures are dealt with when they happen now.

11 years agoIn rfc2553_connect_to(), explain getnameinfo() errors differently.
Fabian Keil [Sun, 27 Mar 2011 13:58:33 +0000 (13:58 +0000)]
In rfc2553_connect_to(), explain getnameinfo() errors differently.

11 years agoRemove a useless log message in chat()
Fabian Keil [Sun, 27 Mar 2011 13:58:09 +0000 (13:58 +0000)]
Remove a useless log message in chat()

The fact that the connection attempt failed already has been logged
and a reason given earlier on. Also %E can't be used here anyway,
as errno will no longer contain the cause of the problem.

11 years agoBump copyright year
Fabian Keil [Sun, 27 Mar 2011 13:57:41 +0000 (13:57 +0000)]
Bump copyright year

11 years agoIn rfc2553_connect_to() and no_rfc2553_connect_to(), factor the socket() call out...
Fabian Keil [Sun, 27 Mar 2011 13:57:28 +0000 (13:57 +0000)]
In rfc2553_connect_to() and no_rfc2553_connect_to(), factor the socket() call out of the #ifdef _WIN32 branch.

11 years agoIn rfc2553_connect_to(), simplify the OS/2 code path and pray that it still works
Fabian Keil [Sun, 27 Mar 2011 13:57:08 +0000 (13:57 +0000)]
In rfc2553_connect_to(), simplify the OS/2 code path and pray that it still works

11 years agoDon't leak csp->http->host_ip_addr_str when calling rfc2553_connect_to() multiple...
Fabian Keil [Sun, 27 Mar 2011 13:56:48 +0000 (13:56 +0000)]
Don't leak csp->http->host_ip_addr_str when calling rfc2553_connect_to() multiple times.

11 years agoDon't leak csp->http->host_ip_addr_str when calling no_rfc2553_connect_to() multiple...
Fabian Keil [Sun, 27 Mar 2011 13:56:27 +0000 (13:56 +0000)]
Don't leak csp->http->host_ip_addr_str when calling no_rfc2553_connect_to() multiple times.

11 years agoIn rfc2553_connect_to(), start setting cgi->error_message on error
Fabian Keil [Sun, 27 Mar 2011 13:55:55 +0000 (13:55 +0000)]
In rfc2553_connect_to(), start setting cgi->error_message on error

11 years agoIn rfc2553_connect_to(), rename socket_in_error to socket_error
Fabian Keil [Sun, 27 Mar 2011 13:55:09 +0000 (13:55 +0000)]
In rfc2553_connect_to(), rename socket_in_error to socket_error

11 years agoIn the IPv6-aware connect_to(), allocate http->host_ip_addr_str outside the loop...
Fabian Keil [Sun, 27 Mar 2011 13:54:52 +0000 (13:54 +0000)]
In the IPv6-aware connect_to(), allocate http->host_ip_addr_str outside the loop and reuse the buffer in case of errors

I think this also fixes an unlikely memory leak, but I haven't actually verified it.

11 years agoIn rfc2553_connect_to(), remove a useless check for NULL
Fabian Keil [Sun, 27 Mar 2011 13:53:49 +0000 (13:53 +0000)]
In rfc2553_connect_to(), remove a useless check for NULL

11 years agoRemove a useless comment in rfc2553_connect_to().
Fabian Keil [Sun, 27 Mar 2011 13:53:25 +0000 (13:53 +0000)]
Remove a useless comment in rfc2553_connect_to().

connect(2) is neither Linux nor GNU libc specific
and we don't advertise other man pages either.

11 years agoWhen retrying to connect, also log the maximum number of connection attempts
Fabian Keil [Sun, 27 Mar 2011 13:53:04 +0000 (13:53 +0000)]
When retrying to connect, also log the maximum number of connection attempts

11 years agoMove the forwarded-connect-retries handling into a shiny new connect_to()
Fabian Keil [Sun, 27 Mar 2011 13:52:23 +0000 (13:52 +0000)]
Move the forwarded-connect-retries handling into a shiny new connect_to()

In the process, give the two former connect_to() versions different names.

11 years agoRemove an incorrect comment about csp not being modified by connect_to(). It's been...
Fabian Keil [Sun, 27 Mar 2011 13:51:04 +0000 (13:51 +0000)]
Remove an incorrect comment about csp not being modified by connect_to(). It's been wrong since years ago.

11 years agoBump Copyright range.
Fabian Keil [Sun, 27 Mar 2011 13:50:38 +0000 (13:50 +0000)]
Bump Copyright range.

11 years agoPolish syntax to drop the GNU make dependency for the build target.
Fabian Keil [Sun, 27 Mar 2011 13:50:15 +0000 (13:50 +0000)]
Polish syntax to drop the GNU make dependency for the build target.

11 years agoAdd 90) Implement NO-TAG: patterns
Fabian Keil [Sun, 27 Mar 2011 13:49:16 +0000 (13:49 +0000)]
Add 90) Implement NO-TAG: patterns

11 years agoAccept and ignore: SDCH-compressed content detected, content filtering disabled....
Fabian Keil [Sun, 20 Mar 2011 11:51:12 +0000 (11:51 +0000)]
Accept and ignore: SDCH-compressed content detected, content filtering disabled. Consider suppressing SDCH offers made by the client.

11 years agoIn server_content_encoding(), mark the content as taboo for filtering if SDCH compres...
Fabian Keil [Sun, 20 Mar 2011 11:50:28 +0000 (11:50 +0000)]
In server_content_encoding(), mark the content as taboo for filtering if SDCH compression is used

If SDCH was combined with a supported compression algorithm,
we'd previously try to decompress it, when successful apply
the enabled filters and ditch the Content-Encoding header
even though the SDCH compression wasn't removed.

Reported by zebul666 in #3225863.

I get the impression that filtering SDCH-compressed content
actually isn't guaranteed to cause problems as long as the
client still gets a "Content-Encoding: sdch" header, so we
should probably eventually allow users who want to risk it
to do so by explicitly enforcing filtering.

While at it, mark a bunch of other, partly-related, problems
in server_content_encoding() that should be addressed someday.

11 years agoBump generated Firefox version to 3.6.15.
Fabian Keil [Tue, 8 Mar 2011 18:43:46 +0000 (18:43 +0000)]
Bump generated Firefox version to 3.6.15.

11 years agoChange the expected status code returned for http://p.p/die depending on whether...
Fabian Keil [Tue, 8 Mar 2011 18:33:28 +0000 (18:33 +0000)]
Change the expected status code returned for p.p/die depending on whether or not FEATURE_GRACEFUL_TERMINATION is available

11 years agoUnblock and
Fabian Keil [Tue, 8 Mar 2011 18:32:48 +0000 (18:32 +0000)]
Unblock and

Reported on ijbswa-users@, no name exlicitly mentioned.
Message-ID: <>

11 years agoRephrase a log message in compile_dynamic_pcrs_job_list()
Fabian Keil [Tue, 8 Mar 2011 18:32:11 +0000 (18:32 +0000)]
Rephrase a log message in compile_dynamic_pcrs_job_list()

Devide the error code and its meaning with a colon.

Call the pcrs job dynamic and not the filter. Filters may
contain dynamic and non-dynamic pcrs jobs at the same time.
Only mention the name of the filter or tagger, but don't
claim it's a filter when it could be a tagger.

11 years agoIn a fatal error message in load_one_actions_file(), cover both URL and TAG patterns
Fabian Keil [Tue, 8 Mar 2011 18:30:46 +0000 (18:30 +0000)]
In a fatal error message in load_one_actions_file(), cover both URL and TAG patterns