privoxy.git
13 years agoShorten #14 by removing the logging part.
Fabian Keil [Sat, 16 Apr 2011 17:29:24 +0000 (17:29 +0000)]
Shorten #14 by removing the logging part.

13 years agoRemove #81. The unlimited-config-lines branch has been merged a while ago.
Fabian Keil [Sat, 16 Apr 2011 17:29:12 +0000 (17:29 +0000)]
Remove #81. The unlimited-config-lines branch has been merged a while ago.

13 years agoAdd #91: Add an optional limit for internal redirects.
Fabian Keil [Sat, 16 Apr 2011 17:28:58 +0000 (17:28 +0000)]
Add #91: Add an optional limit for internal redirects.

13 years agoMention why the static PCRE code is actually deprecated.
Fabian Keil [Sat, 16 Apr 2011 17:28:15 +0000 (17:28 +0000)]
Mention why the static PCRE code is actually deprecated.

The URL to the mailing list posting is likely
to get messed up again in the future.

13 years agoUpdate the URL of the 'Removing outdated PCRE version after the next stable release...
Fabian Keil [Sat, 16 Apr 2011 17:27:40 +0000 (17:27 +0000)]
Update the URL of the 'Removing outdated PCRE version after the next stable release' posting.

The old URL stopped working after one of SF's recent layout pessimizations.
Reported by Han Liu.

13 years agoRemove an obsolete paragraph in the forwarded-connect-retries section
Fabian Keil [Sun, 27 Mar 2011 14:14:13 +0000 (14:14 +0000)]
Remove an obsolete paragraph in the forwarded-connect-retries section

The bug that forwarded-connect-retries covered direct connections, too,
has just been fixed (I hope), so there's no need to document it any longer.

13 years agoIf forwarded-connect-retries is set, only retry if the we are actually forwarding...
Fabian Keil [Sun, 27 Mar 2011 14:08:35 +0000 (14:08 +0000)]
If forwarded-connect-retries is set, only retry if the we are actually forwarding the request.

13 years agoFix a theoretical memory leak in a cannot-realistically-happen situation in rfc2553_c...
Fabian Keil [Sun, 27 Mar 2011 14:04:10 +0000 (14:04 +0000)]
Fix a theoretical memory leak in a cannot-realistically-happen situation in rfc2553_connect_to().

13 years agoIn rfc2553_connect_to(), initialize socket_error to 0
Fabian Keil [Sun, 27 Mar 2011 14:03:43 +0000 (14:03 +0000)]
In rfc2553_connect_to(), initialize socket_error to 0

There are a couple of fringe situations where it isn't properly set yet.

13 years agoMark the errno overloading in connect_to() as questionable, too
Fabian Keil [Sun, 27 Mar 2011 14:03:25 +0000 (14:03 +0000)]
Mark the errno overloading in connect_to() as questionable, too

13 years agoZero out the timeval struct in rfc2553_connect_to() completely and rename it to timeout
Fabian Keil [Sun, 27 Mar 2011 14:02:53 +0000 (14:02 +0000)]
Zero out the timeval struct in rfc2553_connect_to() completely and rename it to timeout

It's not used for anything else so there's not need for a generic name.
While at it, use a struct instead of an array of a single struct.

13 years agoRemove useless parentheses in get_destination_from_headers()
Fabian Keil [Sun, 27 Mar 2011 14:01:46 +0000 (14:01 +0000)]
Remove useless parentheses in get_destination_from_headers()

13 years agoFactor the Content-Encoding header ditching out of server_content_encoding() into...
Fabian Keil [Sun, 27 Mar 2011 14:01:18 +0000 (14:01 +0000)]
Factor the Content-Encoding header ditching out of server_content_encoding() into server_adjust_content_encoding()

13 years agoIn socks4_connect(), don't comment on connect_to() failures.
Fabian Keil [Sun, 27 Mar 2011 14:00:36 +0000 (14:00 +0000)]
In socks4_connect(), don't comment on connect_to() failures.

The failures are dealt with when they happen now.

13 years agoIn rfc2553_connect_to(), explain getnameinfo() errors differently.
Fabian Keil [Sun, 27 Mar 2011 13:58:33 +0000 (13:58 +0000)]
In rfc2553_connect_to(), explain getnameinfo() errors differently.

13 years agoRemove a useless log message in chat()
Fabian Keil [Sun, 27 Mar 2011 13:58:09 +0000 (13:58 +0000)]
Remove a useless log message in chat()

The fact that the connection attempt failed already has been logged
and a reason given earlier on. Also %E can't be used here anyway,
as errno will no longer contain the cause of the problem.

13 years agoBump copyright year
Fabian Keil [Sun, 27 Mar 2011 13:57:41 +0000 (13:57 +0000)]
Bump copyright year

13 years agoIn rfc2553_connect_to() and no_rfc2553_connect_to(), factor the socket() call out...
Fabian Keil [Sun, 27 Mar 2011 13:57:28 +0000 (13:57 +0000)]
In rfc2553_connect_to() and no_rfc2553_connect_to(), factor the socket() call out of the #ifdef _WIN32 branch.

13 years agoIn rfc2553_connect_to(), simplify the OS/2 code path and pray that it still works
Fabian Keil [Sun, 27 Mar 2011 13:57:08 +0000 (13:57 +0000)]
In rfc2553_connect_to(), simplify the OS/2 code path and pray that it still works

13 years agoDon't leak csp->http->host_ip_addr_str when calling rfc2553_connect_to() multiple...
Fabian Keil [Sun, 27 Mar 2011 13:56:48 +0000 (13:56 +0000)]
Don't leak csp->http->host_ip_addr_str when calling rfc2553_connect_to() multiple times.

13 years agoDon't leak csp->http->host_ip_addr_str when calling no_rfc2553_connect_to() multiple...
Fabian Keil [Sun, 27 Mar 2011 13:56:27 +0000 (13:56 +0000)]
Don't leak csp->http->host_ip_addr_str when calling no_rfc2553_connect_to() multiple times.

13 years agoIn rfc2553_connect_to(), start setting cgi->error_message on error
Fabian Keil [Sun, 27 Mar 2011 13:55:55 +0000 (13:55 +0000)]
In rfc2553_connect_to(), start setting cgi->error_message on error

13 years agoIn rfc2553_connect_to(), rename socket_in_error to socket_error
Fabian Keil [Sun, 27 Mar 2011 13:55:09 +0000 (13:55 +0000)]
In rfc2553_connect_to(), rename socket_in_error to socket_error

13 years agoIn the IPv6-aware connect_to(), allocate http->host_ip_addr_str outside the loop...
Fabian Keil [Sun, 27 Mar 2011 13:54:52 +0000 (13:54 +0000)]
In the IPv6-aware connect_to(), allocate http->host_ip_addr_str outside the loop and reuse the buffer in case of errors

I think this also fixes an unlikely memory leak, but I haven't actually verified it.

13 years agoIn rfc2553_connect_to(), remove a useless check for NULL
Fabian Keil [Sun, 27 Mar 2011 13:53:49 +0000 (13:53 +0000)]
In rfc2553_connect_to(), remove a useless check for NULL

13 years agoRemove a useless comment in rfc2553_connect_to().
Fabian Keil [Sun, 27 Mar 2011 13:53:25 +0000 (13:53 +0000)]
Remove a useless comment in rfc2553_connect_to().

connect(2) is neither Linux nor GNU libc specific
and we don't advertise other man pages either.

13 years agoWhen retrying to connect, also log the maximum number of connection attempts
Fabian Keil [Sun, 27 Mar 2011 13:53:04 +0000 (13:53 +0000)]
When retrying to connect, also log the maximum number of connection attempts

13 years agoMove the forwarded-connect-retries handling into a shiny new connect_to()
Fabian Keil [Sun, 27 Mar 2011 13:52:23 +0000 (13:52 +0000)]
Move the forwarded-connect-retries handling into a shiny new connect_to()

In the process, give the two former connect_to() versions different names.

13 years agoRemove an incorrect comment about csp not being modified by connect_to(). It's been...
Fabian Keil [Sun, 27 Mar 2011 13:51:04 +0000 (13:51 +0000)]
Remove an incorrect comment about csp not being modified by connect_to(). It's been wrong since years ago.

13 years agoBump Copyright range.
Fabian Keil [Sun, 27 Mar 2011 13:50:38 +0000 (13:50 +0000)]
Bump Copyright range.

13 years agoPolish syntax to drop the GNU make dependency for the build target.
Fabian Keil [Sun, 27 Mar 2011 13:50:15 +0000 (13:50 +0000)]
Polish syntax to drop the GNU make dependency for the build target.

13 years agoAdd 90) Implement NO-TAG: patterns
Fabian Keil [Sun, 27 Mar 2011 13:49:16 +0000 (13:49 +0000)]
Add 90) Implement NO-TAG: patterns

13 years agoAccept and ignore: SDCH-compressed content detected, content filtering disabled....
Fabian Keil [Sun, 20 Mar 2011 11:51:12 +0000 (11:51 +0000)]
Accept and ignore: SDCH-compressed content detected, content filtering disabled. Consider suppressing SDCH offers made by the client.

13 years agoIn server_content_encoding(), mark the content as taboo for filtering if SDCH compres...
Fabian Keil [Sun, 20 Mar 2011 11:50:28 +0000 (11:50 +0000)]
In server_content_encoding(), mark the content as taboo for filtering if SDCH compression is used

If SDCH was combined with a supported compression algorithm,
we'd previously try to decompress it, when successful apply
the enabled filters and ditch the Content-Encoding header
even though the SDCH compression wasn't removed.

Reported by zebul666 in #3225863.

I get the impression that filtering SDCH-compressed content
actually isn't guaranteed to cause problems as long as the
client still gets a "Content-Encoding: sdch" header, so we
should probably eventually allow users who want to risk it
to do so by explicitly enforcing filtering.

While at it, mark a bunch of other, partly-related, problems
in server_content_encoding() that should be addressed someday.

13 years agoBump generated Firefox version to 3.6.15.
Fabian Keil [Tue, 8 Mar 2011 18:43:46 +0000 (18:43 +0000)]
Bump generated Firefox version to 3.6.15.

13 years agoChange the expected status code returned for http://p.p/die depending on whether...
Fabian Keil [Tue, 8 Mar 2011 18:33:28 +0000 (18:33 +0000)]
Change the expected status code returned for p.p/die depending on whether or not FEATURE_GRACEFUL_TERMINATION is available

13 years agoUnblock http://adassier.wordpress.com/ and http://adassier.files.wordpress.com/
Fabian Keil [Tue, 8 Mar 2011 18:32:48 +0000 (18:32 +0000)]
Unblock adassier.wordpress.com/ and http://adassier.files.wordpress.com/

Reported on ijbswa-users@, no name exlicitly mentioned.
Message-ID: <ea-mime-4d758a87-4088-57d52b28@w-4.netcmail.com>

13 years agoRephrase a log message in compile_dynamic_pcrs_job_list()
Fabian Keil [Tue, 8 Mar 2011 18:32:11 +0000 (18:32 +0000)]
Rephrase a log message in compile_dynamic_pcrs_job_list()

Devide the error code and its meaning with a colon.

Call the pcrs job dynamic and not the filter. Filters may
contain dynamic and non-dynamic pcrs jobs at the same time.
Only mention the name of the filter or tagger, but don't
claim it's a filter when it could be a tagger.

13 years agoIn a fatal error message in load_one_actions_file(), cover both URL and TAG patterns
Fabian Keil [Tue, 8 Mar 2011 18:30:46 +0000 (18:30 +0000)]
In a fatal error message in load_one_actions_file(), cover both URL and TAG patterns

13 years agoIn pcrs_strerror(), properly report unknown positive error code values as unknown.
Fabian Keil [Thu, 3 Mar 2011 14:49:08 +0000 (14:49 +0000)]
In pcrs_strerror(), properly report unknown positive error code values as unknown.

Previously they were handled like 0 (no error).

13 years agoIn compile_dynamic_pcrs_job_list(), also log the actual error code as pcrs_strerror...
Fabian Keil [Thu, 3 Mar 2011 14:47:28 +0000 (14:47 +0000)]
In compile_dynamic_pcrs_job_list(), also log the actual error code as pcrs_strerror() doesn't handle all errors reported by pcre

13 years agoRemove an incorrect assertion in compile_dynamic_pcrs_job_list()
Fabian Keil [Thu, 3 Mar 2011 14:46:37 +0000 (14:46 +0000)]
Remove an incorrect assertion in compile_dynamic_pcrs_job_list()

It could be triggered by a pcrs job with an invalid pcre
pattern (for example one that contains a lone quantifier).

13 years agoDon't bother trying to continue chatting if the client didn't ask for it.
Fabian Keil [Thu, 3 Mar 2011 14:44:00 +0000 (14:44 +0000)]
Don't bother trying to continue chatting if the client didn't ask for it.

Reduces log noise a bit.

13 years agoIn cgi_die(), mark the client connection for closing.
Fabian Keil [Thu, 3 Mar 2011 14:42:55 +0000 (14:42 +0000)]
In cgi_die(), mark the client connection for closing.

If the client will fetch the style sheet through another connection
it gets the main thread out of the accept() state and should thus
trigger the actual shutdown.

13 years agoAdd a proper CGI message for cgi_die().
Fabian Keil [Thu, 3 Mar 2011 14:42:18 +0000 (14:42 +0000)]
Add a proper CGI message for cgi_die().

13 years agoFix an invalid free when compiled with FEATURE_GRACEFUL_TERMINATION and shut down...
Fabian Keil [Thu, 3 Mar 2011 14:41:29 +0000 (14:41 +0000)]
Fix an invalid free when compiled with FEATURE_GRACEFUL_TERMINATION and shut down through config.privoxy.org/die

13 years agoImprove a comment in load_one_actions_file()
Fabian Keil [Thu, 3 Mar 2011 14:39:57 +0000 (14:39 +0000)]
Improve a comment in load_one_actions_file()

13 years agoMake two fatal error message in load_one_actions_file() more descriptive
Fabian Keil [Thu, 3 Mar 2011 14:39:34 +0000 (14:39 +0000)]
Make two fatal error message in load_one_actions_file() more descriptive

13 years agoIn load_one_actions_file(), don't limit the actions_buf to BUFFER_SIZE bytes.
Fabian Keil [Thu, 3 Mar 2011 14:39:13 +0000 (14:39 +0000)]
In load_one_actions_file(), don't limit the actions_buf to BUFFER_SIZE bytes.

13 years agoDon't enforce a logical line length limit in read_config_line()
Fabian Keil [Thu, 3 Mar 2011 14:38:36 +0000 (14:38 +0000)]
Don't enforce a logical line length limit in read_config_line()

It means the caller has to free the buffer, but we can live with that.

13 years agoRemove duplicated 'the' in a comment
Fabian Keil [Thu, 3 Mar 2011 14:22:39 +0000 (14:22 +0000)]
Remove duplicated 'the' in a comment

13 years agoRemove duplicated 'the'
Fabian Keil [Thu, 3 Mar 2011 14:22:12 +0000 (14:22 +0000)]
Remove duplicated 'the'

13 years agoAdditionally accept ISO 8601 time stamps.
Fabian Keil [Sun, 20 Feb 2011 13:17:16 +0000 (13:17 +0000)]
Additionally accept ISO 8601 time stamps.

13 years agoBump copyright.
Fabian Keil [Sat, 19 Feb 2011 13:59:59 +0000 (13:59 +0000)]
Bump copyright.

13 years agoIn load_action_files(), don't check_for_forbidden_characters() if it has already...
Fabian Keil [Sat, 19 Feb 2011 13:59:40 +0000 (13:59 +0000)]
In load_action_files(), don't check_for_forbidden_characters() if it has already been done through enlist_new_test()

13 years agoIn the --help output, include a list of supported test types and their default levels.
Fabian Keil [Sat, 19 Feb 2011 13:59:20 +0000 (13:59 +0000)]
In the --help output, include a list of supported test types and their default levels.

13 years agoRephrase the descriptions of the forwarder_types SOCKS_4A and SOCKS_5
Fabian Keil [Sat, 19 Feb 2011 13:58:48 +0000 (13:58 +0000)]
Rephrase the descriptions of the forwarder_types SOCKS_4A and SOCKS_5

13 years agoUse an enum for the forwarder_type
Fabian Keil [Sat, 19 Feb 2011 13:56:55 +0000 (13:56 +0000)]
Use an enum for the forwarder_type

13 years agoUse an enum for the SOCKS4 reply field values
Fabian Keil [Sat, 19 Feb 2011 13:56:22 +0000 (13:56 +0000)]
Use an enum for the SOCKS4 reply field values

13 years agoRename then SOCKS4 defines from SOCKS_REQUEST_FOO to SOCKS4_REQUEST_FOO
Fabian Keil [Sat, 19 Feb 2011 13:55:57 +0000 (13:55 +0000)]
Rename then SOCKS4 defines from SOCKS_REQUEST_FOO to SOCKS4_REQUEST_FOO

They aren't used for SOCKS5.

13 years agoUse an enum for the SOCKS5 reply field
Fabian Keil [Sat, 19 Feb 2011 13:54:00 +0000 (13:54 +0000)]
Use an enum for the SOCKS5 reply field

13 years agoIn block_url(), consistently use the block reason "Request blocked by Privoxy"
Fabian Keil [Sat, 19 Feb 2011 13:53:14 +0000 (13:53 +0000)]
In block_url(), consistently use the block reason "Request blocked by Privoxy"

In two places the reason was "Request for blocked URL" which
hides the fact that the request got blocked by Privoxy and
isn't necessarly correct as the block may be due to tags.

13 years agoSlightly refactor server_last_modified() to remove useless gmtime*() calls
Fabian Keil [Mon, 14 Feb 2011 16:11:34 +0000 (16:11 +0000)]
Slightly refactor server_last_modified() to remove useless gmtime*() calls

13 years agoIn get_content_type(), also recognize '.jpeg' as JPEG extension
Fabian Keil [Mon, 14 Feb 2011 16:07:52 +0000 (16:07 +0000)]
In get_content_type(), also recognize '.jpeg' as JPEG extension

13 years agoAdd '.png' to the list of recognized file extenstions in get_content_type()
Fabian Keil [Mon, 14 Feb 2011 16:07:32 +0000 (16:07 +0000)]
Add '.png' to the list of recognized file extenstions in get_content_type()

13 years agoMore clean-ups for cgi_send_user_manual()
Fabian Keil [Mon, 14 Feb 2011 16:07:11 +0000 (16:07 +0000)]
More clean-ups for cgi_send_user_manual()

13 years agoFactor get_content_type() out of cgi_send_user_manual()
Fabian Keil [Mon, 14 Feb 2011 16:06:37 +0000 (16:06 +0000)]
Factor get_content_type() out of cgi_send_user_manual()

13 years agoIn cgi_send_user_manual(), log when rejecting a file name due to '/' or '..'
Fabian Keil [Mon, 14 Feb 2011 16:05:37 +0000 (16:05 +0000)]
In cgi_send_user_manual(), log when rejecting a file name due to '/' or '..'

While at it, improve a comment.

13 years agoSlightly clean up the filename handling in cgi_send_user_manual()
Fabian Keil [Mon, 14 Feb 2011 16:04:55 +0000 (16:04 +0000)]
Slightly clean up the filename handling in cgi_send_user_manual()

13 years agoIn load_file(), log a message if opening a file failed
Fabian Keil [Mon, 14 Feb 2011 16:03:53 +0000 (16:03 +0000)]
In load_file(), log a message if opening a file failed

The CGI error message alone isn't too helpful.

13 years agoIn connection_destination_matches(), improve two log messages to help understand...
Fabian Keil [Mon, 14 Feb 2011 16:03:03 +0000 (16:03 +0000)]
In connection_destination_matches(), improve two log messages to help understand why the destinations don't match

13 years agoIn load_one_actions_file(), use an enum for the mode.
Fabian Keil [Mon, 14 Feb 2011 16:01:20 +0000 (16:01 +0000)]
In load_one_actions_file(), use an enum for the mode.

13 years agoMove the site-specific block pattern section below the one for the generic patterns.
Fabian Keil [Thu, 10 Feb 2011 22:30:41 +0000 (22:30 +0000)]
Move the site-specific block pattern section below the one for the generic patterns.

For requests that are matched in both, showing the block
reason for the domain seems to be more useful than showing
the one for the generic pattern.

13 years agoBlock 'www91.intel.com/' which is used by Omniture.
Fabian Keil [Thu, 10 Feb 2011 22:26:17 +0000 (22:26 +0000)]
Block 'www91.intel.com/' which is used by Omniture.

Reported by Adam Piggott in #3167370.

13 years agoDisable the handle-as-empty-doc-returns-ok option and mark it as deprecated.
Fabian Keil [Thu, 10 Feb 2011 22:25:32 +0000 (22:25 +0000)]
Disable the handle-as-empty-doc-returns-ok option and mark it as deprecated.

While at it, move the "Notes" to the traditional location.

Reminded by tceverling in #2790091.

13 years agoAdd ".ivwbox.de/" to the "Cross-site user tracking" section.
Fabian Keil [Thu, 10 Feb 2011 22:21:16 +0000 (22:21 +0000)]
Add ".ivwbox.de/" to the "Cross-site user tracking" section.

Reported by Nettozahler in #3172525.

13 years agoUnblock and fast-redirect ".awin1.com/.*=http://"
Fabian Keil [Thu, 10 Feb 2011 22:20:38 +0000 (22:20 +0000)]
Unblock and fast-redirect ".awin1.com/.*=http://"

Reported by Adam Piggott in #3170921.

13 years agoActually the items are sorted, just not by priority.
Fabian Keil [Thu, 10 Feb 2011 22:18:30 +0000 (22:18 +0000)]
Actually the items are sorted, just not by priority.

13 years agoAdd #89: show multiple block reasons on the blocked page
Fabian Keil [Thu, 10 Feb 2011 22:16:55 +0000 (22:16 +0000)]
Add #89: show multiple block reasons on the blocked page

13 years agoBlock "b.collective-media.net/".
Fabian Keil [Mon, 24 Jan 2011 18:16:33 +0000 (18:16 +0000)]
Block "b.collective-media.net/".

13 years agoFix spelling.
Fabian Keil [Mon, 24 Jan 2011 18:12:44 +0000 (18:12 +0000)]
Fix spelling.

13 years agoWiden the Debian popcon exception to "qa.debian.org/popcon".
Fabian Keil [Sat, 22 Jan 2011 12:36:52 +0000 (12:36 +0000)]
Widen the Debian popcon exception to "qa.debian.org/popcon".

Seen in Debian's 05_default_action.dpatch by Roland Rosenfeld:
http://patch-tracker.debian.org/patch/series/view/privoxy/3.0.16-1/05_defaut_action.dpatch

13 years agoIntroduce a MAN_PAGE variable that defaults to privoxy.1.
Fabian Keil [Sat, 22 Jan 2011 12:33:11 +0000 (12:33 +0000)]
Introduce a MAN_PAGE variable that defaults to privoxy.1.

The Debian package uses section 8 for the man page and this should simplify the patch.

13 years agoFix various typos. Apparently I can't spell length too well.
Fabian Keil [Sat, 22 Jan 2011 12:30:22 +0000 (12:30 +0000)]
Fix various typos. Apparently I can't spell length too well.

Fixes taken from Debian's 29_typos.dpatch by Roland Rosenfeld:
http://patch-tracker.debian.org/patch/series/view/privoxy/3.0.16-1/29_typos.dpatch

13 years agoAdd a note that #13 is already being worked on and not particularly promising for...
Fabian Keil [Sat, 15 Jan 2011 13:12:45 +0000 (13:12 +0000)]
Add a note that #13 is already being worked on and not particularly promising for most users.

13 years agoAdd #88: Investigate if there's a Perl module that Privoxy-Regression-Test could...
Fabian Keil [Sat, 15 Jan 2011 13:11:24 +0000 (13:11 +0000)]
Add #88: Investigate if there's a Perl module that Privoxy-Regression-Test could optionally use to keep connections alive.

13 years agoDitch an already disabled workaround for a mysterious PHP bug in client_accept_encodi...
Fabian Keil [Fri, 14 Jan 2011 21:35:44 +0000 (21:35 +0000)]
Ditch an already disabled workaround for a mysterious PHP bug in client_accept_encoding().

13 years agoAccept and highlight: File modification detected: /usr/local/etc/privoxy/user-agent...
Fabian Keil [Fri, 14 Jan 2011 19:47:53 +0000 (19:47 +0000)]
Accept and highlight: File modification detected: /usr/local/etc/privoxy/user-agent.action

13 years agoRephrase a log message in any_loaded_file_changed().
Fabian Keil [Fri, 14 Jan 2011 19:47:16 +0000 (19:47 +0000)]
Rephrase a log message in any_loaded_file_changed().

Log messages should start with constant strings to simplify pattern matching.

13 years agoBlock ".gemius.pl/" which only seems to be used for user tracking.
Fabian Keil [Fri, 14 Jan 2011 19:34:04 +0000 (19:34 +0000)]
Block ".gemius.pl/" which only seems to be used for user tracking.

Reported by johnd16 in #3002731. Additional input from Lee and movax.

13 years agoUpdate the socket-timout 'Notes' section.
Fabian Keil [Sun, 9 Jan 2011 12:10:34 +0000 (12:10 +0000)]
Update the socket-timout 'Notes' section.

The socks-related limitation is gone now, even though
'next release' wasn't a particular good estimate.

13 years agoAccept and highlight: Client request arrived in time on socket 21.
Fabian Keil [Sun, 9 Jan 2011 12:09:21 +0000 (12:09 +0000)]
Accept and highlight: Client request arrived in time on socket 21.

13 years agoLet socks4_connect enforce the socket timeout for the negotiation response as well.
Fabian Keil [Sun, 9 Jan 2011 12:08:52 +0000 (12:08 +0000)]
Let socks4_connect enforce the socket timeout for the negotiation response as well.

13 years agoLet socks5_connect enforce the socket timeout for the negotiation response as well.
Fabian Keil [Sun, 9 Jan 2011 12:08:35 +0000 (12:08 +0000)]
Let socks5_connect enforce the socket timeout for the negotiation response as well.

13 years agoRephrase a log message in serve(). Client request arrival should be differentiated...
Fabian Keil [Sun, 9 Jan 2011 12:08:04 +0000 (12:08 +0000)]
Rephrase a log message in serve(). Client request arrival should be differentiated from closed client connections now.

13 years agoIn get_actions(), fix the "temporary" backwards compatibility hack to accept block...
Fabian Keil [Sun, 9 Jan 2011 12:00:19 +0000 (12:00 +0000)]
In get_actions(), fix the "temporary" backwards compatibility hack to accept block actions without reason.

It also covered other actions that should be rejected as invalid.
Reported by Billy Crook.

13 years agoIn listen_loop(), reload the configuration files after accepting a new connection...
Fabian Keil [Sun, 2 Jan 2011 12:17:03 +0000 (12:17 +0000)]
In listen_loop(), reload the configuration files after accepting a new connection instead of before.

Previously the first connection that arrived after a configuration
change would still be handled with the old configuration.

13 years agoIn chat()'s receive-data loop, skip the socket_is_still_alive(csp->cfd) check if...
Fabian Keil [Sun, 2 Jan 2011 11:57:45 +0000 (11:57 +0000)]
In chat()'s receive-data loop, skip the socket_is_still_alive(csp->cfd) check if we aren't buffering.

As Lee noticed, the check can measurable affect the performance.

13 years agoDon't log whether or not a request on a client connection that isn't kept alive has...
Fabian Keil [Fri, 31 Dec 2010 14:57:00 +0000 (14:57 +0000)]
Don't log whether or not a request on a client connection that isn't kept alive has been crunched.

It doesn't actually matter anymore.

13 years agoDitch a pointless NULL-pointer check in load_trustfile().
Fabian Keil [Fri, 31 Dec 2010 14:53:09 +0000 (14:53 +0000)]
Ditch a pointless NULL-pointer check in load_trustfile().

csp already got dereferenced earlier and can't be NULL.
Spotted by cppcheck.