From: Fabian Keil <fk@fabiankeil.de>
Date: Tue, 10 Nov 2020 10:47:18 +0000 (+0100)
Subject: Plug memory leak in cgi_show_status()
X-Git-Tag: v_3_0_29~33
X-Git-Url: http://www.privoxy.org/gitweb/?p=privoxy.git;a=commitdiff_plain;h=fdee85c0bf3e2dbd7722ddc45e9ed912f02a2136

Plug memory leak in cgi_show_status()

CID 305233
---

diff --git a/cgisimple.c b/cgisimple.c
index 592e7040..88f1c158 100644
--- a/cgisimple.c
+++ b/cgisimple.c
@@ -1348,9 +1348,9 @@ jb_err cgi_show_status(struct client_state *csp,
          if (!err) err = string_append(&s, "</td></tr>\n");
       }
    }
-   if (*s != '\0')
+   if (!err && *s != '\0')
    {
-      if (!err) err = map(exports, "actions-filenames", 1, s, 0);
+      err = map(exports, "actions-filenames", 1, s, 0);
    }
    else
    {