From: Fabian Keil <fk@fabiankeil.de>
Date: Fri, 22 Jan 2021 08:13:14 +0000 (+0100)
Subject: MbedTLS: Use mbedtls_md5_ret() instead of mbedtls_md5()
X-Git-Tag: v_3_0_30~38
X-Git-Url: http://www.privoxy.org/gitweb/?p=privoxy.git;a=commitdiff_plain;h=a473a2a85dbf5325b270a906e85785ba4b032503

MbedTLS: Use mbedtls_md5_ret() instead of mbedtls_md5()

As Roland pointed out the latter has been deprecated
years ago and causes a warning on Debian GNU/Linux.
---

diff --git a/ssl.c b/ssl.c
index 58bd222c..f74f585c 100644
--- a/ssl.c
+++ b/ssl.c
@@ -1780,8 +1780,15 @@ static int host_to_hash(struct client_state *csp)
 #error mbedTLS needs to be compiled with md5 support
 #else
    memset(csp->http->hash_of_host, 0, sizeof(csp->http->hash_of_host));
-   mbedtls_md5((unsigned char *)csp->http->host, strlen(csp->http->host),
-      csp->http->hash_of_host);
+   ret = mbedtls_md5_ret((unsigned char *)csp->http->host,
+      strlen(csp->http->host), csp->http->hash_of_host);
+   if (ret != 0)
+   {
+      log_error(LOG_LEVEL_ERROR,
+         "Failed to generate md5 hash of host %s: %d",
+         csp->http->host, ret);
+      return -1;
+   }
 
    /* Converting hash into string with hex */
    size_t i = 0;