redirect_url(): Silence a bogus use-after-free warning
authorFabian Keil <fk@fabiankeil.de>
Tue, 5 Jan 2021 00:03:25 +0000 (01:03 +0100)
committerFabian Keil <fk@fabiankeil.de>
Sun, 10 Jan 2021 15:48:22 +0000 (16:48 +0100)
... emitted by ccc-analyzer from llvm80.

filters.c

index 95fbe8d..91c9854 100644 (file)
--- a/filters.c
+++ b/filters.c
@@ -1246,8 +1246,9 @@ struct http_response *redirect_url(struct client_state *csp)
          }
          new_url = rewrite_url(requested_url, redirection_string);
 #ifdef FEATURE_HTTPS_INSPECTION
          }
          new_url = rewrite_url(requested_url, redirection_string);
 #ifdef FEATURE_HTTPS_INSPECTION
-         if (client_use_ssl(csp))
+         if (requested_url != csp->http->url)
          {
          {
+            assert(client_use_ssl(csp));
             freez(requested_url);
          }
 #endif
             freez(requested_url);
          }
 #endif