X-Git-Url: http://www.privoxy.org/gitweb/?p=privoxy.git;a=blobdiff_plain;f=urlmatch.c;h=77c63916141258333f7f709abca7ffea06c63e48;hp=0ddd57a788d7ae835f325553503f85941aafd3f6;hb=9d4711dd8724931686e0033fe41576079a5709b6;hpb=68e4d4cba2e37322878d79832aa5943fad679325 diff --git a/urlmatch.c b/urlmatch.c index 0ddd57a7..77c63916 100644 --- a/urlmatch.c +++ b/urlmatch.c @@ -1,4 +1,4 @@ -const char urlmatch_rcs[] = "$Id: urlmatch.c,v 1.33 2008/04/12 14:03:13 fabiankeil Exp $"; +const char urlmatch_rcs[] = "$Id: urlmatch.c,v 1.39 2008/04/22 16:27:42 fabiankeil Exp $"; /********************************************************************* * * File : $Source: /cvsroot/ijbswa/current/urlmatch.c,v $ @@ -33,6 +33,28 @@ const char urlmatch_rcs[] = "$Id: urlmatch.c,v 1.33 2008/04/12 14:03:13 fabianke * * Revisions : * $Log: urlmatch.c,v $ + * Revision 1.39 2008/04/22 16:27:42 fabiankeil + * In parse_http_request(), remove a pointless + * temporary variable and free the buffer earlier. + * + * Revision 1.38 2008/04/18 05:17:18 fabiankeil + * Mark simplematch()'s parameters as immutable. + * + * Revision 1.37 2008/04/17 14:53:29 fabiankeil + * Move simplematch() into urlmatch.c as it's only + * used to match (old-school) domain patterns. + * + * Revision 1.36 2008/04/14 18:19:48 fabiankeil + * Remove now-pointless cast in create_url_spec(). + * + * Revision 1.35 2008/04/14 18:11:21 fabiankeil + * The compiler might not notice it, but the buffer passed to + * create_url_spec() is modified later on and thus shouldn't + * be declared immutable. + * + * Revision 1.34 2008/04/13 13:32:07 fabiankeil + * Factor URL pattern compilation out of create_url_spec(). + * * Revision 1.33 2008/04/12 14:03:13 fabiankeil * Remove an obvious comment and improve another one. * @@ -514,7 +536,7 @@ jb_err parse_http_url(const char * url, http->host = strdup(host); - free(buf); + freez(buf); if (http->host == NULL) { @@ -610,7 +632,6 @@ jb_err parse_http_request(const char *req, char *v[10]; /* XXX: Why 10? We should only need three. */ int n; jb_err err; - int is_connect = 0; memset(http, '\0', sizeof(*http)); @@ -623,7 +644,7 @@ jb_err parse_http_request(const char *req, n = ssplit(buf, " \r\n", v, SZ(v), 1, 1); if (n != 3) { - free(buf); + freez(buf); return JB_ERR_PARSE; } @@ -639,39 +660,34 @@ jb_err parse_http_request(const char *req, if (unknown_method(v[0])) { log_error(LOG_LEVEL_ERROR, "Unknown HTTP method detected: %s", v[0]); - free(buf); + freez(buf); return JB_ERR_PARSE; } - if (strcmpic(v[0], "CONNECT") == 0) - { - is_connect = 1; - } - err = parse_http_url(v[1], http, csp); if (err) { - free(buf); + freez(buf); return err; } /* * Copy the details into the structure */ - http->ssl = is_connect; + http->ssl = !strcmpic(v[0], "CONNECT"); http->cmd = strdup(req); http->gpc = strdup(v[0]); http->ver = strdup(v[2]); + freez(buf); + if ( (http->cmd == NULL) || (http->gpc == NULL) || (http->ver == NULL) ) { - free(buf); return JB_ERR_MEMORY; } - free(buf); return JB_ERR_OK; } @@ -935,6 +951,144 @@ static jb_err compile_host_pattern(struct url_spec *url, const char *host_patter } +/********************************************************************* + * + * Function : simplematch + * + * Description : String matching, with a (greedy) '*' wildcard that + * stands for zero or more arbitrary characters and + * character classes in [], which take both enumerations + * and ranges. + * + * Parameters : + * 1 : pattern = pattern for matching + * 2 : text = text to be matched + * + * Returns : 0 if match, else nonzero + * + *********************************************************************/ +static int simplematch(const char *pattern, const char *text) +{ + const unsigned char *pat = (const unsigned char *)pattern; + const unsigned char *txt = (const unsigned char *)text; + const unsigned char *fallback = pat; + int wildcard = 0; + + unsigned char lastchar = 'a'; + unsigned i; + unsigned char charmap[32]; + + while (*txt) + { + + /* EOF pattern but !EOF text? */ + if (*pat == '\0') + { + if (wildcard) + { + pat = fallback; + } + else + { + return 1; + } + } + + /* '*' in the pattern? */ + if (*pat == '*') + { + + /* The pattern ends afterwards? Speed up the return. */ + if (*++pat == '\0') + { + return 0; + } + + /* Else, set wildcard mode and remember position after '*' */ + wildcard = 1; + fallback = pat; + } + + /* Character range specification? */ + if (*pat == '[') + { + memset(charmap, '\0', sizeof(charmap)); + + while (*++pat != ']') + { + if (!*pat) + { + return 1; + } + else if (*pat == '-') + { + if ((*++pat == ']') || *pat == '\0') + { + return(1); + } + for (i = lastchar; i <= *pat; i++) + { + charmap[i / 8] |= (unsigned char)(1 << (i % 8)); + } + } + else + { + charmap[*pat / 8] |= (unsigned char)(1 << (*pat % 8)); + lastchar = *pat; + } + } + } /* -END- if Character range specification */ + + + /* + * Char match, or char range match? + */ + if ( (*pat == *txt) + || (*pat == '?') + || ((*pat == ']') && (charmap[*txt / 8] & (1 << (*txt % 8)))) ) + { + /* + * Sucess: Go ahead + */ + pat++; + } + else if (!wildcard) + { + /* + * No match && no wildcard: No luck + */ + return 1; + } + else if (pat != fallback) + { + /* + * Increment text pointer if in char range matching + */ + if (*pat == ']') + { + txt++; + } + /* + * Wildcard mode && nonmatch beyond fallback: Rewind pattern + */ + pat = fallback; + /* + * Restart matching from current text pointer + */ + continue; + } + txt++; + } + + /* Cut off extra '*'s */ + if(*pat == '*') pat++; + + /* If this is the pattern's end, fine! */ + return(*pat); + +} + + /********************************************************************* * * Function : simple_domaincmp @@ -1070,7 +1224,7 @@ static int domain_match(const struct url_spec *pattern, const struct http_reques * function. If this function succeeds, the * buffer is copied to url->spec. If this * function fails, the contents of the buffer - * are lost forever. XXX: Why is this const? + * are lost forever. * * Returns : JB_ERR_OK - Success * JB_ERR_MEMORY - Out of memory @@ -1078,7 +1232,7 @@ static int domain_match(const struct url_spec *pattern, const struct http_reques * written to system log) * *********************************************************************/ -jb_err create_url_spec(struct url_spec * url, const char * buf) +jb_err create_url_spec(struct url_spec *url, char *buf) { assert(url); assert(buf); @@ -1101,7 +1255,7 @@ jb_err create_url_spec(struct url_spec * url, const char * buf) } /* If it isn't a tag pattern it must be a URL pattern. */ - return compile_url_pattern(url, (char *)buf); + return compile_url_pattern(url, buf); } @@ -1225,7 +1379,7 @@ int match_portlist(const char *portlist, int port) */ if (port == atoi(min)) { - free(portlist_copy); + freez(portlist_copy); return(1); } } @@ -1238,7 +1392,7 @@ int match_portlist(const char *portlist, int port) *max++ = '\0'; if(port >= atoi(min) && port <= (atoi(max) ? atoi(max) : 65535)) { - free(portlist_copy); + freez(portlist_copy); return(1); } @@ -1258,7 +1412,7 @@ int match_portlist(const char *portlist, int port) } } - free(portlist_copy); + freez(portlist_copy); return 0; }