X-Git-Url: http://www.privoxy.org/gitweb/?p=privoxy.git;a=blobdiff_plain;f=miscutil.c;h=5ddf9808053709fa2da3c8c28b33f42299355275;hp=3eb707ca15da9d39590c24c8587b17a3bdd06482;hb=55a6016d5ed218270c2307598f4f4fea94f8df60;hpb=b372098f33a0ba88171370233a9a63556e3cde1a diff --git a/miscutil.c b/miscutil.c index 3eb707ca..5ddf9808 100644 --- a/miscutil.c +++ b/miscutil.c @@ -1,4 +1,4 @@ -const char miscutil_rcs[] = "$Id: miscutil.c,v 1.57 2008/03/24 15:29:51 fabiankeil Exp $"; +const char miscutil_rcs[] = "$Id: miscutil.c,v 1.60 2008/09/07 12:35:05 fabiankeil Exp $"; /********************************************************************* * * File : $Source: /cvsroot/ijbswa/current/miscutil.c,v $ @@ -44,6 +44,17 @@ const char miscutil_rcs[] = "$Id: miscutil.c,v 1.57 2008/03/24 15:29:51 fabianke * * Revisions : * $Log: miscutil.c,v $ + * Revision 1.60 2008/09/07 12:35:05 fabiankeil + * Add mutex lock support for _WIN32. + * + * Revision 1.59 2008/09/04 08:13:58 fabiankeil + * Prepare for critical sections on Windows by adding a + * layer of indirection before the pthread mutex functions. + * + * Revision 1.58 2008/04/17 14:53:30 fabiankeil + * Move simplematch() into urlmatch.c as it's only + * used to match (old-school) domain patterns. + * * Revision 1.57 2008/03/24 15:29:51 fabiankeil * Pet gcc43. * @@ -960,6 +971,9 @@ char * make_path(const char * dir, const char * file) long int pick_from_range(long int range) { long int number; +#ifdef _WIN32 + static unsigned long seed = 0; +#endif /* def _WIN32 */ assert(range != 0); assert(range > 0); @@ -968,33 +982,27 @@ long int pick_from_range(long int range) #ifdef HAVE_RANDOM number = random() % range + 1; -#elif defined(FEATURE_PTHREAD) - pthread_mutex_lock(&rand_mutex); - number = rand() % (long int)(range + 1); - pthread_mutex_unlock(&rand_mutex); -#else +#elif defined(MUTEX_LOCKS_AVAILABLE) + privoxy_mutex_lock(&rand_mutex); #ifdef _WIN32 - /* - * On Windows and mingw32 srand() has to be called in every - * rand()-using thread, but can cause crashes if it's not - * mutex protected. - * - * Currently we don't have mutexes for mingw32, and for - * our purpose this cludge is probably preferable to crashes. - * - * The warning is shown once on startup from jcc.c. - */ - number = (range + GetCurrentThreadId() % range) / 2; + if (!seed) + { + seed = (unsigned long)(GetCurrentThreadId()+GetTickCount()); + } + srand(seed); + seed = (unsigned long)((rand() << 16) + rand()); +#endif /* def _WIN32 */ + number = (unsigned long)((rand() << 16) + (rand())) % (unsigned long)(range + 1); + privoxy_mutex_unlock(&rand_mutex); #else /* * XXX: Which platforms reach this and are there * better options than just using rand() and hoping * that it's safe? */ - log_error(LOG_LEVEL_INFO, "No thread-safe PRNG available? Header time randomization might cause " - "crashes, predictable results or even combine these fine options."); + log_error(LOG_LEVEL_INFO, "No thread-safe PRNG available? Header time randomization " + "might cause crashes, predictable results or even combine these fine options."); number = rand() % (long int)(range + 1); -#endif /* def _WIN32 */ #endif /* (def HAVE_RANDOM) */