X-Git-Url: http://www.privoxy.org/gitweb/?p=privoxy.git;a=blobdiff_plain;f=jcc.c;h=a805f0b26ac7eb6b3fcc82a5712bca8441561f79;hp=4b85fe70fef73e61f727a518b10e1aecbc728c3a;hb=f2be4cfb0e98db4cf6fcf33f3f1efadabe399887;hpb=c0def7e7a0e43f3a907e96391937817e8912d230 diff --git a/jcc.c b/jcc.c index 4b85fe70..a805f0b2 100644 --- a/jcc.c +++ b/jcc.c @@ -1981,7 +1981,7 @@ static jb_err parse_client_request(struct client_state *csp) strlen(MESSED_UP_REQUEST_RESPONSE), get_write_delay(csp)); /* XXX: Use correct size */ log_error(LOG_LEVEL_CLF, - "%s - - [%T] \"Invalid request generated\" 500 0", csp->ip_addr_str); + "%s - - [%T] \"Invalid request generated\" 400 0", csp->ip_addr_str); log_error(LOG_LEVEL_ERROR, "Invalid request line after applying header filters."); free_http_request(http); @@ -2556,6 +2556,7 @@ static jb_err change_encrypted_request_destination(struct client_state *csp) { jb_err err; char *original_host = csp->http->host; + int original_port = csp->http->port; log_error(LOG_LEVEL_REDIRECTS, "Rewrite detected: %s", csp->https_headers->first->str); @@ -2566,27 +2567,38 @@ static jb_err change_encrypted_request_destination(struct client_state *csp) { log_error(LOG_LEVEL_ERROR, "Couldn't parse rewritten request: %s.", jb_err_to_string(err)); + freez(original_host); return err; } if (csp->http->host == NULL) { + char port_string[10]; /* * The rewritten request line did not specify a host * which means we can use the original host specified * by the client. */ csp->http->host = original_host; + csp->http->port = original_port; log_error(LOG_LEVEL_REDIRECTS, "Keeping the original host: %s", csp->http->host); /* * If the rewritten request line didn't contain a host * it also didn't contain a port so we can reuse the host - * and set the port to 443. + * port. */ freez(csp->http->hostport); csp->http->hostport = strdup_or_die(csp->http->host); - csp->http->port = 443; + snprintf(port_string, sizeof(port_string), ":%d", original_port); + err = string_append(&csp->http->hostport, port_string); + if (err != JB_ERR_OK) + { + log_error(LOG_LEVEL_ERROR, "Failed to rebuild hostport: %s.", + jb_err_to_string(err)); + return err; + } + /* * While the request line didn't mention it, * we're https-inspecting and want to speak TLS @@ -2812,10 +2824,15 @@ static jb_err process_encrypted_request(struct client_state *csp) || (strcmp(csp->http->cmd, csp->https_headers->first->str) && (JB_ERR_OK != change_encrypted_request_destination(csp)))) { - log_error(LOG_LEVEL_ERROR, - "Failed to get the request destination in the rewritten headers"); ssl_send_data_delayed(&(csp->ssl_client_attr), - (const unsigned char *)CHEADER, strlen(CHEADER), get_write_delay(csp)); + (const unsigned char *)MESSED_UP_REQUEST_RESPONSE, + strlen(MESSED_UP_REQUEST_RESPONSE), get_write_delay(csp)); + log_error(LOG_LEVEL_ERROR, + "Invalid request line after applying header filters."); + /* XXX: Use correct size */ + log_error(LOG_LEVEL_CLF, + "%s - - [%T] \"Invalid request generated\" 400 0", csp->ip_addr_str); + return JB_ERR_PARSE; }