X-Git-Url: http://www.privoxy.org/gitweb/?p=privoxy.git;a=blobdiff_plain;f=deanimate.c;h=a6759da42644b18e6dd6bfcef323809dd73f8150;hp=66a6675a4c705f562be16ee542de8dd55f825a85;hb=9e73ea7b786dbd1b7c3b9e53812746e3fcc6c15b;hpb=767afb7f5d7062d75385b9ab3afdad47d0249a39 diff --git a/deanimate.c b/deanimate.c index 66a6675a..a6759da4 100644 --- a/deanimate.c +++ b/deanimate.c @@ -7,10 +7,10 @@ * - Deanimation of GIF images * * Copyright : Written by and Copyright (C) 2001 - 2004, 2006 by the - * SourceForge Privoxy team. https://www.privoxy.org/ + * Privoxy team. https://www.privoxy.org/ * * Based on the GIF file format specification (see - * http://tronche.com/computer-graphics/gif/gif89a.html) + * https://tronche.com/computer-graphics/gif/gif89a.html) * and ideas from the Image::DeAnim Perl module by * Ken MacFarlane, * @@ -131,6 +131,14 @@ static int buf_extend(struct binbuffer *buf, size_t length) *********************************************************************/ static int buf_copy(struct binbuffer *src, struct binbuffer *dst, size_t length) { + /* + * Sanity check: Make sure the source buffer contains + * data and there's work to be done. + */ + if (src->buffer == NULL || src->size == 0 || length == 0) + { + return 1; + } /* * Sanity check: Can't copy more data than we have @@ -304,8 +312,8 @@ static int gif_extract_image(struct binbuffer *src, struct binbuffer *dst) * an (optional) image block and an arbitrary number * of image extension blocks, produce an output GIF with * only one image block that contains the last image - * (extenstion) block of the original. - * Also strip Comments, Application extenstions, etc. + * (extension) block of the original. + * Also strip Comments, Application extensions, etc. * * Parameters : * 1 : src = Pointer to the source binbuffer @@ -325,6 +333,10 @@ int gif_deanimate(struct binbuffer *src, struct binbuffer *dst, int get_first_im { return 1; } + if (src->size <= 10) + { + return 1; + } c = buf_getbyte(src, 10); @@ -375,9 +387,11 @@ int gif_deanimate(struct binbuffer *src, struct binbuffer *dst, int get_first_im switch(buf_getbyte(src, 0)) { /* - * End-of-GIF Marker: Append current image and return + * End-of-GIF Marker: Append current image if we got + * one and return. */ case 0x3b: + if (image->size == 0) goto failed; goto write; /*