X-Git-Url: http://www.privoxy.org/gitweb/?p=privoxy.git;a=blobdiff_plain;f=client-tags.c;h=a8cb69609d078f4db7b28078cb31cc131bea842e;hp=f9b38c9c0499f06d3c09e0687a8f92920d650cfd;hb=0e2b9667dfee2ad8e33cf5b8e34cd2c9d75edbb7;hpb=3ac2e455b47cce2028e1f8c7de72a77a15491691 diff --git a/client-tags.c b/client-tags.c index f9b38c9c..a8cb6960 100644 --- a/client-tags.c +++ b/client-tags.c @@ -4,7 +4,7 @@ * * Purpose : Functions related to client-specific tags. * - * Copyright : Copyright (C) 2016 Fabian Keil + * Copyright : Copyright (C) 2016-2017 Fabian Keil * * This program is free software; you can redistribute it * and/or modify it under the terms of the GNU General @@ -234,7 +234,7 @@ void get_tag_list_for_client(struct list *tag_list, { struct client_specific_tag *next_tag = enabled_tags->next; log_error(LOG_LEVEL_INFO, - "Tag '%s' for client %s expired %u seconds ago. Deleting it.", + "Tag '%s' for client %s expired %ld seconds ago. Deleting it.", enabled_tags->name, client_address, (now - enabled_tags->end_of_life)); remove_tag_for_client(client_address, enabled_tags->name); @@ -276,14 +276,14 @@ time_t get_next_tag_timeout_for_client(const char *client_address) enabled_tags = get_tags_for_client(client_address); while (enabled_tags != NULL) { - log_error(LOG_LEVEL_CGI, "Evaluating tag '%s' for client %s. End of life %d", + log_error(LOG_LEVEL_CGI, "Evaluating tag '%s' for client %s. End of life %ld", enabled_tags->name, client_address, enabled_tags->end_of_life); if (enabled_tags->end_of_life) { time_t time_left = enabled_tags->end_of_life - now; /* Add a second to make sure the tag will have expired */ time_left++; - log_error(LOG_LEVEL_CGI, "%d > %d?", next_timeout, time_left); + log_error(LOG_LEVEL_CGI, "%ld > %ld?", next_timeout, time_left); if (next_timeout == 0 || next_timeout > time_left) { next_timeout = time_left; @@ -294,12 +294,41 @@ time_t get_next_tag_timeout_for_client(const char *client_address) privoxy_mutex_unlock(&client_tags_mutex); - log_error(LOG_LEVEL_CGI, "Next timeout in %d seconds", next_timeout); + log_error(LOG_LEVEL_CGI, "Next timeout in %ld seconds", next_timeout); return next_timeout; } + +/********************************************************************* + * + * Function : create_client_specific_tag + * + * Description : Allocates memory for a client specific tag + * and populates it. + * + * Parameters : + * 1 : name = The name of the tag to create. + * 2 : time_to_live = 0, or the number of seconds + * the tag remains activated. + * + * Returns : Pointer to populated tag + * + *********************************************************************/ +static struct client_specific_tag *create_client_specific_tag(const char *name, + const time_t time_to_live) +{ + struct client_specific_tag *tag; + + tag = zalloc_or_die(sizeof(struct client_specific_tag)); + tag->name = strdup_or_die(name); + tag->end_of_life = time_to_live ? (time(NULL) + time_to_live) : 0; + + return tag; + +} + /********************************************************************* * * Function : add_tag_for_client @@ -328,10 +357,7 @@ static void add_tag_for_client(const char *client_address, /* XXX: Code duplication. */ requested_tags = zalloc_or_die(sizeof(struct requested_tags)); requested_tags->client = strdup_or_die(client_address); - requested_tags->tags = zalloc_or_die(sizeof(struct client_specific_tag)); - requested_tags->tags->name = strdup_or_die(tag); - requested_tags->tags->end_of_life = time_to_live ? - (time(NULL) + time_to_live) : 0; + requested_tags->tags = create_client_specific_tag(tag, time_to_live); validate_requested_tags(); return; @@ -354,10 +380,7 @@ static void add_tag_for_client(const char *client_address, clients_with_tags->next->prev = clients_with_tags; clients_with_tags = clients_with_tags->next; clients_with_tags->client = strdup_or_die(client_address); - clients_with_tags->tags = zalloc_or_die(sizeof(struct client_specific_tag)); - clients_with_tags->tags->name = strdup_or_die(tag); - clients_with_tags->tags->end_of_life = time_to_live ? - (time(NULL) + time_to_live) : 0; + clients_with_tags->tags = create_client_specific_tag(tag, time_to_live); validate_requested_tags(); @@ -370,10 +393,7 @@ static void add_tag_for_client(const char *client_address, { if (enabled_tags->next == NULL) { - enabled_tags->next = zalloc_or_die(sizeof(struct client_specific_tag)); - enabled_tags->next->name = strdup_or_die(tag); - clients_with_tags->tags->end_of_life = time_to_live ? - (time(NULL) + time_to_live) : 0; + enabled_tags->next = create_client_specific_tag(tag, time_to_live); enabled_tags->next->prev = enabled_tags; break; } @@ -453,17 +473,16 @@ static void remove_tag_for_client(const char *client_address, const char *tag) /* Client has preceding client */ clients_with_tags->prev->next = clients_with_tags->next; } - freez(clients_with_tags->client); if (clients_with_tags == requested_tags) { - /* Removing last tag */ - freez(requested_tags); - clients_with_tags = requested_tags; - } - else - { - freez(clients_with_tags); + /* + * We're in the process of removing the last tag, + * mark the global list as empty. + */ + requested_tags = NULL; } + freez(clients_with_tags->client); + freez(clients_with_tags); } freez(enabled_tags->name); freez(enabled_tags); @@ -549,7 +568,7 @@ jb_err enable_client_specific_tag(struct client_state *csp, { add_tag_for_client(csp->client_address, tag_name, time_to_live); log_error(LOG_LEVEL_INFO, - "Tag '%s' enabled for client '%s'. TTL: %d.", + "Tag '%s' enabled for client '%s'. TTL: %ld.", tag->name, csp->client_address, time_to_live); }