X-Git-Url: http://www.privoxy.org/gitweb/?p=privoxy.git;a=blobdiff_plain;f=cgisimple.c;h=e465be36290363978ac7384da6c9468c74e4be3e;hp=0077e7c48149324278dd955bc3ab50586ef2940f;hb=aaceefe0b1e2b0f4f7cc3a916fe42a35b90701d4;hpb=965bb64d8cd49d60a5678172e73190e96ec02f48 diff --git a/cgisimple.c b/cgisimple.c index 0077e7c4..e465be36 100644 --- a/cgisimple.c +++ b/cgisimple.c @@ -5,7 +5,7 @@ * Purpose : Simple CGIs to get information about Privoxy's * status. * - * Copyright : Written by and Copyright (C) 2001-2020 the + * Copyright : Written by and Copyright (C) 2001-2021 the * Privoxy team. https://www.privoxy.org/ * * Based on the Internet Junkbuster originally written @@ -260,7 +260,13 @@ jb_err cgi_show_request(struct client_state *csp, } if (map(exports, "processed-request", 1, - html_encode_and_free_original(list_to_text(csp->headers)), 0)) + html_encode_and_free_original( +#ifdef FEATURE_HTTPS_INSPECTION + csp->http->ssl ? + list_to_text(csp->https_headers) : +#endif + list_to_text(csp->headers) + ), 0)) { free_map(exports); return JB_ERR_MEMORY; @@ -356,7 +362,7 @@ jb_err cgi_show_client_tags(struct client_state *csp, this_tag = csp->config->client_tags; if (this_tag->name == NULL) { - client_tag_status = strdup_or_die("
No tags available.
\n"); + client_tag_status = strdup_or_die("No tags have been configured.
\n"); } else { @@ -404,6 +410,7 @@ jb_err cgi_show_client_tags(struct client_state *csp, snprintf(buf, sizeof(buf), "%u", csp->config->client_tag_lifetime); if (map(exports, "refresh-delay", 1, buf, 1)) { + freez(client_tag_status); free_map(exports); return JB_ERR_MEMORY; } @@ -413,6 +420,7 @@ jb_err cgi_show_client_tags(struct client_state *csp, err = map_block_killer(exports, "tags-expire"); if (err != JB_ERR_OK) { + freez(client_tag_status); return err; } } @@ -518,8 +526,8 @@ jb_err cgi_toggle_client_tag(struct client_state *csp, * 3 : parameters = map of cgi parameters * * CGI Parameters : - * type : Selects the type of banner between "trans", "logo", - * and "auto". Defaults to "logo" if absent or invalid. + * type : Selects the type of banner between "trans", "pattern", + * and "auto". Defaults to "pattern" if absent or invalid. * "auto" means to select as if we were image-blocking. * (Only the first character really counts; b and t are * equivalent). @@ -534,6 +542,14 @@ jb_err cgi_send_banner(struct client_state *csp, { char imagetype = lookup(parameters, "type")[0]; + if (imagetype != 'a' && imagetype != 'b' && + imagetype != 'p' && imagetype != 't') + { + log_error(LOG_LEVEL_ERROR, "Overruling invalid image type '%c'.", + imagetype); + imagetype = 'p'; + } + /* * If type is auto, then determine the right thing * to do from the set-image-blocker action @@ -972,7 +988,8 @@ jb_err cgi_send_user_manual(struct client_state *csp, assert(rsp); assert(parameters); - if (0 == strncmpic(csp->config->usermanual, "http://", 7)) + if (0 == strncmpic(csp->config->usermanual, "http://", 7) || + 0 == strncmpic(csp->config->usermanual, "https://", 8)) { log_error(LOG_LEVEL_CGI, "Request for local user-manual " "received while user-manual delivery is disabled."); @@ -1146,15 +1163,15 @@ static char *get_filter_statistics_table(const struct client_state *csp) if (b->type == FT_CONTENT_FILTER) { unsigned long long executions; - unsigned long long pages_modified; + unsigned long long response_bodies_modified; unsigned long long hits; - get_filter_statistics(b->name, &executions, &pages_modified, &hits); + get_filter_statistics(b->name, &executions, &response_bodies_modified, &hits); snprintf(buf, sizeof(buf), "