- Announcing Privoxy 3.0.30 stable
+ Announcing Privoxy 3.0.33 stable
--------------------------------------------------------------------
-Privoxy 3.0.30 stable fixes a couple of bugs and introduces
-a few new features.
+Privoxy 3.0.33 fixes an XSS issue, multiple DoS issues and a
+couple of other bugs. The issues also affect earlier Privoxy releases.
+Privoxy 3.0.33 also comes with a couple of general improvements and
+new features.
--------------------------------------------------------------------
-ChangeLog for Privoxy 3.0.30
+ChangeLog for Privoxy 3.0.33
--------------------------------------------------------------------
+- Security/Reliability:
+ - cgi_error_no_template(): Encode the template name to prevent
+ XSS (cross-site scripting) when Privoxy is configured to servce
+ the user-manual itself.
+ Commit 0e668e9409c. OVE-20211102-0001. CVE-2021-44543.
+ Reported by: Artem Ivanov
+ - get_url_spec_param(): Free memory of compiled pattern spec
+ before bailing.
+ Reported by Joshua Rogers (Opera) who also provided the fix.
+ Commit 652b4b7cb0. OVE-20211201-0003. CVE-2021-44540.
+ - process_encrypted_request_headers(): Free header memory when
+ failing to get the request destination.
+ Reported by Joshua Rogers (Opera) who also provided the fix.
+ Commit 0509c58045. OVE-20211201-0002. CVE-2021-44541.
+ - send_http_request(): Prevent memory leaks when handling errors
+ Reported by Joshua Rogers (Opera) who also provided the fix.
+ Commit c48d1d6d08. OVE-20211201-0001. CVE-2021-44542.
- Bug fixes:
- - Check the actual URL for redirects when https inspecting requests.
- Previously Privoxy would only check the path which resulted in
- rewrite results being rejected as invalid URLs.
- Reported by withoutname in #1736.
- - Let the hide-referrer code tolerate Referer headers with https:// URLs.
- Previously they would always be treated like a changed host.
- - Use the https headers if the show-request handler is reached through
- https://. Previously Privoxy would use the http headers which
- may be empty on a reused connection.
- - Make CGI_PREFIX protocol-relative when building with FEATURE_HTTPS_INSPECTION.
- This unbreaks (at least) https://config.privoxy.org/client-tags whose
- buttons would previously use a http:// URL resulting in browser warnings.
- - Support using https-inspection and client-header-order at the same time.
- Previously Privoxy would crash.
- Reported by: Kai Raven
- - Properly reject rewrites from http to https as they currently
- aren't supported. Previously Privoxy would wait for the client
- to establish an encrypted connection which obviously would not happen.
- - When https inspection is enabled and Privoxy has been compiled with
- FEATURE_GRACEFUL_TERMINATION (not recommended for production builds),
- the TLS backend resources are free'd later on and only if no active
- connections are left. Prevents crashes when exiting "gracefully" at the
- wrong time.
+ - handle_established_connection(): Skip the poll()/select() calls
+ if TLS data is pending on the server socket. The TLS library may
+ have already consumed all the data from the server response in
+ which case poll() and select() will not detect that data is
+ available to be read.
+ Fixes SF bug #926 reported by Wen Yue.
+ - continue_https_chat(): Update csp->server_connection.request_sent
+ after sending the request to make sure the latency is calculated
+ correctly. Previously https connections were not reused after
+ timeout seconds after the first request made on the connection.
+ - free_pattern_spec(): Don't try to free an invalid pointer
+ when unloading an action file with a TAG pattern while
+ Privoxy has been compiled without FEATURE_PCRE_HOST_PATTERNS.
+ Closes: SF patch request #147. Patch by Maxim Antonov.
+ - Adjust build_request_line() to create a CONNECT request line when
+ https-inspecting and forwarding to a HTTP proxy.
+ Fixes SF bug #925 reported by Wen Yue.
+ - load_config(): Add a space that was missing in a log message.
+ - read_http_request_body(): Fix two error messages that used an
+ incorrect variable.
+ - If the the response is chunk-encoded, ignore the Content-Length
+ header sent by the server.
+ Allows to load https://redmine.lighttpd.net/ with filtering enabled.
- General improvements:
- - Allow to rewrite the request destination for https-inspected
- requests behind the client's back. The documentation already sort
- of claimed that it was supported by not especially mentioning that
- it didn't work for https-inspected requests.
- Fixes SF bug #923 reported by withoutname.
- - Add support for filtering client request bodies by using
- CLIENT-BODY-FILTER filters which can be enabled with the
- client-body-filter action.
- Patch submitted by Maxim Antonov.
- Sponsored by: Robert Klemme
- - Add the new action suppress-tag{} which can be used to prevent
- a tagger from adding a tag. Patch submitted by Maxim Antonov.
- Sponsored by: Robert Klemme
- - Gracefully handle existing website keys without matching certificates.
- This can happen if Privoxy was previously running with an invalid
- TLS configuration that didn't allow it to create a certificate.
- - Recycle debug bit 4 for Tagging-related messages.
- - Improve the message shown when the client-tags CGI page
- is requested with no tags configured.
- - Shorten the 'donate' and 'participate' links used by templates
- using redirects. Currently the redirects lead to the FAQ entries
- but in the future we may want to relocate the content and using
- redirects makes this more convenient.
- - Log an error when a PCRE-HOST-PATTERN is used with
- FEATURE_PCRE_HOST_PATTERNS disabled. Don't treat this a
- fatal error so the regression tests can be used with and
- without FEATURE_PCRE_HOST_PATTERNS.
- - The code compiles with older C compilers again.
- - The chdir() return code is checked to fix a compiler warning.
- - The packages feed has been removed from the source tarball.
- It's usually out of date when the source tarball is generated
- for the release.
- - Fixed harmless compiler warnings from GCC9 with -D_FORTIFY_SOURCE=2.
- - windows: Remove obsolete '$(DEST)/doc/images' target.
- - windows: Install the images referenced in the user manual.
- - Remove obsolete 'gnu_regex.@OBJEXT@' target.
- - When installing from the GNUMAkefile, don't create an 'images'
- directory which is no longer used. The images were relocated to
- the user-manual directory years ago.
- - Add new FEATURES to the show-status page and resort list.
- - Remove unused variable in the OpenSSL-specific code.
- - Update bug tracker URL in cgi_error_unknown().
- - Saved a couple of memory allocations when sorting client headers.
- - Improved a couple of error messages.
- - Saved memory allocations when using OpenSSL and checking if a
- key already exists.
- - The configure script will bail out if OpenSSL and mbedTLS are
- enabled at the same time.
- - Log a message right before exiting gracefully.
- - A couple of structures have been rearranged to require slightly
- less memory.
- - When https inspection is enabled and the certificate is invalid
- the error message is now sent with status code 403 instead of 200.
- - The Slackware rc script template has been renamed to
- slackware/rc.privoxy.in to silence complaints when building
- Debian packages.
- - When building with MbedTLS support, mbedtls_md5_ret() is used
- instead of mbedtls_md5() which is deprecated and causes a warning
- on Debian GNU/Linux.
+ - Allow to edit the add-header action through the CGI editor by
+ generalizing the code that got added with the suppress-tag action.
+ Closes SF patch request #146. Patch by Maxim Antonov.
+ - Add a CGI handler for /wpad.dat that returns a
+ Proxy Auto-Configuration (PAC) file.
+ Among other things, it can be used to instruct clients
+ through DHCP to use Privoxy as proxy.
+ For example with the dnsmasq option:
+ dhcp-option=252,http://config.privoxy.org/wpad.dat
+ Initial patch by Richard Schneidt.
+ - Don't log the applied actions in process_encrypted_request()
+ Log them in continue_https_chat() instead to mirror chat().
+ Prevents the applied actions from getting logged twice
+ for the first request on an https-inspected connection.
+ - OpenSSL generate_host_certificate(): Use config.privoxy.org as Common Name
+ Org and Org Unit if the real host name is too long to get accepted by OpenSSL.
+ Clients should only care about the Subject Alternative Name
+ anyway and we can continue to use the real host name for it.
+ Reported by Miles Wen on privoxy-users@.
+ - Establish the TLS connection with the client earlier and decide
+ how to route the request afterwards. This allows to change the
+ forwarding settings based on information from the https-inspected
+ request, for example the path.
+ - listen_loop(): When shutting down gracefully, close listening ports
+ before waiting for the threads to exit. Allows to start a second
+ Privoxy with the same config file while the first Privoxy is still
+ running.
+ - serve(): Close the client socket as well if the server socket
+ for an inspected connection has been closed. Privoxy currently
+ can't establish a new server connection when the client socket
+ is reused and would drop the connection in continue_https_chat()
+ anyway.
+ - Don't disable redirect checkers in redirect_url().
+ Disable them in handle_established_connection() instead.
+ Doing it in redirect_url() prevented the +redirect{} and
+ +fast-redirects{} actions from being logged with LOG_LEVEL_ACTIONS.
+ - handle_established_connection(): Slightly improve a comment.
+ - handle_established_connection(): Fix a comment.
+ - socks5_connect(): Fix indentation.
+ - handle_established_connection(): Improve an error message.
+ - create_pattern_spec(): Fix ifdef indentation.
+ - Fix comment typos.
+ - process_encrypted_request(): Improve a log message.
+ The function only processes request headers and there
+ may still be unread request body data left to process.
+ - chat(): Log the applied actions before deciding how to forward the request.
+ - parse_time_header(): Silence a coverity complaint when building without assertions.
+ - receive_encrypted_request_headers(): Improve a log message.
+ - mbedTLS get_ciphersuites_from_string(): Use strlcpy() instead of strncpy().
+ Previously the terminating NUL wasn't copied which resulted
+ in a compiler warning. This didn't cause actual problems as
+ the target buffer was initialized by zalloc_or_die() so the
+ last byte of the target buffer was NUL already.
+ Actually copying the terminating NUL seems clearer, though.
+ - Remove compiler warnings. "log_error(LOG_LEVEL_FATAL, ..."
+ doesn't return but apparently the compiler doesn't know that.
+ Get rid of several "this statement may fall through
+ [-Wimplicit-fallthrough=]" warnings.
+ - Store the PEM certificate in a dynamically allocated buffer
+ when https-inspecting. Should prevent errors like:
+ 2021-03-16 22:36:19.148 7f47bbfff700 Error: X509 PEM cert len 16694 is larger than buffer len 16383
+ As a bonus it should slightly reduce the memory usage as most
+ certificates are smaller than the previously used fixed buffer.
+ Reported by: Wen Yue
+ - OpenSSL generate_host_certificate(): Fix two error messsages.
+ - Improve description of handle_established_connection()
+ - OpenSSL ssl_store_cert(): Translate EVP_PKEY_EC to a string.
+ - OpenSSL ssl_store_cert(): Remove pointless variable initialization.
+ - OpenSSL ssl_store_cert(): Initialize pointer with NULL instead of 0.
- Action file improvements:
- - Block requests to eu-tlp03.kameleoon.com/.
- - Unblock metrics.sr.ht/.
- - Disable fast-redirects for .fsf.org/.
- - Disable fast-redirects for .gravater.com/.
- - Disable fast-redirects for .ksta.de/.
- - Block requests to tag.crsspxl.com/.
- - Block requests to analytics.slashdotmedia.com/.
- - Block requests to ml314.com/.
- - Block requests to .adroll.com/.
- - Block requests to fastlane.rubiconproject.com/.
- - Block requests to api.theadex.com/.
- - Block requests to ih.adscale.de/.
- - Block requests to .s400.meetrics.net/.
- - Block requests for pp.lp4.io/.
- - Block requests for trc-events.taboola.com/.
-
-- Filter file improvements:
- - A allow-autocompletion filter has been added which changes
- autocomplete="off" to "on" on input fields to allow autocompletion.
- Requested by Jamie Zawinski in #370.
- Filter based on a submission by Aaron Linville.
- - Added an imdb filter.
- - Added a sourceforge filter that reduces the amount of ads
- for proprietary software.
- - Added a github filter that removes the annoying "Sign-Up"
- banner and the Cookie disclaimer.
- - Removed a duplicated pcrs command from the js-annoyances filter.
- - The crude-parental filter now provides a short reason when blocking,
- inserts a link to Privoxy's webinterface and adds a new line at
- the end of the generated page.
+ - Disable fast-redirects for .microsoftonline.com/.
+ - Disable fast-redirects for idp.springer.com/.
+ - Disable fast-redirects for .zeit.de/zustimmung.
+ - Unblock adv-archiv.dfn-cert.de/.
+ - Block requests to eu-tlp01.kameleoon.eu/.
+ - Block requests to fpa-events.arstechnica.com/.
+ - Unblock nlnet.nl/.
+ - Unblock adguard.com/.
- Privoxy-Log-Parser:
- - Highlight a few more messages.
- - Add a handler for tagging messages.
- - Properly deal with 'Certificate error' crunches
- Previously the error description was highlighted as 'host'.
- - Log truncated LOG_LEVEL_CLF messages more gracefully
- and note that the statistics will be imprecise.
- - Fixed perldoc typo.
- - Bump version to 0.9.2.
+ - Highlight 'Socket timeout 3 reached: http://127.0.0.1:20000/no-filter/chunked-content/36'.
+ - Improve documentation for inactivity-detection mode.
+ - Detect date changes when looking for inactivity.
+ - Add a --passed-request-statistics-threshold option
+ that can be set to get statistics for requests that
+ were passed.
+ - Add a "inactivity detection" mode which can be useful
+ for debugging purposes.
+ - Bump version to 0.9.4.
+ - Only run print_intro() and print_outro() when syntax highlighting.
+ - Rephrase a sentence in the documentation.
+ - Highlight 'Client socket 7 is no longer usable. The server socket has been closed.'.
+ - Clarify --statistics output by explicitly mentioning that
+ the status codes sent by the server may differ from the ones
+ in "debug 512" messages.
+ - Fix typo in the --statistics output.
+ - Remove an unused variable.
+ - Highlight 'The peer notified us that the connection on socket 11 is going to be closed'.
- Privoxy-Regression-Test:
- - Use http://127.0.0.1:8118/ as default Privoxy address
- unless http_proxy is set through the environment.
- - Add a --privoxy-cgi-prefix option that specifies the prefix
- to use when building URLs that are supposed to reach Privoxy's
- CGI interface. If it's not set, http://p.p/ is used, which is
- supposed to work with the default Privoxy configuration.
- If Privoxy has been built with FEATURE_HTTPS_INSPECTION enabled,
- and if https inspection is activated with the +https-inspection
- action, this option can be used with "https://p.p/" provided the
- system running Privoxy-Regression-Test has been configured to
- trust the certificate used by Privoxy.
- Note that there are currently two tests in the official
- regression-tests.action file that are expected to fail
- when using "https://p.p/" as privoxy-cgi-prefix.
- - Skip the connection-established response in get_status_code()
- when looking for the status code with a CGI prefix
- that starts with https://. We care about the status code
- sent by the impersonated web server.
- - Use --proxy-header when using a CGI prefix with https://
- and a "Host:" header.
- - Allow '|' in tokens and values to allow tag patterns like
- "TAG:^(application|text)/(x-)?javascript$".
- - When get_cgi_page_or_else() fails, include the URL of the
- requested page in the log message.
- - Added a --check-bad-ssl option that can be used to verify that
- Privoxy detects certificate problems when accessing the test
- sites from badssl.com.
- - Bumped version to 0.7.2
+ - Remove duplicated word in a comment.
+
+- regression-tests.action:
+ - Add fetch test for http://p.p/wpad.dat.
+ - Bump for-privoxy-version to 3.0.33 which introduced the wpad.dat support.
+ - Add more tests for the '/send-banner' code.
+ - Add test for OVE-20210203-0001.
+ - Add a test for CVE-2021-20217.
- uagen:
- - Update example output.
- - Recommend the use of the https-inspection action in the documentation.
- - Upgrade a couple of URLs to https://.
- - Add ElectroBSD to the list of operating systems.
- - Bumped generated Firefox version to 78 (ESR).
- - Bumped version to 1.2.2.
-
- - User documentation:
- - Remove reference to 'How to Report Bugs Effectively'.
- It was only rendered as text without URL in the README anyway
- and there's no indication that users read it ...
- - Let the dok-readme target fix the location embedded into the
- README file. This used to be done by CVS but since the git migration
- it has to be done through other means.
- - Remove 'experimental' warning for client-specific-tag-related directives.
- They seem to work reliably and there is no obvious reason
- why we would change the syntax in the near future.
- - Describe how to check if Privoxy has been built with
- FEATURE_HTTPS_INSPECTION.
- - Add a link to the trusted-cas-file documentation
- that explains how the user can create the file herself.
- - Don't explicitly mention the license for the code coming from
- 'Anonymous Coders' and Junkbusters. It's obviously licensed under
- the GNU GPL like the rest of Privoxy or we wouldn't be allowed to
- distribute it.
- - Update the +hide-user-agent example with uagen output.
- - Slightly improve the wording of the ca-key-file documentation.
- - Explicitly mention Windows 10 as supported so search engines and
- users looking for it can find it.
- - Import a bunch of contributors from the ChangeLog.
- - Remove obsolete doc/gpl.html.
- - Upgrade a couple of links to https://.
- - Don't prefer the SourceForge patch tracker over the
- privoxy-devel mailing list. While at it, link to the
- SourceForge patch tracker.
- - Mention http-inspection in the 'my browser warns me about
- unauthenticated content' FAQ entry.
- - Simplify the 'Is there is a license or fee?' FAQ entry.
- - Add another +redirect{} example.
- - Explicitly mention that interested sponsors should include
- the link target in their first mail.
- - Clarify that only Privoxy team members can object to new sponsors
- and link to the list of current team members.
- - Note that sponsor URLs may not contain keyword spam.
- - Garbage collect doc/webserver/images which isn't referenced anymore.
- - Update the method to reach the proxy settings in Firefox.
- - Update proxy_setup.jpg description to refer to Firefox.
- - Regenerate proxy_setup.jpg with a more recent Firefox (78.0).
- - Regenerate files-in-use.jpg without obsolete standard.action
- with modern colors and a slightly better quality.
- - Update URL to the actionsfile tracker.
- - Update a support request URL.
- - Rephrase the 'Can Privoxy run as service' FAQ entry and
- remove an obsolete paragraph.
- - Let the 'Where can I get updated Actions Files?' entry link to
- the gitweb version of default.action.master.
- - Update a link to the default.action file.
- - Update URLs for trackers and mailing lists.
- - Replace CVS reference with git.
- - Mention regression-tests.action in the config file.
- - Explicitly mention in the config file that access to the
- CA key should be limited to Privoxy.
- - List more client-specific-tag examples for inspiration.
- - Add additional headers to the client-header-order example.
- - Note that actions aren't updated after rewrites.
- - Explicitly mention that upgrading from http to https with
- a client-header filter is not supported
- - Note that protocol and host have to be added when rewriting
- the destination host for https-inspected requests.
- - Explicitly mention that the CA key is used to sign certificates.
- - Put openssl command in 'command' tags.
- - The man page has been moved from section 1 to man section 8.
-
-- Developer manual:
- - Flesh out the build instructions for Debian.
- - Remove the packaging instructions for RPM-based systems.
- They don't work and we don't release RPM packages anymore anyway.
- - Remove the packaging instructions for Solaris.
- They don't work and we don't release Solaris packages anymore anyway.
- - Update the suggested subject for the announce mails.
- - Update upload instructions.
- ftp://upload.sourceforge.net is no longer functional.
- - Remove a couple of package-dependent upload instructions
- that don't actually work.
- - Remove 'cd current' that no longer works.
- - Add regression-tests.action to the list of files that should be installed.
- - Stop claiming that there are text versions of the manuals.
- We stopped building them in 2008 (9ed36a3c5e6f12).
- - Note that the 'webserver' target creates the link needed for the user-manual.
- - Suggest to use the master branch as reference when creating
- the ChangeLog so the steps work when the current branch differs
- from master which is likely as the developer manual
- suggests to use a local branch for development.
- - Add the -s flag to the suggested 'git tag' command. We prefer signed tags.
- - Mention that merges into 'master' should be avoided.
- - Add git commands that should result in a merge-free history.
- - Mention Privoxy-Regression-Test.
- - Add a section id to reduce link churn.
- - Recommend the dok-tidy target when building docs for the webserver.
- - Add another plug for the privoxy-devel mailing list.
- - Let the intro link the copyright section in the user manual instead
- of giving an incomplete summary of the license status.
- - Clarify that the webserver target uploads to the SourceForge webserver.
- - Mark the documentation for the Mac OS X installers as out of date and
- change the SCM name back to CVS.
- - Fix the location of the installer modules for Mac OS X.
- They are not actually available through git (yet).
- - Don't speak of Privoxy version 3 in the past tense.
- - Update the list of programs required for the release process.
- - Update description of the webserver target which uses ssh, not scp.
- - Remove obsolete reference to config.new.
-
-- Tests:
- - Add another hide-referrer{conditional-block} test.
- - Add another hide-referrer{conditional-forge} test.
- - Fix a hide-referrer{conditional-forge} test
- that expected an acceptable header to be forged.
- - Fix a hide-referrer{conditional-block} test
- that expected an acceptable Referer to be removed.
- - Explain why the "Set Header = Host: whatever.example.org" test is
- expected to fail when using a CGI prefix that starts with "https://".
- - Explain why a connection-sharing test is known to fail
- when using "https://p.p/" as CGI prefix.
- - Add a link to Privoxy-Regression-Test to regression-tests.action
- in case it isn't packaged.
- - Add regression tests for pcre host patterns.
-
-- Privoxy infrastructure:
- - Import a Privoxy logo for the website.
- - Update Tor onion service to HiddenServiceVersion 3.
- - Display the "model" photos in a single row and remove placeholder images.
- - Regenerate homepage with updated sponsor list.
- - Use the '/sponsor' redirect for the link to the sponsor page.
- - Git commit messages are sent to the Privoxy-commits mailing list.
+ - Bump generated Firefox version to 91 (ESR).
+ - Bump version to 1.2.3.
+ - Bump copyright.
+
+- Build system:
+ - configure: Bump SOURCE_DATE_EPOCH.
+ - GNUmakefile.in: Fix typo.
+ - configure: Add another warning in case --disable-pthread
+ is used while POSIX threads are available.
+ Various features don't even compile when not using threads.
+ - Add configure option to enable MemorySanitizer.
+ - Add configure option to enable UndefinedBehaviorSanitizer.
+ - Add configure option to enable AddressSanitizer.
+ - Bump copyright.
+ - Add a configure option to disable pcre JIT compilation.
+ While JIT compilation makes filtering faster it can
+ cause false-positive valgrind complaints.
+ As reported by Gwyn Ciesla in SF bug 924 it also can
+ cause problems when the SELinux policy does not grant
+ Privoxy "execmem" privileges.
+ - configure: Remove obsolete RPM_BASE check.
+
+- Windows build system:
+ - Update the build script to use mbed tls version 2.6.11.
+ - Update build script to use the final 8.45 pcre library.
+ - Put all the '--enable-xxx' options in the configure call together.
+
+- macOS build system:
+ - The OSXPackageBuilder repository has been updated and
+ can be used to create macOS packages again.
+
+- Documentation:
+ - contacting: Remove obsolete reference to announce.sgml.
+ - contacting: Request that the browser cache is cleared before
+ producing a log file for submission.
+ - Sponsor FAQ: Note that Privoxy users may follow sponsor links
+ without Referer header set.
+ - newfeatures: Clarify that https inspection also allows to
+ filter https responses.
+ - developer-manual: Mention that announce.txt should be updated
+ when doing a release.
+ - config: Explicitly mention that the CGI pages disclosing the
+ ca-password can be blocked and upgrade the disclosure paragraphs
+ to a warning.
+ - Put all the requested debug options in the config file.
+ Section 11.1 of the Privoxy user manual lists all the debug
+ options that should be enabled when reporting problems or requesting support.
+ Make it easier for users to do the right thing by having all those
+ options present in the config.
+ - Update TODO list item #184 to note that WolfSSL support will
+ (hopefully) appear after the 3.0.34 release.
+ - Update max-client-connections's description.
+ On modern systems other than Windows Privoxy should
+ use poll() in which case the FD_SETSIZE value isn't
+ releveant.
+ - Add a warning that the socket-timeout does not apply
+ to operations done by TLS libraries.
+ - Make documentation slightly less "offensive" for some people
+ by avoiding the word "hell".
-----------------------------------------------------------------
About Privoxy:
projects / privoxy.git / blobdiff