privoxy.git
9 years agoBetter late than never: bump version to 3.0.24 UNRELEASED
Fabian Keil [Tue, 25 Aug 2015 11:34:10 +0000 (11:34 +0000)]
Better late than never: bump version to 3.0.24 UNRELEASED

9 years agoAdd Yang Xia as contributor
Fabian Keil [Fri, 21 Aug 2015 10:59:07 +0000 (10:59 +0000)]
Add Yang Xia as contributor

9 years agoexecute_external_filter(): Actually fix the buffer scaling
Fabian Keil [Fri, 21 Aug 2015 10:58:53 +0000 (10:58 +0000)]
execute_external_filter(): Actually fix the buffer scaling

The previous commit was about as wrong as the code it
"fixed" and could still result in a buffer that wasn't
large enough to hold all the output from the external filter.

Submitted by Yang Xia in #892.

9 years agoAdd Jonathan McKenzie as contributor
Fabian Keil [Wed, 12 Aug 2015 10:41:26 +0000 (10:41 +0000)]
Add Jonathan McKenzie as contributor

9 years agoAdd Joel Verhagen and Jarry Xu as contributors
Fabian Keil [Wed, 12 Aug 2015 10:41:16 +0000 (10:41 +0000)]
Add Joel Verhagen and Jarry Xu as contributors

9 years agoFAQ: Explicitly point fingers at ASUS
Fabian Keil [Wed, 12 Aug 2015 10:40:42 +0000 (10:40 +0000)]
FAQ: Explicitly point fingers at ASUS

.. as an example of a company that has been reported
to force malware based on Privoxy upon its customers.

9 years agoWinMain: Use the correct function to close the event handle
Fabian Keil [Wed, 12 Aug 2015 10:39:16 +0000 (10:39 +0000)]
WinMain: Use the correct function to close the event handle

According to Microsoft's documentation DeleteObject() is
used to delete a "logical pen, brush, font, bitmap, region,
or palette" while CloseHandle() is supposed to be used
for the handle returned by CreateEvent():
https://msdn.microsoft.com/en-us/library/windows/desktop/dd183539%28v=vs.85%29.aspx
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682396%28v=vs.85%29.aspx
https://msdn.microsoft.com/en-us/library/windows/desktop/ms724211%28v=vs.85%29.aspx

It's conceivable that this commit fixes a tiny memory leak,
but then again maybe not as DeleteObject() is apparently full
of magic:
http://blogs.msdn.com/b/oldnewthing/archive/2013/03/06/10399678.aspx

Reported by Jarry Xu in #891.

9 years agoFAQ: Fix spelling of affect
Fabian Keil [Wed, 12 Aug 2015 10:38:45 +0000 (10:38 +0000)]
FAQ: Fix spelling of affect

9 years ago#132: Note some work in progress
Fabian Keil [Wed, 12 Aug 2015 10:38:16 +0000 (10:38 +0000)]
#132: Note some work in progress

9 years agoload_config(): In case of invalid forward-socks5(t) directives, use the correct direc...
Fabian Keil [Wed, 12 Aug 2015 10:38:02 +0000 (10:38 +0000)]
load_config(): In case of invalid forward-socks5(t) directives, use the correct directive name

Previously the error messages referred to forward-socks4t failures.

Reported by Joel Verhagen in #889.

9 years agoAdd #141: Port Privoxy to CloudABI
Fabian Keil [Wed, 12 Aug 2015 10:37:44 +0000 (10:37 +0000)]
Add #141: Port Privoxy to CloudABI

9 years agoUnblock klikki.fi/adv/
Fabian Keil [Wed, 12 Aug 2015 10:37:26 +0000 (10:37 +0000)]
Unblock klikki.fi/adv/

9 years agotranslate_socks5_error(): Improve SOCKS5_REQUEST_HOST_UNREACHABLE translation
Fabian Keil [Wed, 12 Aug 2015 10:37:11 +0000 (10:37 +0000)]
translate_socks5_error(): Improve SOCKS5_REQUEST_HOST_UNREACHABLE translation

... to make it more obvious that it's the destination
host that is unreachable and not the host running the
socks server.

9 years agomalloc_or_die(): Catch and prevent attempted zero-size allocations
Fabian Keil [Wed, 12 Aug 2015 10:34:38 +0000 (10:34 +0000)]
malloc_or_die(): Catch and prevent attempted zero-size allocations

9 years agoexecute_external_filter(): Don't rely on undefined malloc() behaviour
Fabian Keil [Wed, 12 Aug 2015 10:34:21 +0000 (10:34 +0000)]
execute_external_filter(): Don't rely on undefined malloc() behaviour

... and fix the read buffer scaling for initial sizes below READ_LENGTH.

Could fix the crash reported by Jonathan McKenzie on ijbswa-users@

9 years agodocbook2man-spec.pl: Update the inserted man page banner
Fabian Keil [Wed, 12 Aug 2015 10:33:56 +0000 (10:33 +0000)]
docbook2man-spec.pl: Update the inserted man page banner

.. to make it more obvious that the script is part of Privoxy's source tarball.

Remove suggestion that bug reports should be reported to the original author
as the referenced address is no longer useful thanks to a domain squatter.

9 years agoDisable filter{banners-by-size} for .plasmaservice.de/
Fabian Keil [Wed, 12 Aug 2015 10:33:32 +0000 (10:33 +0000)]
Disable filter{banners-by-size} for .plasmaservice.de/

9 years agoget_actions(): Detect and reject parameters for parameter-less actions
Fabian Keil [Wed, 12 Aug 2015 10:33:13 +0000 (10:33 +0000)]
get_actions(): Detect and reject parameters for parameter-less actions

Previously they were silently ignored.

9 years agoIncrease socks5_connect()'s optimism
Fabian Keil [Thu, 18 Jun 2015 15:26:40 +0000 (15:26 +0000)]
Increase socks5_connect()'s optimism

... and let it send the request body optimistically as well.

It's not that complicated and, more importantly, previously
the request body wasn't guaranteed to be sent at all.

Should fix #1686 reported by Peter Müller and G4JC.

9 years agoRegenerated docs with CVEs for 3.0.23 and bumped copyright
Fabian Keil [Sun, 29 Mar 2015 17:22:36 +0000 (17:22 +0000)]
Regenerated docs with CVEs for 3.0.23 and bumped copyright

9 years agoBump copyright
Fabian Keil [Sun, 29 Mar 2015 17:22:20 +0000 (17:22 +0000)]
Bump copyright

9 years agoAdd CVEs for 3.0.23 stable
Fabian Keil [Sun, 29 Mar 2015 17:22:05 +0000 (17:22 +0000)]
Add CVEs for 3.0.23 stable

9 years agoBump copyright
Fabian Keil [Fri, 27 Mar 2015 12:42:13 +0000 (12:42 +0000)]
Bump copyright

9 years agoAdd CVEs for Privoxy 3.0.23
Fabian Keil [Fri, 27 Mar 2015 12:41:57 +0000 (12:41 +0000)]
Add CVEs for Privoxy 3.0.23

9 years agolisten_loop(): Add number of active threads to a couple of log messages
Fabian Keil [Fri, 27 Mar 2015 12:40:08 +0000 (12:40 +0000)]
listen_loop(): Add number of active threads to a couple of log messages

9 years agodecompress_iob(): Refine the log message emitted when the iob is too small
Fabian Keil [Fri, 27 Mar 2015 12:39:44 +0000 (12:39 +0000)]
decompress_iob(): Refine the log message emitted when the iob is too small

9 years agoUnblock .deutschlandradiokultur.de/
Fabian Keil [Sat, 21 Feb 2015 18:56:34 +0000 (18:56 +0000)]
Unblock .deutschlandradiokultur.de/

Reported by u302320 in #924.

9 years agoAdd two fast-redirect exceptions for yandex.ru
Fabian Keil [Sat, 21 Feb 2015 18:55:53 +0000 (18:55 +0000)]
Add two fast-redirect exceptions for yandex.ru

9 years agoImport last-minute changes
Fabian Keil [Mon, 26 Jan 2015 11:26:16 +0000 (11:26 +0000)]
Import last-minute changes

9 years agoFix contributor name
Fabian Keil [Mon, 26 Jan 2015 11:25:45 +0000 (11:25 +0000)]
Fix contributor name

9 years agoRegenerate docs for Privoxy 3.0.23 stable
Fabian Keil [Sat, 24 Jan 2015 16:44:43 +0000 (16:44 +0000)]
Regenerate docs for Privoxy 3.0.23 stable

9 years agoRegenerate config file for Privoxy 3.0.23
Fabian Keil [Sat, 24 Jan 2015 16:44:20 +0000 (16:44 +0000)]
Regenerate config file for Privoxy 3.0.23

9 years agoImport changelog for Privoxy 3.0.23
Fabian Keil [Sat, 24 Jan 2015 16:44:08 +0000 (16:44 +0000)]
Import changelog for Privoxy 3.0.23

9 years agoAdd CVEs for Privoxy 3.0.22 stable
Fabian Keil [Sat, 24 Jan 2015 16:43:45 +0000 (16:43 +0000)]
Add CVEs for Privoxy 3.0.22 stable

9 years agoAdd changes for 3.0.23 stable
Fabian Keil [Sat, 24 Jan 2015 16:43:34 +0000 (16:43 +0000)]
Add changes for 3.0.23 stable

9 years agoDeclare 3.0.23 'stable'
Fabian Keil [Sat, 24 Jan 2015 16:43:21 +0000 (16:43 +0000)]
Declare 3.0.23 'stable'

9 years agoAdd Basil Hussain as contributor
Fabian Keil [Sat, 24 Jan 2015 16:43:11 +0000 (16:43 +0000)]
Add Basil Hussain as contributor

9 years agoPrevent parse errors after failing to deliver a client request with body
Fabian Keil [Sat, 24 Jan 2015 16:42:57 +0000 (16:42 +0000)]
Prevent parse errors after failing to deliver a client request with body

For now we err on the safe side and simply throw all the following
requests under the bus, even if no client body has been buffered.
A compliant client will repeat the dropped requests on an untainted
connection.

The proper fix is to discard the no longer needed client body
in the buffer (if there is one) and to continue parsing the
bytes that follow. This is less trivial and will have to wait
until the next release.

Reported by Basil Hussain.

9 years agoAdd Matthew Daley as contributor
Fabian Keil [Sat, 24 Jan 2015 16:42:23 +0000 (16:42 +0000)]
Add Matthew Daley as contributor

9 years agoEmphasize that Privoxy is serious business
Fabian Keil [Sat, 24 Jan 2015 16:42:13 +0000 (16:42 +0000)]
Emphasize that Privoxy is serious business

9 years agoAdd parse_time_header(), a wrapper around parse_header_time()
Fabian Keil [Sat, 24 Jan 2015 16:41:51 +0000 (16:41 +0000)]
Add parse_time_header(), a wrapper around parse_header_time()

... which skips the header name for the callers which means
they can't get it wrong. Previously two callers did. This could
result in 'invalid read of size X' issues in case of value-less
headers.

On the systems I tested, X was always 1 and nobody but valgrind
cared, but with different malloc() implementations Privoxy might
be less lucky and segfault.

Partially discovered with afl-fuzz.

9 years agochunked_body_is_complete(): Check input more carefully
Fabian Keil [Sat, 24 Jan 2015 16:41:20 +0000 (16:41 +0000)]
chunked_body_is_complete(): Check input more carefully

Previously a nul-chunk without mandatory trailing "\r\n" would
not be rejected as invalid. When compiled with assertions enabled,
this would cause Privoxy to abort().

Reported by Matthew Daley.

9 years agopcrs_compile_replacement(): Fix multiple segfaults and memory leaks
Fabian Keil [Sat, 24 Jan 2015 16:40:59 +0000 (16:40 +0000)]
pcrs_compile_replacement(): Fix multiple segfaults and memory leaks

... and report errors more reliably. Previously some invalid
pcrs commands were silently accepted but didn't work as expected.

Partially discovered with afl-fuzz.

9 years agoAdd ElectroBSD to the list of BSDs Privoxy is known to run on
Fabian Keil [Sat, 24 Jan 2015 16:40:47 +0000 (16:40 +0000)]
Add ElectroBSD to the list of BSDs Privoxy is known to run on

9 years agoFix comment typo
Fabian Keil [Sat, 24 Jan 2015 16:40:37 +0000 (16:40 +0000)]
Fix comment typo

9 years agoProperly explain why the pcrs job couldn't be compiled
Fabian Keil [Sat, 24 Jan 2015 16:40:21 +0000 (16:40 +0000)]
Properly explain why the pcrs job couldn't be compiled

9 years agoGrammar fixes for the dok-tidy description
Fabian Keil [Sat, 24 Jan 2015 16:40:07 +0000 (16:40 +0000)]
Grammar fixes for the dok-tidy description

9 years agoAdd a web-user-manual target that uses rsync
Fabian Keil [Sat, 24 Jan 2015 16:39:53 +0000 (16:39 +0000)]
Add a web-user-manual target that uses rsync

9 years agoRemove #84 as it's a duplicate of #51
Fabian Keil [Fri, 19 Dec 2014 12:36:06 +0000 (12:36 +0000)]
Remove #84 as it's a duplicate of #51

Rephrase #51 to make it more obvious.

9 years agoFix spelling in #126
Fabian Keil [Fri, 19 Dec 2014 12:35:30 +0000 (12:35 +0000)]
Fix spelling in #126

9 years agoRegenerate documentation
Fabian Keil [Fri, 19 Dec 2014 12:32:15 +0000 (12:32 +0000)]
Regenerate documentation

9 years agoAdd the Paypal address
Fabian Keil [Fri, 19 Dec 2014 12:31:46 +0000 (12:31 +0000)]
Add the Paypal address

9 years agoRemove CVS $Log
Fabian Keil [Fri, 19 Dec 2014 12:31:28 +0000 (12:31 +0000)]
Remove CVS $Log

9 years agoUnblock .amnesty.de/
Fabian Keil [Fri, 19 Dec 2014 12:31:10 +0000 (12:31 +0000)]
Unblock .amnesty.de/

9 years agoDitch previously missed 'Bookmarklets' section in the templates
Fabian Keil [Fri, 19 Dec 2014 12:30:53 +0000 (12:30 +0000)]
Ditch previously missed 'Bookmarklets' section in the templates

9 years agoDeemphasize the existence of the SF support trackers which have been broken for months
Fabian Keil [Fri, 19 Dec 2014 12:30:38 +0000 (12:30 +0000)]
Deemphasize the existence of the SF support trackers which have been broken for months

9 years agoStop pretending that default.action updates are made available on their own
Fabian Keil [Fri, 19 Dec 2014 12:29:53 +0000 (12:29 +0000)]
Stop pretending that default.action updates are made available on their own

9 years agoRemove the 'Request New Features' section
Fabian Keil [Fri, 19 Dec 2014 12:29:39 +0000 (12:29 +0000)]
Remove the 'Request New Features' section

The tracker has been broken for months and the TODO list is long
enough anyway.

9 years agoAdd +limit-cookie-lifetime{} to the list of avilable actions
Fabian Keil [Fri, 19 Dec 2014 12:29:20 +0000 (12:29 +0000)]
Add +limit-cookie-lifetime{} to the list of avilable actions

9 years agoFix comment typos
Fabian Keil [Fri, 19 Dec 2014 12:28:10 +0000 (12:28 +0000)]
Fix comment typos

9 years agoExplicitly mention that Tor's port may deviate from the default
Fabian Keil [Fri, 28 Nov 2014 14:26:35 +0000 (14:26 +0000)]
Explicitly mention that Tor's port may deviate from the default

... when using a bundle.

Reported by Andrew on ijbswa-users@.

9 years agoStop blocking .sify.com/
Fabian Keil [Fri, 28 Nov 2014 14:13:22 +0000 (14:13 +0000)]
Stop blocking .sify.com/

It's not actually a pure tracking site (anymore?).

Reported by Andrew on ijbswa-users@.

9 years agoBump version to 3.0.23 UNRELEASED
Fabian Keil [Fri, 28 Nov 2014 14:13:02 +0000 (14:13 +0000)]
Bump version to 3.0.23 UNRELEASED

9 years agoAdd Kai Raven to the list of contributors
Fabian Keil [Thu, 20 Nov 2014 15:30:38 +0000 (15:30 +0000)]
Add Kai Raven to the list of contributors

9 years agoUpdate the announcement for 3.0.22
Fabian Keil [Thu, 20 Nov 2014 15:30:14 +0000 (15:30 +0000)]
Update the announcement for 3.0.22

9 years agoAdd a bunch of missing test levels
Fabian Keil [Thu, 20 Nov 2014 15:29:57 +0000 (15:29 +0000)]
Add a bunch of missing test levels

Prevents test failures when the action file editor has
been disabled or isn't available.

9 years agoAdd FEATURE_CGI_EDIT_ACTIONS dependency for test level 12
Fabian Keil [Thu, 20 Nov 2014 15:29:36 +0000 (15:29 +0000)]
Add FEATURE_CGI_EDIT_ACTIONS dependency for test level 12

9 years agoRebuild docs
Fabian Keil [Tue, 18 Nov 2014 14:22:36 +0000 (14:22 +0000)]
Rebuild docs

9 years agoNote that --disable-force is known to be broken
Fabian Keil [Tue, 18 Nov 2014 14:22:17 +0000 (14:22 +0000)]
Note that --disable-force is known to be broken

9 years agoSkip test level 13 unless the keep-alive-timeout is above 20
Fabian Keil [Tue, 18 Nov 2014 14:21:56 +0000 (14:21 +0000)]
Skip test level 13 unless the keep-alive-timeout is above 20

The tests are expected to fail with lower values, for example
the 5 seconds specified in the default config file.

Reported by Lee.

9 years agoMake the FORCE_PREFIX define always visible
Fabian Keil [Sun, 16 Nov 2014 18:43:48 +0000 (18:43 +0000)]
Make the FORCE_PREFIX define always visible

Fixes a compile error when configured with --disable-force in
which case the define is still required for the show-status page.

Reported by Kai Raven.

9 years agoFix a ChangeLog entry
Fabian Keil [Fri, 14 Nov 2014 13:50:51 +0000 (13:50 +0000)]
Fix a ChangeLog entry

9 years agoRevert r1.54 "Add range-related tests for external-filter{}"
Fabian Keil [Fri, 14 Nov 2014 12:59:11 +0000 (12:59 +0000)]
Revert r1.54 "Add range-related tests for external-filter{}"

When configured with the defaults, Privoxy does not accept
the external-filter{} action. Privoxy should probably be
changed to silently ignore the action, but this will have
to wait until the next release.

9 years agoRebuild HTML docs
Fabian Keil [Fri, 14 Nov 2014 11:32:27 +0000 (11:32 +0000)]
Rebuild HTML docs

9 years agoRebuild text docs
Fabian Keil [Fri, 14 Nov 2014 11:32:05 +0000 (11:32 +0000)]
Rebuild text docs

9 years agoRebuild config file for 3.0.22 stable
Fabian Keil [Fri, 14 Nov 2014 11:31:53 +0000 (11:31 +0000)]
Rebuild config file for 3.0.22 stable

9 years agoUpdate SGML ChangeLog
Fabian Keil [Fri, 14 Nov 2014 11:31:41 +0000 (11:31 +0000)]
Update SGML ChangeLog

9 years agoPrevent leading and trailing whitespace in quotes
Fabian Keil [Fri, 14 Nov 2014 11:31:24 +0000 (11:31 +0000)]
Prevent leading and trailing whitespace in quotes

9 years agoChangeLog cosmetic
Fabian Keil [Fri, 14 Nov 2014 11:31:11 +0000 (11:31 +0000)]
ChangeLog cosmetic

9 years agoDeclare 3.0.22 'stable'
Fabian Keil [Fri, 14 Nov 2014 11:30:59 +0000 (11:30 +0000)]
Declare 3.0.22 'stable'

9 years agoChangeLog cosmetic
Fabian Keil [Fri, 14 Nov 2014 10:40:50 +0000 (10:40 +0000)]
ChangeLog cosmetic

9 years agoUpdate ChangeLog to reflect recent changes
Fabian Keil [Fri, 14 Nov 2014 10:40:40 +0000 (10:40 +0000)]
Update ChangeLog to reflect recent changes

9 years agoFix memory leak in rfc2553_connect_to()
Fabian Keil [Fri, 14 Nov 2014 10:40:24 +0000 (10:40 +0000)]
Fix memory leak in rfc2553_connect_to()

CID 66382.

9 years agopcrs_execute(): Consistently set *result to NULL in case of errors
Fabian Keil [Fri, 14 Nov 2014 10:40:10 +0000 (10:40 +0000)]
pcrs_execute(): Consistently set *result to NULL in case of errors

Should make use-after-free in the caller less likely.

CID 66391, CID 66376.

9 years agounmap(): Prevent use-after-free if the map only consists of one item
Fabian Keil [Fri, 14 Nov 2014 10:39:49 +0000 (10:39 +0000)]
unmap(): Prevent use-after-free if the map only consists of one item

CID 66394.

9 years agoMake sure csp flags have unique values
Fabian Keil [Wed, 12 Nov 2014 12:00:41 +0000 (12:00 +0000)]
Make sure csp flags have unique values

Previously CSP_FLAG_CRUNCHED and CSP_FLAG_CLIENT_CONNECTION_HEADER_SET
shared the same bit which obviously wasn't intentional.

The only negative effect was that Privoxy potentially reused less
connections than it could have, which explains why the problem hasn't
been noticed for seven years and was only found by manual code
inspection.

9 years agoLink to the 'Would you like to donate?' FAQ
Fabian Keil [Wed, 12 Nov 2014 12:00:10 +0000 (12:00 +0000)]
Link to the 'Would you like to donate?' FAQ

... instead of repeating parts of it while leaving out the rest.

9 years agoLet server_keep_alive() always remove the Keep-Alive header
Fabian Keil [Wed, 12 Nov 2014 11:59:47 +0000 (11:59 +0000)]
Let server_keep_alive() always remove the Keep-Alive header

Not forwarding the header to the client is a MUST and
non-compliance has no advantage here.

Fixes Co-Advisor test case rfc2616/hopHdr-Keep-Alive-toClt.

9 years agoUpdate URL of Polipo's website
Fabian Keil [Tue, 11 Nov 2014 12:19:52 +0000 (12:19 +0000)]
Update URL of Polipo's website

9 years agoDisable banners-by-size for kggp.de/
Fabian Keil [Tue, 11 Nov 2014 12:19:38 +0000 (12:19 +0000)]
Disable banners-by-size for kggp.de/

10 years agoPreserve negative HTTP status numbers
Fabian Keil [Mon, 3 Nov 2014 14:41:12 +0000 (14:41 +0000)]
Preserve negative HTTP status numbers

While they are technically invalid, "supporting" them doesn't
hurt and this gets the recently added curl test 1430 "working".

10 years agoAdd two consenting donors to the list of contributors
Fabian Keil [Mon, 3 Nov 2014 14:40:53 +0000 (14:40 +0000)]
Add two consenting donors to the list of contributors

10 years agoAdd changes for 3.0.22 stable
Fabian Keil [Mon, 3 Nov 2014 14:40:25 +0000 (14:40 +0000)]
Add changes for 3.0.22 stable

10 years agoAdd a couple of contributors
Fabian Keil [Mon, 3 Nov 2014 14:39:37 +0000 (14:39 +0000)]
Add a couple of contributors

10 years agoRegenerate docs
Fabian Keil [Tue, 21 Oct 2014 15:31:49 +0000 (15:31 +0000)]
Regenerate docs

10 years agoAdd #138: Bring back the scripts to provide actions file feedback
Fabian Keil [Tue, 21 Oct 2014 15:31:32 +0000 (15:31 +0000)]
Add #138: Bring back the scripts to provide actions file feedback

10 years agoBump copyright
Fabian Keil [Tue, 21 Oct 2014 15:31:16 +0000 (15:31 +0000)]
Bump copyright

10 years agoFix web-actions target
Fabian Keil [Tue, 21 Oct 2014 15:31:05 +0000 (15:31 +0000)]
Fix web-actions target

10 years agoGarbage-collect bookmarklets section
Fabian Keil [Tue, 21 Oct 2014 15:30:52 +0000 (15:30 +0000)]
Garbage-collect bookmarklets section

Most of the bookmarklets can't possible work due to not using a
trusted referer header and the rest of them can be replaced with
common bookmarks.

10 years agoFormally declare the scripts in doc/webserver/actions/ out of action
Fabian Keil [Tue, 21 Oct 2014 15:30:27 +0000 (15:30 +0000)]
Formally declare the scripts in doc/webserver/actions/ out of action

They haven't worked in years and the docs no longer reference them.