Fabian Keil [Tue, 16 Jun 2009 15:42:28 +0000 (15:42 +0000)]
In case of strftime() failures in client_if_modified_since(), keep the original header around.
Lee's Privoxy-Regression-Test result seems to indicate that it may
fail on Windows if the generated date predates the Unix epoch.
Fabian Keil [Mon, 15 Jun 2009 20:50:56 +0000 (20:50 +0000)]
Don't request 'Connection: keep-alive' from the server if keep-alive-timeout is 0.
We're not going to reuse the connection anyway.
Fabian Keil [Mon, 15 Jun 2009 20:49:09 +0000 (20:49 +0000)]
Let level 13 also depend on 'config line keep-alive-timeout\s+[1-9]+'.
Noticed by Lee.
Fabian Keil [Mon, 15 Jun 2009 20:47:49 +0000 (20:47 +0000)]
Let dependency_unsatisfied() properly deal with tests that depend on both config lines and features.
Fabian Keil [Mon, 15 Jun 2009 17:12:45 +0000 (17:12 +0000)]
Remove duplicated single-quotes.
Fabian Keil [Mon, 15 Jun 2009 15:08:03 +0000 (15:08 +0000)]
Patch #
2806626 from Frédéric Crozat to fix a closing tag.
Fabian Keil [Sun, 14 Jun 2009 15:59:56 +0000 (15:59 +0000)]
In get_log_level_string(), don't hide the LOG_LEVEL_REDIRECTS
translation behind ifdef FEATURE_FAST_REDIRECTS. It's used for
redirect{} as well.
Fabian Keil [Sun, 14 Jun 2009 14:37:08 +0000 (14:37 +0000)]
In case of connection timeouts or missing server data, use a Last-Modified date in the past as well.
Fabian Keil [Sun, 14 Jun 2009 14:36:13 +0000 (14:36 +0000)]
Bump version to 3.0.14 UNRELEASED.
Fabian Keil [Sun, 14 Jun 2009 14:35:42 +0000 (14:35 +0000)]
Remove CVS $Log entries.
Fabian Keil [Sun, 14 Jun 2009 14:33:01 +0000 (14:33 +0000)]
Fix a tokenize() regression that caused it to miss tokens with trailing comments.
This it turn caused Privoxy-Regression-Test to always execute a test
that should only be executed if enable-edit-actions is enabled.
Looks like we need a Privoxy-Regression-Test-Regression-Test.
hal9 [Sat, 13 Jun 2009 13:56:22 +0000 (13:56 +0000)]
Rebuild for 3.0.13
Fabian Keil [Sat, 13 Jun 2009 13:10:49 +0000 (13:10 +0000)]
Rebuild for 3.0.13 beta.
Fabian Keil [Sat, 13 Jun 2009 12:40:44 +0000 (12:40 +0000)]
Update for 3.0.13 beta.
Fabian Keil [Sat, 13 Jun 2009 12:32:17 +0000 (12:32 +0000)]
Update for 3.0.13 beta.
Fabian Keil [Sat, 13 Jun 2009 11:37:07 +0000 (11:37 +0000)]
connect_to() doesn't return void, so the recently added malloc check shouldn't either.
Fabian Keil [Sat, 13 Jun 2009 11:32:52 +0000 (11:32 +0000)]
A bunch of malloc() return code checks for the HAVE_RFC2553 code.
Fabian Keil [Fri, 12 Jun 2009 14:43:50 +0000 (14:43 +0000)]
Manually merge latest updates.
Fabian Keil [Fri, 12 Jun 2009 14:34:10 +0000 (14:34 +0000)]
Rebuilt with recent changes.
Fabian Keil [Fri, 12 Jun 2009 14:33:34 +0000 (14:33 +0000)]
Rebuilt for 3.0.13 beta.
Fabian Keil [Fri, 12 Jun 2009 14:30:59 +0000 (14:30 +0000)]
Update entities for 3.0.13 beta.
Fabian Keil [Fri, 12 Jun 2009 13:39:02 +0000 (13:39 +0000)]
Tell crunch_reason() about RSP_REASON_NO_SERVER_DATA.
Fabian Keil [Fri, 12 Jun 2009 11:53:33 +0000 (11:53 +0000)]
Mention that sharing connections increases the changes of connection problems.
Fabian Keil [Fri, 12 Jun 2009 11:52:33 +0000 (11:52 +0000)]
Mention the TODO list in the participate entry.
Fabian Keil [Fri, 12 Jun 2009 11:51:58 +0000 (11:51 +0000)]
Update "Support and Service" section to contain links to the participate and donate FAQ entries.
Fabian Keil [Fri, 12 Jun 2009 11:04:47 +0000 (11:04 +0000)]
Change code status to beta.
Fabian Keil [Fri, 12 Jun 2009 11:04:13 +0000 (11:04 +0000)]
Import ChangeLog for 3.0.13 beta.
Fabian Keil [Fri, 12 Jun 2009 11:03:03 +0000 (11:03 +0000)]
Remove a now-redundant err check.
Fabian Keil [Thu, 11 Jun 2009 18:29:13 +0000 (18:29 +0000)]
Remove useless comment.
Fabian Keil [Thu, 11 Jun 2009 14:32:55 +0000 (14:32 +0000)]
White-space fixes.
Fabian Keil [Thu, 11 Jun 2009 14:26:40 +0000 (14:26 +0000)]
Mention IPv6 support, update keep-alive description, remove "cookie management" section.
David Schmidt [Thu, 11 Jun 2009 14:13:19 +0000 (14:13 +0000)]
Protect a keepalive flag inside FEATURE_CONNECTION_KEEP_ALIVE ifdef
Fabian Keil [Thu, 11 Jun 2009 14:07:15 +0000 (14:07 +0000)]
Enlist Petr Písar who contributed the IPv6 code,
spelling the name as good as I seem to be able to
without messing up the encoding.
Fabian Keil [Thu, 11 Jun 2009 13:57:01 +0000 (13:57 +0000)]
Move Jörg to the former team members section.
Fabian Keil [Thu, 11 Jun 2009 12:19:20 +0000 (12:19 +0000)]
Change code status to beta.
Fabian Keil [Thu, 11 Jun 2009 12:16:02 +0000 (12:16 +0000)]
Add recently added cgi templates.
Fabian Keil [Thu, 11 Jun 2009 12:13:51 +0000 (12:13 +0000)]
Bump version for 3.0.13 beta.
Fabian Keil [Thu, 11 Jun 2009 12:10:09 +0000 (12:10 +0000)]
Update for 3.0.13 beta.
Fabian Keil [Thu, 11 Jun 2009 11:49:11 +0000 (11:49 +0000)]
Send a template-based response in case of prematurely closed connections.
Fabian Keil [Thu, 11 Jun 2009 11:47:16 +0000 (11:47 +0000)]
In error_response(), factor the (rsp->status == NULL) checks out of the if blocks.
Fabian Keil [Thu, 11 Jun 2009 11:46:22 +0000 (11:46 +0000)]
Send a template-based response in case of server connection timeouts.
Fabian Keil [Thu, 11 Jun 2009 11:44:25 +0000 (11:44 +0000)]
Remove error_response()'s third parameter. None of the templates use it.
David Schmidt [Wed, 10 Jun 2009 22:36:01 +0000 (22:36 +0000)]
OSX doesn't define AI_NUMERICSERV
Fabian Keil [Wed, 10 Jun 2009 16:38:08 +0000 (16:38 +0000)]
Remove check_for_curl() as using 'which' isn't portable.
If curl turns out to be missing, we now simply die a bit later.
Fabian Keil [Wed, 10 Jun 2009 13:17:17 +0000 (13:17 +0000)]
Let extended hostname patterns without trailing dots cover hostnames with trailing dot as well.
The old-school pattern code already does that as a side effect
of treating dots as delimiters instead of real characters.
Fabian Keil [Wed, 10 Jun 2009 13:15:35 +0000 (13:15 +0000)]
Add tests for trailing dots in hostnames.
Fabian Keil [Wed, 10 Jun 2009 12:50:15 +0000 (12:50 +0000)]
Factor create_content_length_header() out of server_adjust_content_length().
Fabian Keil [Mon, 8 Jun 2009 17:22:52 +0000 (17:22 +0000)]
Ignore: Content modified with no Content-Length header set. Creating a fake one for adjustment later on.
Fabian Keil [Mon, 8 Jun 2009 16:50:35 +0000 (16:50 +0000)]
The fflush() argument is a pointer. Don't use 0 instead of NULL.
Fabian Keil [Mon, 8 Jun 2009 16:48:50 +0000 (16:48 +0000)]
Don't leak parts of the client headers if a timeout is triggered while reading the request.
Fabian Keil [Mon, 8 Jun 2009 16:48:09 +0000 (16:48 +0000)]
Here's a fresh idea, why don't we respect taboos unless we're asked not to?
Fabian Keil [Mon, 8 Jun 2009 16:47:07 +0000 (16:47 +0000)]
Don't force the client to wait for the connection to timeout if we
modified the content, the client asked for keep-alive and there's
no Content-Length header present.
Fabian Keil [Fri, 5 Jun 2009 18:58:26 +0000 (18:58 +0000)]
Let subs work with the test hash directly, there's no need to use a local copy.
Fabian Keil [Fri, 5 Jun 2009 16:55:16 +0000 (16:55 +0000)]
Document the 6 mysterious bytes we skip in decompress_iob().
Fabian Keil [Fri, 5 Jun 2009 16:54:27 +0000 (16:54 +0000)]
Remove stray empty line.
Fabian Keil [Fri, 5 Jun 2009 16:53:55 +0000 (16:53 +0000)]
Use macros for the magic numbers in decompress_iob().
Fabian Keil [Wed, 3 Jun 2009 18:49:18 +0000 (18:49 +0000)]
Item "33) Remove the CVS Log message junk from the C files" is done.
Fabian Keil [Wed, 3 Jun 2009 18:30:18 +0000 (18:30 +0000)]
Explicitly mention that the config file can be edited with a text editor and name a few examples.
As #
2782881 reminds us, Windows users aren't generally used to changing configuration files that way.
Fabian Keil [Wed, 3 Jun 2009 16:44:41 +0000 (16:44 +0000)]
Factor path_matches() out of url_match().
Fabian Keil [Wed, 3 Jun 2009 16:44:15 +0000 (16:44 +0000)]
Factor host_matches() out of url_match().
Fabian Keil [Wed, 3 Jun 2009 16:43:50 +0000 (16:43 +0000)]
Factor port_matches() out of url_match().
Fabian Keil [Wed, 3 Jun 2009 16:43:16 +0000 (16:43 +0000)]
Fix comment spelling.
Fabian Keil [Wed, 3 Jun 2009 16:42:49 +0000 (16:42 +0000)]
Streamline struct http_request if FEATURE_EXTENDED_HOST_PATTERNS is enabled.
Fabian Keil [Mon, 1 Jun 2009 16:34:48 +0000 (16:34 +0000)]
If all the data we got decompressed OK, but zlib wants more, filter what we got instead of forwarding the unfiltered compressed content.
Fabian Keil [Mon, 1 Jun 2009 15:33:33 +0000 (15:33 +0000)]
In decompress_iob(), remove the skip_bytes history lesson and remove an unnecessary and incorrect assert().
Fabian Keil [Mon, 1 Jun 2009 15:14:40 +0000 (15:14 +0000)]
Style fix.
Fabian Keil [Mon, 1 Jun 2009 14:18:49 +0000 (14:18 +0000)]
In client_if_modified_since(), rename negative to negative_range.
Fabian Keil [Mon, 1 Jun 2009 14:18:04 +0000 (14:18 +0000)]
In server_last_modified(), rename negative to negative_delta.
Fabian Keil [Mon, 1 Jun 2009 13:22:56 +0000 (13:22 +0000)]
Factor get_skip_reason() out of execute_regression_tests().
Fabian Keil [Mon, 1 Jun 2009 13:16:36 +0000 (13:16 +0000)]
In check_for_forbidden_characters(), don't allow line breaks.
Specifying them is currently not possible and makes no sense anyway.
Fabian Keil [Mon, 1 Jun 2009 10:49:07 +0000 (10:49 +0000)]
In load_regression_tests(), catch-last minute config file changes
by requesting the config file twice and discarding the result of
the first request.
Fabian Keil [Thu, 28 May 2009 21:38:13 +0000 (21:38 +0000)]
Two additional hide-if-modified-since{} tests created while debugging #
2797798.
As it turns out they don't actually cause any problems,
but at least in theory they could be edge cases and are
thus test-worthy.
Fabian Keil [Thu, 28 May 2009 21:13:34 +0000 (21:13 +0000)]
Unbreak compilation for compilers that don't recognize lone defs.
Reported by Lee.
Fabian Keil [Thu, 28 May 2009 18:42:30 +0000 (18:42 +0000)]
Turn server_proxy_connection_adder() into a nop if the client didn't request keep-alive.
Fabian Keil [Thu, 28 May 2009 17:26:04 +0000 (17:26 +0000)]
Improve code clarity by factoring log_and_die() out of l().
Fabian Keil [Thu, 28 May 2009 17:07:42 +0000 (17:07 +0000)]
Check the right macro to decide if we can use privoxy_mutex_lock().
Should fix the crash-while-randomizing-header-dates bug on mingw32
anonymously reported in #
2797798. This is pretty much the same bug
that was already fixed in 3.0.7, but apparently I found a way to
reintroduce it in 3.0.11. Yeehaw.
Fabian Keil [Wed, 27 May 2009 20:46:25 +0000 (20:46 +0000)]
Reject unknown dependencies.
Fabian Keil [Wed, 27 May 2009 20:45:31 +0000 (20:45 +0000)]
Due to a bug in dependency_unsatisfied(), tests were executed as long as the first config-line dependency registered didn't match the first directive in the config file.
It "worked" so far, because until recently we only had a single
config-line dependency and only had to check the user-manual
directive, which usually is the first one.
And there I was rewriting client_connection() from scratch,
puzzled that the stupid connection-sharing tests would still
fail.
Fabian Keil [Wed, 27 May 2009 20:37:15 +0000 (20:37 +0000)]
Make sure we upgrade the client connection header if connection-sharing is enabled, and that we don't if it isn't.
Fabian Keil [Mon, 25 May 2009 21:27:19 +0000 (21:27 +0000)]
Unblock iTunes download links. Anonymously reported in AF#
2789653.
Fabian Keil [Mon, 25 May 2009 19:37:43 +0000 (19:37 +0000)]
Unbreak elsif condition.
Fabian Keil [Mon, 25 May 2009 19:33:08 +0000 (19:33 +0000)]
Streamline elsif condition. White space fixes.
Fabian Keil [Mon, 25 May 2009 19:11:03 +0000 (19:11 +0000)]
Highlight: Could not connect to [10.0.0.1]:80.
Fabian Keil [Mon, 25 May 2009 15:43:34 +0000 (15:43 +0000)]
Downgrade another log message in connect_to() to LOG_LEVEL_CONNECT.
Fabian Keil [Mon, 25 May 2009 15:42:40 +0000 (15:42 +0000)]
In client_connection_header_adder(), check flags against csp->flags directly.
Fabian Keil [Mon, 25 May 2009 15:41:52 +0000 (15:41 +0000)]
Keep the server header 'Connection: keep-alive' around if the client implied keep-alive my not setting any Connection header.
Fabian Keil [Mon, 25 May 2009 15:40:52 +0000 (15:40 +0000)]
If we are keeping the server connection alive behind the client's back, make sure the client sees a "Connection: close" header.
Fabian Keil [Tue, 19 May 2009 18:02:03 +0000 (18:02 +0000)]
Doh. Unbreak extra field skipping in decompress_iob().
Pointed out by clang, initially fat-fingered by me.
Fabian Keil [Tue, 19 May 2009 17:52:03 +0000 (17:52 +0000)]
Fix a recently added logic error that could result in keep_alive_timeout being read uninitialized.
Detected by clang. Pointy hat to me.
Fabian Keil [Tue, 19 May 2009 17:48:58 +0000 (17:48 +0000)]
Fix clang warning: Value stored to 'timeptr' is never read.
Fabian Keil [Tue, 19 May 2009 17:47:22 +0000 (17:47 +0000)]
Fix clang warning: Value stored to ch is never read.
Fabian Keil [Tue, 19 May 2009 17:46:24 +0000 (17:46 +0000)]
Fix clang warning: Value stored to 'err' is never read.
We don't need to check the return value because we're
detecting errors with the (NULL == filename) check.
Fabian Keil [Tue, 19 May 2009 17:45:31 +0000 (17:45 +0000)]
Help clang understand that we aren't dereferencing a NULL pointer here.
Fabian Keil [Tue, 19 May 2009 17:44:54 +0000 (17:44 +0000)]
Fix clang warning: Value stored to 'i' is never read.
Fabian Keil [Tue, 19 May 2009 17:44:22 +0000 (17:44 +0000)]
Fix clang warning: Value stored to 'hits' is never read.
Fabian Keil [Tue, 19 May 2009 17:43:45 +0000 (17:43 +0000)]
Fix clang warning: Value stored to 'err' is never read.
Fabian Keil [Tue, 19 May 2009 17:42:32 +0000 (17:42 +0000)]
Fix clang warning: Although the value stored to k is used
in the enclosing expression, the value is never actually
read from k.
Fabian Keil [Tue, 19 May 2009 17:40:36 +0000 (17:40 +0000)]
Style fix.
Fabian Keil [Tue, 19 May 2009 17:39:59 +0000 (17:39 +0000)]
Fix clang warning: Although the value stored to 'next'
is used in the enclosing expression, the value is never
actually read from 'next'.
Fabian Keil [Tue, 19 May 2009 17:27:05 +0000 (17:27 +0000)]
Fix keep-alive upgrading if connection-sharing is used.