privoxy.git
15 years agoFix comment spelling.
Fabian Keil [Wed, 3 Jun 2009 16:43:16 +0000 (16:43 +0000)]
Fix comment spelling.

15 years agoStreamline struct http_request if FEATURE_EXTENDED_HOST_PATTERNS is enabled.
Fabian Keil [Wed, 3 Jun 2009 16:42:49 +0000 (16:42 +0000)]
Streamline struct http_request if FEATURE_EXTENDED_HOST_PATTERNS is enabled.

15 years agoIf all the data we got decompressed OK, but zlib wants more, filter what we got inste...
Fabian Keil [Mon, 1 Jun 2009 16:34:48 +0000 (16:34 +0000)]
If all the data we got decompressed OK, but zlib wants more, filter what we got instead of forwarding the unfiltered compressed content.

15 years agoIn decompress_iob(), remove the skip_bytes history lesson and remove an unnecessary...
Fabian Keil [Mon, 1 Jun 2009 15:33:33 +0000 (15:33 +0000)]
In decompress_iob(), remove the skip_bytes history lesson and remove an unnecessary and incorrect assert().

15 years agoStyle fix.
Fabian Keil [Mon, 1 Jun 2009 15:14:40 +0000 (15:14 +0000)]
Style fix.

15 years agoIn client_if_modified_since(), rename negative to negative_range.
Fabian Keil [Mon, 1 Jun 2009 14:18:49 +0000 (14:18 +0000)]
In client_if_modified_since(), rename negative to negative_range.

15 years agoIn server_last_modified(), rename negative to negative_delta.
Fabian Keil [Mon, 1 Jun 2009 14:18:04 +0000 (14:18 +0000)]
In server_last_modified(), rename negative to negative_delta.

15 years agoFactor get_skip_reason() out of execute_regression_tests().
Fabian Keil [Mon, 1 Jun 2009 13:22:56 +0000 (13:22 +0000)]
Factor get_skip_reason() out of execute_regression_tests().

15 years agoIn check_for_forbidden_characters(), don't allow line breaks.
Fabian Keil [Mon, 1 Jun 2009 13:16:36 +0000 (13:16 +0000)]
In check_for_forbidden_characters(), don't allow line breaks.
Specifying them is currently not possible and makes no sense anyway.

15 years agoIn load_regression_tests(), catch-last minute config file changes
Fabian Keil [Mon, 1 Jun 2009 10:49:07 +0000 (10:49 +0000)]
In load_regression_tests(), catch-last minute config file changes
by requesting the config file twice and discarding the result of
the first request.

15 years agoTwo additional hide-if-modified-since{} tests created while debugging #2797798.
Fabian Keil [Thu, 28 May 2009 21:38:13 +0000 (21:38 +0000)]
Two additional hide-if-modified-since{} tests created while debugging #2797798.

As it turns out they don't actually cause any problems,
but at least in theory they could be edge cases and are
thus test-worthy.

15 years agoUnbreak compilation for compilers that don't recognize lone defs.
Fabian Keil [Thu, 28 May 2009 21:13:34 +0000 (21:13 +0000)]
Unbreak compilation for compilers that don't recognize lone defs.
Reported by Lee.

15 years agoTurn server_proxy_connection_adder() into a nop if the client didn't request keep...
Fabian Keil [Thu, 28 May 2009 18:42:30 +0000 (18:42 +0000)]
Turn server_proxy_connection_adder() into a nop if the client didn't request keep-alive.

15 years agoImprove code clarity by factoring log_and_die() out of l().
Fabian Keil [Thu, 28 May 2009 17:26:04 +0000 (17:26 +0000)]
Improve code clarity by factoring log_and_die() out of l().

15 years agoCheck the right macro to decide if we can use privoxy_mutex_lock().
Fabian Keil [Thu, 28 May 2009 17:07:42 +0000 (17:07 +0000)]
Check the right macro to decide if we can use privoxy_mutex_lock().

Should fix the crash-while-randomizing-header-dates bug on mingw32
anonymously reported in #2797798. This is pretty much the same bug
that was already fixed in 3.0.7, but apparently I found a way to
reintroduce it in 3.0.11. Yeehaw.

15 years agoReject unknown dependencies.
Fabian Keil [Wed, 27 May 2009 20:46:25 +0000 (20:46 +0000)]
Reject unknown dependencies.

15 years agoDue to a bug in dependency_unsatisfied(), tests were executed as long as the first...
Fabian Keil [Wed, 27 May 2009 20:45:31 +0000 (20:45 +0000)]
Due to a bug in dependency_unsatisfied(), tests were executed as long as the first config-line dependency registered didn't match the first directive in the config file.

It "worked" so far, because until recently we only had a single
config-line dependency and only had to check the user-manual
directive, which usually is the first one.

And there I was rewriting client_connection() from scratch,
puzzled that the stupid connection-sharing tests would still
fail.

15 years agoMake sure we upgrade the client connection header if connection-sharing is enabled...
Fabian Keil [Wed, 27 May 2009 20:37:15 +0000 (20:37 +0000)]
Make sure we upgrade the client connection header if connection-sharing is enabled, and that we don't if it isn't.

15 years agoUnblock iTunes download links. Anonymously reported in AF#2789653.
Fabian Keil [Mon, 25 May 2009 21:27:19 +0000 (21:27 +0000)]
Unblock iTunes download links. Anonymously reported in AF#2789653.

15 years agoUnbreak elsif condition.
Fabian Keil [Mon, 25 May 2009 19:37:43 +0000 (19:37 +0000)]
Unbreak elsif condition.

15 years agoStreamline elsif condition. White space fixes.
Fabian Keil [Mon, 25 May 2009 19:33:08 +0000 (19:33 +0000)]
Streamline elsif condition. White space fixes.

15 years agoHighlight: Could not connect to [10.0.0.1]:80.
Fabian Keil [Mon, 25 May 2009 19:11:03 +0000 (19:11 +0000)]
Highlight: Could not connect to [10.0.0.1]:80.

15 years agoDowngrade another log message in connect_to() to LOG_LEVEL_CONNECT.
Fabian Keil [Mon, 25 May 2009 15:43:34 +0000 (15:43 +0000)]
Downgrade another log message in connect_to() to LOG_LEVEL_CONNECT.

15 years agoIn client_connection_header_adder(), check flags against csp->flags directly.
Fabian Keil [Mon, 25 May 2009 15:42:40 +0000 (15:42 +0000)]
In client_connection_header_adder(), check flags against csp->flags directly.

15 years agoKeep the server header 'Connection: keep-alive' around if the client implied keep...
Fabian Keil [Mon, 25 May 2009 15:41:52 +0000 (15:41 +0000)]
Keep the server header 'Connection: keep-alive' around if the client implied keep-alive my not setting any Connection header.

15 years agoIf we are keeping the server connection alive behind the client's back, make sure...
Fabian Keil [Mon, 25 May 2009 15:40:52 +0000 (15:40 +0000)]
If we are keeping the server connection alive behind the client's back, make sure the client sees a "Connection: close" header.

15 years agoDoh. Unbreak extra field skipping in decompress_iob().
Fabian Keil [Tue, 19 May 2009 18:02:03 +0000 (18:02 +0000)]
Doh. Unbreak extra field skipping in decompress_iob().
Pointed out by clang, initially fat-fingered by me.

15 years agoFix a recently added logic error that could result in keep_alive_timeout being read...
Fabian Keil [Tue, 19 May 2009 17:52:03 +0000 (17:52 +0000)]
Fix a recently added logic error that could result in keep_alive_timeout being read uninitialized.
Detected by clang. Pointy hat to me.

15 years agoFix clang warning: Value stored to 'timeptr' is never read.
Fabian Keil [Tue, 19 May 2009 17:48:58 +0000 (17:48 +0000)]
Fix clang warning: Value stored to 'timeptr' is never read.

15 years agoFix clang warning: Value stored to ch is never read.
Fabian Keil [Tue, 19 May 2009 17:47:22 +0000 (17:47 +0000)]
Fix clang warning: Value stored to ch is never read.

15 years agoFix clang warning: Value stored to 'err' is never read.
Fabian Keil [Tue, 19 May 2009 17:46:24 +0000 (17:46 +0000)]
Fix clang warning: Value stored to 'err' is never read.
We don't need to check the return value because we're
detecting errors with the (NULL == filename) check.

15 years agoHelp clang understand that we aren't dereferencing a NULL pointer here.
Fabian Keil [Tue, 19 May 2009 17:45:31 +0000 (17:45 +0000)]
Help clang understand that we aren't dereferencing a NULL pointer here.

15 years agoFix clang warning: Value stored to 'i' is never read.
Fabian Keil [Tue, 19 May 2009 17:44:54 +0000 (17:44 +0000)]
Fix clang warning: Value stored to 'i' is never read.

15 years agoFix clang warning: Value stored to 'hits' is never read.
Fabian Keil [Tue, 19 May 2009 17:44:22 +0000 (17:44 +0000)]
Fix clang warning: Value stored to 'hits' is never read.

15 years agoFix clang warning: Value stored to 'err' is never read.
Fabian Keil [Tue, 19 May 2009 17:43:45 +0000 (17:43 +0000)]
Fix clang warning: Value stored to 'err' is never read.

15 years agoFix clang warning: Although the value stored to k is used
Fabian Keil [Tue, 19 May 2009 17:42:32 +0000 (17:42 +0000)]
Fix clang warning: Although the value stored to k is used
in the enclosing expression, the value is never actually
read from k.

15 years agoStyle fix.
Fabian Keil [Tue, 19 May 2009 17:40:36 +0000 (17:40 +0000)]
Style fix.

15 years agoFix clang warning: Although the value stored to 'next'
Fabian Keil [Tue, 19 May 2009 17:39:59 +0000 (17:39 +0000)]
Fix clang warning: Although the value stored to 'next'
is used in the enclosing expression, the value is never
actually read from 'next'.

15 years agoFix keep-alive upgrading if connection-sharing is used.
Fabian Keil [Tue, 19 May 2009 17:27:05 +0000 (17:27 +0000)]
Fix keep-alive upgrading if connection-sharing is used.

15 years agoHighlight: Connected to tor-jail[10.0.0.2]:9050.
Fabian Keil [Tue, 19 May 2009 17:22:34 +0000 (17:22 +0000)]
Highlight: Connected to tor-jail[10.0.0.2]:9050.

15 years agoStyle fixes for the last commit. Also downgrade some log
Fabian Keil [Tue, 19 May 2009 17:20:35 +0000 (17:20 +0000)]
Style fixes for the last commit. Also downgrade some log
levels, ditch the TCP/ prefix and add trailing periods.

15 years agoIn connect_to(), try multiple addresses if possible and necessary.
Fabian Keil [Tue, 19 May 2009 17:18:52 +0000 (17:18 +0000)]
In connect_to(), try multiple addresses if possible and necessary.
Closes #2790891. Problem reported and patch provided by Petr Pisar.

15 years agocheck_for_forbidden_characters() cosmetics:
Fabian Keil [Tue, 19 May 2009 14:45:16 +0000 (14:45 +0000)]
check_for_forbidden_characters() cosmetics:
- Don't unnecessarily escape '?' and '/' inside the character class.
- Use a more appropriate variable name.
- Compile the regex only once. While it doesn't matter, it doesn't hurt either.

15 years agoRemove CVS revision logs. TODO item #33.
Fabian Keil [Sat, 16 May 2009 13:27:21 +0000 (13:27 +0000)]
Remove CVS revision logs. TODO item #33.

15 years agoAdd the TODO list proposed on ijbswa-developers@,
Fabian Keil [Sat, 16 May 2009 11:28:08 +0000 (11:28 +0000)]
Add the TODO list proposed on ijbswa-developers@,
minus some items that have been committed already.

15 years ago- Don't let --verbose imply --show-skipped-tests. It's just
Fabian Keil [Fri, 15 May 2009 20:26:55 +0000 (20:26 +0000)]
- Don't let --verbose imply --show-skipped-tests. It's just
  too annoying when we're only interested in a few tests.
- White space cosmetics.

15 years agoPerldoc spelling fix.
Fabian Keil [Fri, 15 May 2009 19:21:44 +0000 (19:21 +0000)]
Perldoc spelling fix.

15 years agoIf the new keep-alive code is enabled, Keep-Alive headers are passed.
Fabian Keil [Wed, 13 May 2009 19:26:22 +0000 (19:26 +0000)]
If the new keep-alive code is enabled, Keep-Alive headers are passed.

15 years agoHighlight log messages from server_keep_alive().
Fabian Keil [Wed, 13 May 2009 18:24:11 +0000 (18:24 +0000)]
Highlight log messages from server_keep_alive().

15 years agoRespect the server's keep-alive value if it's below ours.
Fabian Keil [Wed, 13 May 2009 18:22:45 +0000 (18:22 +0000)]
Respect the server's keep-alive value if it's below ours.

15 years agoThere's no reason for keep_alive_timeout to be signed.
Fabian Keil [Wed, 13 May 2009 18:20:54 +0000 (18:20 +0000)]
There's no reason for keep_alive_timeout to be signed.

15 years agoSurprised adjuggler.com hasn't been flagged before now
Lee [Sun, 10 May 2009 17:53:07 +0000 (17:53 +0000)]
Surprised adjuggler.com hasn't been flagged before now

15 years agoChange wait_for_alive_connection() prototype to use (void).
Fabian Keil [Sun, 10 May 2009 10:25:19 +0000 (10:25 +0000)]
Change wait_for_alive_connection() prototype to use (void).

15 years agoRegenerate with connection-sharing and max-client-connections.
Fabian Keil [Sun, 10 May 2009 10:21:13 +0000 (10:21 +0000)]
Regenerate with connection-sharing and max-client-connections.

15 years agoDeal with the log messages for client socket keep-alive support.
Fabian Keil [Sun, 10 May 2009 10:20:09 +0000 (10:20 +0000)]
Deal with the log messages for client socket keep-alive support.

15 years agoReenable server-side-only keep-alive support, but only share
Fabian Keil [Sun, 10 May 2009 10:19:23 +0000 (10:19 +0000)]
Reenable server-side-only keep-alive support, but only share
outgoing connections if the connection-sharing option is set.

15 years agoInitial keep-alive support for the client socket.
Fabian Keil [Sun, 10 May 2009 10:12:30 +0000 (10:12 +0000)]
Initial keep-alive support for the client socket.
Temporarily disable the server-side-only keep-alive code.

15 years agoallow lads.myspacecdn.com
Lee [Fri, 8 May 2009 06:59:18 +0000 (06:59 +0000)]
allow lads.myspacecdn.com
fixes tracker item 2786745 : MySpace music player doesn't work

15 years agoProperly highlight LOG_LEVEL_CLF messages with IPv6 addresses.
Fabian Keil [Fri, 1 May 2009 11:04:19 +0000 (11:04 +0000)]
Properly highlight LOG_LEVEL_CLF messages with IPv6 addresses.

15 years agoIgnore nested comments in tokenize().
Fabian Keil [Fri, 1 May 2009 11:03:11 +0000 (11:03 +0000)]
Ignore nested comments in tokenize().

15 years agoModify for smartadserver.com per Actionsfile feedback item #2781461.
hal9 [Sun, 26 Apr 2009 12:59:59 +0000 (12:59 +0000)]
Modify for smartadserver.com per Actionsfile feedback item #2781461.

15 years agoAllow to limit the number of of client connections.
Fabian Keil [Fri, 24 Apr 2009 15:29:43 +0000 (15:29 +0000)]
Allow to limit the number of of client connections.

15 years agoUse a real miscellaneous section instead of misusing the forwarding section.
Fabian Keil [Sun, 19 Apr 2009 17:39:55 +0000 (17:39 +0000)]
Use a real miscellaneous section instead of misusing the forwarding section.

15 years agoRegenerated with the IPv6 changes.
Fabian Keil [Fri, 17 Apr 2009 13:27:06 +0000 (13:27 +0000)]
Regenerated with the IPv6 changes.

15 years agoDocs regenerated with the IPv6 changes.
Fabian Keil [Fri, 17 Apr 2009 13:11:18 +0000 (13:11 +0000)]
Docs regenerated with the IPv6 changes.

15 years agoAdvertise IPv6 support on the show-status page.
Fabian Keil [Fri, 17 Apr 2009 11:47:40 +0000 (11:47 +0000)]
Advertise IPv6 support on the show-status page.

15 years agoReplace HAVE_GETADDRINFO and HAVE_GETNAMEINFO macros
Fabian Keil [Fri, 17 Apr 2009 11:45:19 +0000 (11:45 +0000)]
Replace HAVE_GETADDRINFO and HAVE_GETNAMEINFO macros
with HAVE_RFC2553 macro. Original patch by Petr Pisar.

15 years agoFix IPv4-mapped IPv6 prefix. Patch by Petr Pisar.
Fabian Keil [Fri, 17 Apr 2009 11:42:07 +0000 (11:42 +0000)]
Fix IPv4-mapped IPv6 prefix. Patch by Petr Pisar.

15 years agoIn the listen-address description, be more specific
Fabian Keil [Fri, 17 Apr 2009 11:40:48 +0000 (11:40 +0000)]
In the listen-address description, be more specific
about the requested IP version.

15 years agoIf the hostname is 'localhost' or not specified, request an AF_INET address.
Fabian Keil [Fri, 17 Apr 2009 11:39:52 +0000 (11:39 +0000)]
If the hostname is 'localhost' or not specified, request an AF_INET address.

15 years agoAdd and use parse_forwarder_address() to reduce code duplication.
Fabian Keil [Fri, 17 Apr 2009 11:38:28 +0000 (11:38 +0000)]
Add and use parse_forwarder_address() to reduce code duplication.

15 years agoAllow IPv6 addresses in forward-override{}.
Fabian Keil [Fri, 17 Apr 2009 11:37:03 +0000 (11:37 +0000)]
Allow IPv6 addresses in forward-override{}.

15 years agoFix compiler warning.
Fabian Keil [Fri, 17 Apr 2009 11:35:28 +0000 (11:35 +0000)]
Fix compiler warning.

15 years agoStyle cosmetics for the IPv6 code.
Fabian Keil [Fri, 17 Apr 2009 11:34:35 +0000 (11:34 +0000)]
Style cosmetics for the IPv6 code.

15 years agoGrammar and spelling fixes.
Fabian Keil [Fri, 17 Apr 2009 11:32:57 +0000 (11:32 +0000)]
Grammar and spelling fixes.

15 years agoRemove trailing whitespace.
Fabian Keil [Fri, 17 Apr 2009 11:31:48 +0000 (11:31 +0000)]
Remove trailing whitespace.

15 years agoGrammar and spelling fixes.
Fabian Keil [Fri, 17 Apr 2009 11:30:55 +0000 (11:30 +0000)]
Grammar and spelling fixes.

15 years agoCompile fix for BSD libc.
Fabian Keil [Fri, 17 Apr 2009 11:29:18 +0000 (11:29 +0000)]
Compile fix for BSD libc.

15 years agoPetr Pisar's privoxy-3.0.12-ipv6-3.diff.
Fabian Keil [Fri, 17 Apr 2009 11:27:49 +0000 (11:27 +0000)]
Petr Pisar's privoxy-3.0.12-ipv6-3.diff.

15 years agoAdd regression test for the previous commit.
Fabian Keil [Thu, 16 Apr 2009 16:12:44 +0000 (16:12 +0000)]
Add regression test for the previous commit.

15 years agoVideos don't play on cnn.com per Actionsfile tracker.
hal9 [Thu, 16 Apr 2009 00:03:24 +0000 (00:03 +0000)]
Videos don't play on cnn.com per Actionsfile tracker.

15 years agoUpdate a comment. We're not in Kansas anymore.
Fabian Keil [Sat, 11 Apr 2009 10:44:47 +0000 (10:44 +0000)]
Update a comment. We're not in Kansas anymore.

15 years agoWhen dropping connections due to ACL, don't leak csp->ip_addr_str.
Fabian Keil [Sat, 11 Apr 2009 10:37:23 +0000 (10:37 +0000)]
When dropping connections due to ACL, don't leak csp->ip_addr_str.

15 years agoFix two cases in which an invalid server response would result
Fabian Keil [Thu, 9 Apr 2009 10:12:54 +0000 (10:12 +0000)]
Fix two cases in which an invalid server response would result
in the client connection being closed without sending an error
message first.

15 years agoIn the "I would like to help ..." entry:
Fabian Keil [Tue, 7 Apr 2009 12:25:05 +0000 (12:25 +0000)]
In the "I would like to help ..." entry:
- Change the ids to more general ones as helping out doesn't require
  joining the team (and joining the team requires significantly helping
  out first, anyway).
- Add links to the subscription pages for the main mailing lists.

15 years agoIf the server rudely resets the connection directly after sending the
Fabian Keil [Tue, 7 Apr 2009 11:43:50 +0000 (11:43 +0000)]
If the server rudely resets the connection directly after sending the
headers, pass the mess to the client instead of sending an incorrect
connect-failed message. Fixes #2698674 reported by mybugaccount.

15 years agoPut some headers in error messages in single quotes.
Fabian Keil [Sun, 5 Apr 2009 19:01:19 +0000 (19:01 +0000)]
Put some headers in error messages in single quotes.

15 years agoLet the clean target play nice with git.
Fabian Keil [Sat, 4 Apr 2009 20:24:29 +0000 (20:24 +0000)]
Let the clean target play nice with git.

15 years agoFix whitespace.
Fabian Keil [Sat, 4 Apr 2009 18:13:51 +0000 (18:13 +0000)]
Fix whitespace.

15 years agoBlock awin1.com, ad generator per Actionsfile feedback.
hal9 [Wed, 1 Apr 2009 22:52:33 +0000 (22:52 +0000)]
Block awin1.com, ad generator per Actionsfile feedback.

15 years agoRecommend the use of forward-socks5 when forwarding to Tor.
Fabian Keil [Sat, 28 Mar 2009 15:33:41 +0000 (15:33 +0000)]
Recommend the use of forward-socks5 when forwarding to Tor.
The error messages are more detailed than with forward-socks4a.

15 years agoCorrect the status code for CONNECTION_TIMEOUT_RESPONSE.
Fabian Keil [Fri, 27 Mar 2009 14:42:30 +0000 (14:42 +0000)]
Correct the status code for CONNECTION_TIMEOUT_RESPONSE.

15 years agoIf spawning a child in listen_loop() fails, send a real
Fabian Keil [Fri, 27 Mar 2009 14:32:04 +0000 (14:32 +0000)]
If spawning a child in listen_loop() fails, send a real
HTTP response to the client and continue listening for
new connections without artificial delay.

15 years agomerge Debian changes from 3.0.10 to 3.0.12.
Roland Rosenfeld [Wed, 25 Mar 2009 21:02:10 +0000 (21:02 +0000)]
merge Debian changes from 3.0.10 to 3.0.12.

15 years agoIn serve(), keep the client socket open until we marked the
Fabian Keil [Wed, 25 Mar 2009 17:30:30 +0000 (17:30 +0000)]
In serve(), keep the client socket open until we marked the
server socket as unused. This should increase the chances
that we reuse the connection for the client's next request
to the same destination.

15 years agoAnd they are running again. Bump version to 3.0.13 UNRELEASED.
Fabian Keil [Wed, 25 Mar 2009 17:26:31 +0000 (17:26 +0000)]
And they are running again. Bump version to 3.0.13 UNRELEASED.

15 years agoget rid of
Lee [Tue, 24 Mar 2009 12:20:39 +0000 (12:20 +0000)]
get rid of
Error: handle-as-empty-document overruled by handle-as-image.

15 years agorecommend logging crunches
Lee [Mon, 23 Mar 2009 04:17:47 +0000 (04:17 +0000)]
recommend logging crunches

15 years agoOh well, at least the ChangeLog consumers got it right ...
Fabian Keil [Sat, 21 Mar 2009 22:13:58 +0000 (22:13 +0000)]
Oh well, at least the ChangeLog consumers got it right ...

15 years ago- Mention that we are an associated project of SPI.
Fabian Keil [Sat, 21 Mar 2009 13:11:52 +0000 (13:11 +0000)]
- Mention that we are an associated project of SPI.
- Add a link to the "Would you like to donate?" entry in the FAQ.