From: Fabian Keil <fk@fabiankeil.de>
Date: Wed, 27 May 2009 20:45:31 +0000 (+0000)
Subject: Due to a bug in dependency_unsatisfied(), tests were executed as long as the first... 
X-Git-Tag: v_3_0_13~67
X-Git-Url: http://www.privoxy.org/gitweb/?a=commitdiff_plain;h=7093b101767320856cb2ea8dcf92038983cb7799;p=privoxy.git

Due to a bug in dependency_unsatisfied(), tests were executed as long as the first config-line dependency registered didn't match the first directive in the config file.

It "worked" so far, because until recently we only had a single
config-line dependency and only had to check the user-manual
directive, which usually is the first one.

And there I was rewriting client_connection() from scratch,
puzzled that the stupid connection-sharing tests would still
fail.
---

diff --git a/tools/privoxy-regression-test.pl b/tools/privoxy-regression-test.pl
index 0a9d3795..920b218d 100755
--- a/tools/privoxy-regression-test.pl
+++ b/tools/privoxy-regression-test.pl
@@ -7,7 +7,7 @@
 # A regression test "framework" for Privoxy. For documentation see:
 # perldoc privoxy-regression-test.pl
 #
-# $Id: privoxy-regression-test.pl,v 1.172 2009/05/25 19:31:42 fk Exp fk $
+# $Id: privoxy-regression-test.pl,v 1.176 2009/05/27 20:26:59 fk Exp fk $
 #
 # Wish list:
 #
@@ -587,8 +587,10 @@ sub dependency_unsatisfied ($) {
 
         foreach (@privoxy_config) {
 
-             $dependency_problem = undef if (/$dependency/);
-             last; # XXX: this looks ... interesting.
+            if (/$dependency/) {
+                $dependency_problem = undef;
+                last;
+            }
         }
 
     } elsif (defined ($dependencies{$level}{'feature status'})) {