X-Git-Url: http://www.privoxy.org/gitweb/?a=blobdiff_plain;f=miscutil.c;h=f2bbc18a0d9e22db0eacb4d460431ac857696483;hb=01ffe047cb016b80f8dc649f161d51be1269e65f;hp=6de1571562feede5429821b326250bed4dc15e6f;hpb=070b0a582cf5c7d4f5107434211d43726239bf6c;p=privoxy.git diff --git a/miscutil.c b/miscutil.c index 6de15715..f2bbc18a 100644 --- a/miscutil.c +++ b/miscutil.c @@ -1,4 +1,4 @@ -const char miscutil_rcs[] = "$Id: miscutil.c,v 1.51 2007/06/17 16:12:22 fabiankeil Exp $"; +const char miscutil_rcs[] = "$Id: miscutil.c,v 1.54 2007/09/19 20:28:37 fabiankeil Exp $"; /********************************************************************* * * File : $Source: /cvsroot/ijbswa/current/miscutil.c,v $ @@ -44,6 +44,17 @@ const char miscutil_rcs[] = "$Id: miscutil.c,v 1.51 2007/06/17 16:12:22 fabianke * * Revisions : * $Log: miscutil.c,v $ + * Revision 1.54 2007/09/19 20:28:37 fabiankeil + * If privoxy_strlcpy() is called with a "buffer" size + * of 0, don't touch whatever destination points to. + * + * Revision 1.53 2007/09/09 18:20:20 fabiankeil + * Turn privoxy_strlcpy() into a function and try to work with + * b0rked snprintf() implementations too. Reported by icmp30. + * + * Revision 1.52 2007/08/19 12:32:34 fabiankeil + * Fix a conversion warning. + * * Revision 1.51 2007/06/17 16:12:22 fabiankeil * #ifdef _WIN32 the last commit. According to David Shaw, * one of the gnupg developers, the changes are mingw32-specific. @@ -1092,8 +1103,9 @@ long int pick_from_range(long int range) * * Currently we don't have mutexes for mingw32, and for * our purpose this cludge is probably preferable to crashes. + * + * The warning is shown once on startup from jcc.c. */ - log_error(LOG_LEVEL_INFO, "No thread-safe PRNG available? Using weak \'randomization\' factor."); number = (range + GetCurrentThreadId() % range) / 2; #else /* @@ -1112,6 +1124,40 @@ long int pick_from_range(long int range) } +#ifdef USE_PRIVOXY_STRLCPY +/********************************************************************* + * + * Function : privoxy_strlcpy + * + * Description : strlcpy(3) look-alike for those without decent libc. + * + * Parameters : + * 1 : destination: buffer to copy into. + * 2 : source: String to copy. + * 3 : size: Size of destination buffer. + * + * Returns : The length of the string that privoxy_strlcpy() tried to create. + * + *********************************************************************/ +size_t privoxy_strlcpy(char *destination, const char *source, const size_t size) +{ + if (0 < size) + { + snprintf(destination, size, "%s", source); + /* + * Platforms that lack strlcpy() also tend to have + * a broken snprintf implementation that doesn't + * guarantee nul termination. + * + * XXX: the configure script should detect and reject those. + */ + destination[size-1] = '\0'; + } + return strlen(source); +} +#endif /* def USE_PRIVOXY_STRLCPY */ + + #ifndef HAVE_STRLCAT /********************************************************************* * @@ -1124,7 +1170,7 @@ long int pick_from_range(long int range) * 2 : source: String to copy. * 3 : size: Size of destination buffer. * - * Returns : The length of the string that strlcat tried to create. + * Returns : The length of the string that privoxy_strlcat() tried to create. * *********************************************************************/ size_t privoxy_strlcat(char *destination, const char *source, const size_t size)