X-Git-Url: http://www.privoxy.org/gitweb/?a=blobdiff_plain;f=filters.c;h=18ef5b35a5f1669bbe50645e3bb6d17df19918ac;hb=aa6ce89b0a708175c8ebeefe599aba5431841d7a;hp=8ba1b40c5ff9052bcb186cb00b9ceb74ca8ce359;hpb=c572a51fac46f778905533d0e0fc8cafc1008a65;p=privoxy.git diff --git a/filters.c b/filters.c index 8ba1b40c..18ef5b35 100644 --- a/filters.c +++ b/filters.c @@ -1,4 +1,4 @@ -const char filters_rcs[] = "$Id: filters.c,v 1.107 2008/05/04 17:52:56 fabiankeil Exp $"; +const char filters_rcs[] = "$Id: filters.c,v 1.112 2009/03/01 18:28:23 fabiankeil Exp $"; /********************************************************************* * * File : $Source: /cvsroot/ijbswa/current/filters.c,v $ @@ -40,6 +40,24 @@ const char filters_rcs[] = "$Id: filters.c,v 1.107 2008/05/04 17:52:56 fabiankei * * Revisions : * $Log: filters.c,v $ + * Revision 1.112 2009/03/01 18:28:23 fabiankeil + * Help clang understand that we aren't dereferencing + * NULL pointers here. + * + * Revision 1.111 2008/12/04 18:13:46 fabiankeil + * Fix a cparser warning. + * + * Revision 1.110 2008/11/10 16:40:25 fabiankeil + * Fix a gcc44 warning. + * + * Revision 1.109 2008/11/08 15:48:41 fabiankeil + * Mention actual values when complaining about + * the chunk size exceeding the buffer size. + * + * Revision 1.108 2008/05/21 15:35:08 fabiankeil + * - Mark csp as immutable for block_acl(). + * - Remove an obsolete complaint about filter_popups(). + * * Revision 1.107 2008/05/04 17:52:56 fabiankeil * Adjust parse_http_url() call to new prototype. * @@ -830,7 +848,7 @@ int acl_addr(const char *aspec, struct access_control_addr *aca) aca->mask = 0; for (i=1; i <= masklength ; i++) { - aca->mask |= (1 << (32 - i)); + aca->mask |= (1U << (32 - i)); } /* now mask off the host portion of the ip address @@ -1777,7 +1795,7 @@ int is_untrusted_url(const struct client_state *csp) /* since this path points into a user's home space * be sure to include this spec in the trustfile. */ - int path_len = path_end - path; /* save offset */ + long path_len = path_end - path; /* save offset */ path = strdup(path); /* Copy string */ if (path != NULL) { @@ -2174,7 +2192,7 @@ static jb_err remove_chunked_transfer_coding(char *buffer, size_t *size) return JB_ERR_PARSE; } - while (chunksize > 0) + while (chunksize > 0U) { if (NULL == (from_p = strstr(from_p, "\r\n"))) { @@ -2184,7 +2202,9 @@ static jb_err remove_chunked_transfer_coding(char *buffer, size_t *size) if ((newsize += chunksize) >= *size) { - log_error(LOG_LEVEL_ERROR, "Chunksize exceeds buffer in \"chunked\" transfer coding"); + log_error(LOG_LEVEL_ERROR, + "Chunk size %d exceeds buffer size %d in \"chunked\" transfer coding", + chunksize, *size); return JB_ERR_PARSE; } from_p += 2; @@ -2462,6 +2482,7 @@ const static struct forward_spec *get_forward_override_settings(struct client_st log_error(LOG_LEVEL_FATAL, "can't allocate memory for forward-override{%s}", forward_override_line); /* Never get here - LOG_LEVEL_FATAL causes program exit */ + return NULL; } vec_count = ssplit(forward_settings, " \t", vec, SZ(vec), 1, 1); @@ -2501,7 +2522,7 @@ const static struct forward_spec *get_forward_override_settings(struct client_st if (NULL != (socks_proxy = strchr(fwd->gateway_host, ':'))) { *socks_proxy++ = '\0'; - fwd->gateway_port = strtol(socks_proxy, NULL, 0); + fwd->gateway_port = (int)strtol(socks_proxy, NULL, 0); } if (fwd->gateway_port <= 0) @@ -2528,7 +2549,7 @@ const static struct forward_spec *get_forward_override_settings(struct client_st if (NULL != (http_parent = strchr(fwd->forward_host, ':'))) { *http_parent++ = '\0'; - fwd->forward_port = strtol(http_parent, NULL, 0); + fwd->forward_port = (int)strtol(http_parent, NULL, 0); } if (fwd->forward_port <= 0)