Privoxy 3.0.27 stable scales better in multi-user environments and brings a
- couple of tuning directives. Privoxy 3.0.28 stable fixes two regressions
- introduced in 3.0.27.
-
Changes in Privoxy 3.0.28 stable:
+
Privoxy 3.0.33 fixes an XSS issue and multiple DoS issues and a couple of other
+ bugs. The issues also affect earlier Privoxy releases. Privoxy 3.0.33 also comes
+ with a couple of general improvements and new features.
+
Changes in Privoxy 3.0.33 stable:
-
Bug fixes for regressions in 3.0.27:
+
Security/Reliability:
-
Fixed misplaced parentheses. Reported by David Binderman.
+
cgi_error_no_template(): Encode the template name to prevent XSS (cross-site scripting) when Privoxy is
+ configured to servce the user-manual itself. Commit 0e668e9409c. OVE-20211102-0001. CVE-2021-44543.
+ Reported by: Artem Ivanov
-
Changed two regression tests to depend on config directive enable-remote-toggle instead of
- FEATURE_TOGGLE.
+
get_url_spec_param(): Free memory of compiled pattern spec before bailing. Reported by Joshua Rogers
+ (Opera) who also provided the fix. Commit 652b4b7cb0. OVE-20211201-0003. CVE-2021-44540.
+
+
+
process_encrypted_request_headers(): Free header memory when failing to get the request destination.
+ Reported by Joshua Rogers (Opera) who also provided the fix. Commit 0509c58045. OVE-20211201-0002.
+ CVE-2021-44541.
+
+
+
send_http_request(): Prevent memory leaks when handling errors Reported by Joshua Rogers (Opera) who
+ also provided the fix. Commit c48d1d6d08. OVE-20211201-0001. CVE-2021-44542.
+
+
+
+
+
Bug fixes:
+
+
+
handle_established_connection(): Skip the poll()/select() calls if TLS data is pending on the server
+ socket. The TLS library may have already consumed all the data from the server response in which case
+ poll() and select() will not detect that data is available to be read. Fixes SF bug #926 reported by Wen
+ Yue.
+
+
+
continue_https_chat(): Update csp->server_connection.request_sent after sending the request to make
+ sure the latency is calculated correctly. Previously https connections were not reused after timeout
+ seconds after the first request made on the connection.
+
+
+
free_pattern_spec(): Don't try to free an invalid pointer when unloading an action file with a TAG
+ pattern while Privoxy has been compiled without FEATURE_PCRE_HOST_PATTERNS. Closes: SF patch request #147.
+ Patch by Maxim Antonov.
+
+
+
Adjust build_request_line() to create a CONNECT request line when https-inspecting and forwarding to a
+ HTTP proxy. Fixes SF bug #925 reported by Wen Yue.
+
+
+
load_config(): Add a space that was missing in a log message.
+
+
+
read_http_request_body(): Fix two error messages that used an incorrect variable.
+
+
+
If the the response is chunk-encoded, ignore the Content-Length header sent by the server. Allows to
+ load https://redmine.lighttpd.net/ with filtering enabled.
-
-
Changes in Privoxy 3.0.27 stable:
-
General improvements:
-
Add a receive-buffer-size directive which can be used to set the size of the previously statically
- allocated buffer in handle_established_connection(). Increasing the buffer size increases Privoxy's memory
- usage but can lower the number of context switches and thereby reduce the CPU usage and potentially
- increase the throughput. This is mostly relevant for fast network connections and large downloads that
- don't require filtering. Sponsored by: Robert Klemme
+
Allow to edit the add-header action through the CGI editor by generalizing the code that got added with
+ the suppress-tag action. Closes SF patch request #146. Patch by Maxim Antonov.
-
Add a listen-backlog directive which specifies the backlog value passed to listen(). Sponsored by:
- Robert Klemme
+
Add a CGI handler for /wpad.dat that returns a Proxy Auto-Configuration (PAC) file. Among other things,
+ it can be used to instruct clients through DHCP to use Privoxy as proxy. For example with the dnsmasq
+ option: dhcp-option=252,http://config.privoxy.org/wpad.dat Initial patch by Richard Schneidt.
-
Add an enable-accept-filter directive which allows to toggle accept filter support at run time when
- compiled with FEATURE_ACCEPT_FILTER support. It makes testing more convenient and now that it's optional we
- can emit an error message if enabling the accept filter fails. Sponsored by: Robert Klemme
+
Don't log the applied actions in process_encrypted_request() Log them in continue_https_chat() instead
+ to mirror chat(). Prevents the applied actions from getting logged twice for the first request on an
+ https-inspected connection.
-
Add a delay-response{} action. This is useful to tar pit JavaScript requests that are endlessly retried
- in case of blocks. It can also be used to simulate a slow Internet connection. Sponsored by: Robert
- Klemme
+
OpenSSL generate_host_certificate(): Use config.privoxy.org as Common Name Org and Org Unit if the real
+ host name is too long to get accepted by OpenSSL. Clients should only care about the Subject Alternative
+ Name anyway and we can continue to use the real host name for it. Reported by Miles Wen on
+ privoxy-users@.
-
Add a 'trusted-cgi-referrer' directive. It allows to configure another page or site that can be used to
- reach sensitive CGI resources. Sponsored by: Robert Klemme
+
Establish the TLS connection with the client earlier and decide how to route the request afterwards.
+ This allows to change the forwarding settings based on information from the https-inspected request, for
+ example the path.
-
Add a --fuzz mode which exposes Privoxy internals to input from files or stdout. Mainly tested with
- American Fuzzy Lop. For details see: https://www.fabiankeil.de/talks/fuzzing-on-freebsd/ This work was
- partially funded with donations and done as part of the Privoxy month in 2015.
+
listen_loop(): When shutting down gracefully, close listening ports before waiting for the threads to
+ exit. Allows to start a second Privoxy with the same config file while the first Privoxy is still
+ running.
-
Consistently use the U(ngreedy) flag in the 'img-reorder' filter.
+
serve(): Close the client socket as well if the server socket for an inspected connection has been
+ closed. Privoxy currently can't establish a new server connection when the client socket is reused and
+ would drop the connection in continue_https_chat() anyway.
-
listen_loop(): Reuse a single thread attribute object The object doesn't change and creating a new one
- for every thread is a waste of (CPU) time. Sponsored by: Robert Klemme
+
Don't disable redirect checkers in redirect_url(). Disable them in handle_established_connection()
+ instead. Doing it in redirect_url() prevented the +redirect{} and +fast-redirects{} actions from being
+ logged with LOG_LEVEL_ACTIONS.
-
Free csp resources in the thread that belongs to the csp instead of the main thread which has enough on
- its plate already. Sponsored by: Robert Klemme
+
handle_established_connection(): Slightly improve a comment.
-
Improve 'socket timeout reached' message. Log the timeout that was triggered and downgrade the log level
- to LOG_LEVEL_CONNECT to reduce the log noise with common debug settings. The timeout isn't necessary the
- result of an error and usually merely indicates that Privoxy's socket timeout is lower than the relevant
- timeouts used by client and server. Sponsored by: Robert Klemme
+
handle_established_connection(): Fix a comment.
-
Explicitly taint the server socket in case of CONNECT requests. This doesn't fix any known problems, but
- makes some log messages less confusing.
+
socks5_connect(): Fix indentation.
-
Let write_pid_file() terminate if the pid file can't be opened. Logging the issue at info level is
- unlikely to help.
+
handle_established_connection(): Improve an error message.
-
log_error(): Reduce the mutex-protected area by not using a heap-allocated buffer that is shared between
- all threads. This increases performance and reduces the latency with verbose debug settings and multiple
- concurrent connections. Sponsored by: Robert Klemme
+
create_pattern_spec(): Fix ifdef indentation.
-
Let zalloc() use calloc() if it's available. In some situations using calloc() can be faster than
- malloc() + memset() and it should never be slower. In the real world the impact of this change is not
- expected to be noticeable. Sponsored by: Robert Klemme
+
Fix comment typos.
-
Never use select() when poll() is available. On most platforms select() is limited by FD_SETSIZE while
- poll() is not. This was a scaling issue for multi-user setups. Using poll() has no downside other than the
- usual risk that code modifications may introduce new bugs that have yet to be found and fixed. At least in
- theory this commit could also reduce the latency when there are lots of connections and select() would use
- "bit fields in arrays of integers" to store file descriptors. Another side effect is that Privoxy no longer
- has to stop monitoring the client sockets when pipelined requests are waiting but can't be read yet. This
- code keeps the select()-based code behind ifdefs for now but hopefully it can be removed soonish to make
- the code more readable. Sponsored by: Robert Klemme
+
process_encrypted_request(): Improve a log message. The function only processes request headers and
+ there may still be unread request body data left to process.
-
Add a 'reproducible-tarball-dist' target. It's currently separate from the "tarball-dist" target because
- it requires a tar implementation with mtree spec support. It's far from being perfect and does not enforce
- a reproducible mode, but it's better than nothing.
+
chat(): Log the applied actions before deciding how to forward the request.
-
Use arc4random() if it's available. While Privoxy doesn't need high quality pseudo-random numbers
- there's no reason not to use them when we can and this silences a warning emitted by code checkers that
- can't tell whether or not the quality matters.
+
parse_time_header(): Silence a coverity complaint when building without assertions.
-
Show the FEATURE_EXTERNAL_FILTERS status on the status page. Better late than never. Previously a couple
- of tests weren't executed as Privoxy-Regression-Test couldn't detect that the FEATURE_EXTERNAL_FILTERS
- dependency was satisfied.
+
receive_encrypted_request_headers(): Improve a log message.
-
Ditch FEATURE_IMAGE_DETECT_MSIE. It's an obsolete workaround we inherited from Junkbuster and was
- already disabled by default. Users that feel the urge to work around issues with image requests coming from
- an Internet Explorer version from more than 15 years ago can still do this using tags.
+
mbedTLS get_ciphersuites_from_string(): Use strlcpy() instead of strncpy(). Previously the terminating
+ NUL wasn't copied which resulted in a compiler warning. This didn't cause actual problems as the target
+ buffer was initialized by zalloc_or_die() so the last byte of the target buffer was NUL already. Actually
+ copying the terminating NUL seems clearer, though.
-
Consistently use strdup_or_die() instead of strdup() in cases where allocation failures aren't expected.
- Using strdup_or_die() allows to remove a couple of explicit error checks which slightly reduces the size of
- the binary.
+
Remove compiler warnings. "log_error(LOG_LEVEL_FATAL, ..." doesn't return but apparently the compiler
+ doesn't know that. Get rid of several "this statement may fall through [-Wimplicit-fallthrough=]"
+ warnings.
-
Insert a refresh tag into the /client-tags CGI page when serving it while a client-specific tag is
- temporarily enabled. This makes it less likely that the user ends up looking at tag state that is out of
- date.
+
Store the PEM certificate in a dynamically allocated buffer when https-inspecting. Should prevent errors
+ like: 2021-03-16 22:36:19.148 7f47bbfff700 Error: X509 PEM cert len 16694 is larger than buffer len 16383
+ As a bonus it should slightly reduce the memory usage as most certificates are smaller than the previously
+ used fixed buffer. Reported by: Wen Yue
-
Use absolute URLs in the client-tag forms. It's more consistent with the rest of the CGI page URLs and
- makes it more convenient to copy the forms to external pages.
+
OpenSSL generate_host_certificate(): Fix two error messsages.
-
cgi_error_disabled(): Use status code 403 and an appropriate response line
+
Improve description of handle_established_connection()
-
Use a dedicated CGI handler to deal with tag-toggle requests As a result the /client-tags page is now
- safe to reach without trusted Referer header which makes bookmarking or linking to it more convenient.
- Finally, refreshing the /client-tags page to show the current state can no longer unintentionally repeat
- the previous toggle request.
+
OpenSSL ssl_store_cert(): Translate EVP_PKEY_EC to a string.
-
Don't add a "Connection" header for CONNECT requests. Explicitly sending "Connection: close" is not
- necessary and apparently it causes problems with some forwarding proxies that will close the connection
- prematurely. Reported by Marc Thomas.
OpenSSL ssl_store_cert(): Initialize pointer with NULL instead of 0.
-
Bug fixes:
+
Action file improvements:
-
rfc2553_connect_to(): Properly detect and log when poll() reached the time out. Previously this was
- logged as: Could not connect to [...]: No error: 0. which isn't very helpful. Sponsored by: Robert
- Klemme
+
Disable fast-redirects for .microsoftonline.com/.
+
+
+
Disable fast-redirects for idp.springer.com/.
+
+
+
Disable fast-redirects for .zeit.de/zustimmung.
+
+
+
Unblock adv-archiv.dfn-cert.de/.
-
add_tag_for_client(): Set time_to_live properly. Previously the time_to_live was always set for the
- first tag. Attempts to temporarily enable a tag would result in enabling it permanently unless no tag was
- enabled already.
+
Block requests to eu-tlp01.kameleoon.eu/.
-
Revert r1.165 which didn't perform as advertised. While the idea was to use "https:// when creating
- links for the user manual on the website", the actual effect was to use "https://" when Privoxy was
- supposed to serve the user manual itself. Reported by Yossi Zahn on Privoxy-devel@.
+
Block requests to fpa-events.arstechnica.com/.
-
socks5_connect(): Fail in case of unsupported address types. Previously they would not be detected right
- away and Privoxy would fail later on with an error message that didn't make it obvious that the problem was
- socks-related. So far, no such problems have actually been reported.
+
Unblock nlnet.nl/.
-
socks5_connect(): Properly deal with socks replies that contain IPv6 addresses. Previously parts of the
- reply were left unread and later on treated as invalid HTTP response data. Fixes #904 reported by Danny
- Goossen who also provided the initial version of this patch.
+
Unblock adguard.com/.
-
Action file improvements:
+
Privoxy-Log-Parser:
-
Unblock 'msdn.microsoft.com/'. It (presumably) isn't used to serve the kind of ads Privoxy should block
- by default but happens to serve lots of pages with URLs that are likely to result in false positives.
- Reported by bugreporter1694 in AF#939.
Improve documentation for inactivity-detection mode.
+
+
+
Detect date changes when looking for inactivity.
+
+
+
Add a --passed-request-statistics-threshold option that can be set to get statistics for requests that
+ were passed.
+
+
+
Add a "inactivity detection" mode which can be useful for debugging purposes.
-
Disable gif deanimation for requests tagged with CSS-REQUEST. The action will ignore content that isn't
- considered text anyway and explicitly disabling it makes this more obvious if "action" debugging (debug
- 65536) is enabled while "gif deanimation" debugging (debug 256) isn't.
+
Bump version to 0.9.4.
-
Explicitly disable HTML filters for requests with CSS-REQUEST tag. The filters are unlikely to break CSS
- files but executing them without (intentionally) getting any hits is a waste of cpu time and makes the log
- more noisy when running with "debug 64".
+
Only run print_intro() and print_outro() when syntax highlighting.
-
Unblock 'adventofcode.com/'. Reported by Clint Adams in Debian bug #848211. Fixes Roland's AF#937.
+
Rephrase a sentence in the documentation.
-
Unblock 'adlibris.com'. Reported by Wyrex in #935
+
Highlight 'Client socket 7 is no longer usable. The server socket has been closed.'.
-
Unblock .golang.org/
+
Clarify --statistics output by explicitly mentioning that the status codes sent by the server may differ
+ from the ones in "debug 512" messages.
-
Add fast-redirects exception for '.youtube.com/.*origin=http'
+
Fix typo in the --statistics output.
+
+
+
Remove an unused variable.
+
+
+
Highlight 'The peer notified us that the connection on socket 11 is going to be closed'.
-
Privoxy-Log-Parser:
+
Privoxy-Regression-Test:
+
+
+
Remove duplicated word in a comment.
+
+
+
+
+
regression-tests.action:
-
Don't gather host and resource statistics if they aren't requested. While the performance impact seems
- negligible this significantly reduces the memory usage if there are lots of requests.
+
Add fetch test for http://p.p/wpad.dat.
-
Bump version as the behaviour (slightly) changed.
+
Bump for-privoxy-version to 3.0.33 which introduced the wpad.dat support.
-
Count connection failures as well in statistics mode. Sponsored by: Robert Klemme
+
Add more tests for the '/send-banner' code.
-
Count connection timeouts as well in statistics mode. Sponsored by: Robert Klemme
+
Add test for OVE-20210203-0001.
-
Fix an 'uninitialized value' warning when generating statistics for a log file without response headers.
- While privoxy-log-parser was supposed to detect this already, the check was flawed and the message the user
- didn't see was somewhat confusing anyway. Now the message is less confusing, more helpful and actually
- printed. Reported by: Robert Klemme
+
Add a test for CVE-2021-20217.
-
Documentation improvements:
+
uagen:
-
Refer to the git sources instead of CVS.
+
Bump generated Firefox version to 91 (ESR).
-
Use GNU/Linux when referring to the OS instead of the kernel.
+
Bump version to 1.2.3.
-
Add FAQ entry for what to do if editing the config file is access denied.
+
Bump copyright.
+
+
+
+
Build system:
+
-
Add brief HTTP/2 FAQ.
+
configure: Bump SOURCE_DATE_EPOCH.
-
Add a small fuzzing section to the developer documentation.
+
GNUmakefile.in: Fix typo.
-
Add a client-header-tagger{client-ip-address} example.
+
configure: Add another warning in case --disable-pthread is used while POSIX threads are available.
+ Various features don't even compile when not using threads.
-
Stop suggesting that Privoxy is an anonymizing proxy. The term could lead to Privoxy users
- overestimating what it can do on its own (without Tor).
+
Add configure option to enable MemorySanitizer.
-
Make it more obvious that SPI accepts Paypal, too. Currently most donations are made through the Paypal
- account managed by Zwiebelfreunde e.V. and a more even distribution would be useful.
+
Add configure option to enable UndefinedBehaviorSanitizer.
-
Suggest to log applying actions as well when reproducing problems.
+
Add configure option to enable AddressSanitizer.
-
Explicitly mention that Privoxy binaries are built by individuals on their own systems. Buyer
- beware!
+
Bump copyright.
-
Mention the release feed on the homepage.
+
Add a configure option to disable pcre JIT compilation. While JIT compilation makes filtering faster it
+ can cause false-positive valgrind complaints. As reported by Gwyn Ciesla in SF bug 924 it also can cause
+ problems when the SELinux policy does not grant Privoxy "execmem" privileges.
-
Remove a mysterious comment with a GNU FDL link as it isn't useful and could confuse license scanners.
- In May 2002 it was briefly claimed that "this document" was covered by the GNU FDL. The commit message
- (r1.5) doesn't explain the motivation or whether all copyright holders were actually asked and agreed to
- the declared license change. It's thus hard to tell whether or not the license change was legit, but
- luckily two days later the "doc license" was "put" "back to GPL" anyway (r1.6). At the same time the
- offending comment with a link to the FDL (not the GPL) was added for no obvious reason. Now it's gone
- again.
+
configure: Remove obsolete RPM_BASE check.
-
Regression tests:
+
Windows build system:
-
Bump for-privoxy-version to 3.0.27 as we now rely on untrusted CGI request being rejected with status
- code 403 (instead of 200).
+
Update the build script to use mbed tls version 2.6.11.
+
+
+
Update build script to use the final 8.45 pcre library.
-
Update test for /send-stylesheet and add another one
+
Put all the '--enable-xxx' options in the configure call together.
-
Templates:
+
macOS build system:
-
Consistently use https:// when linking to the Privoxy website.
-
-
-
Remove SourceForge references in Copyright header.
-
-
-
Remove a couple of SourceForge references in a comment. While at it, fix the grammar.
-
-
-
Move the site-specific documentation block before the generic one. While most Privoxy installations
- don't have a site-specific documentation block, in cases were it exists it's likely to be more relevant
- than the generic one. Showing it first makes it less likely that users stop reading before they reach it,
- especially on pages that don't fit on the screen.
+
The OSXPackageBuilder repository has been updated and can be used to create macOS packages again.
-
Build system improvements:
+
Documentation:
-
Prefer openjade to jade. On some systems Jade produces HTML with unescaped ampersands in URLs.
+
contacting: Remove obsolete reference to announce.sgml.
+
+
+
contacting: Request that the browser cache is cleared before producing a log file for submission.
-
Prefer OpenSP to SP to be consistent.
+
Sponsor FAQ: Note that Privoxy users may follow sponsor links without Referer header set.
-
Have Docbook generated HTML files be straight ASCII. Dealing with a mixture of ISO-8859 and UTF-8 files
- is problematic.
+
newfeatures: Clarify that https inspection also allows to filter https responses.
-
Echo the filename to stderr for 'make dok-tidy'. Make it a bit easier to find errors in docbook
- generated HTML.
+
developer-manual: Mention that announce.txt should be updated when doing a release.
-
Warn when still using select().
+
config: Explicitly mention that the CGI pages disclosing the ca-password can be blocked and upgrade the
+ disclosure paragraphs to a warning.
-
Warn when compiling without calloc().
+
Put all the requested debug options in the config file. Section 11.1 of the Privoxy user manual lists
+ all the debug options that should be enabled when reporting problems or requesting support. Make it easier
+ for users to do the right thing by having all those options present in the config.
-
Make it more obvious that the --with-fdsetsize configure switch is pointless if poll() is available.
+
Update TODO list item #184 to note that WolfSSL support will (hopefully) appear after the 3.0.34
+ release.
-
Remove support for AmigaOS.
+
Update max-client-connections's description. On modern systems other than Windows Privoxy should use
+ poll() in which case the FD_SETSIZE value isn't releveant.
-
Update windows build system to use supported software. The cygwin gcc -mno-cygwin option is no longer
- supported, so convert the windows build system to use the cygwin cross-compiler to build "native" code.
+
Add a warning that the socket-timeout does not apply to operations done by TLS libraries.
-
Add --enable-static-linking option for configure does the same thing as LDFLAGS=-static; ./configure but
- nicer than mixing evars and configure options.
+
Make documentation slightly less "offensive" for some people by avoiding the word "hell".