X-Git-Url: http://www.privoxy.org/gitweb/?a=blobdiff_plain;f=cgisimple.c;h=7c969074c93e354189145826759ad8e758bdf48f;hb=ce921028f16077b9a2ad87021ec8cb47dce71a72;hp=8f1be727f36d3ddf308afe3987b992ed328607c9;hpb=71394ae1d3a5c92dddb3262bd62e0aa721c54a12;p=privoxy.git diff --git a/cgisimple.c b/cgisimple.c index 8f1be727..7c969074 100644 --- a/cgisimple.c +++ b/cgisimple.c @@ -1,4 +1,4 @@ -const char cgisimple_rcs[] = "$Id: cgisimple.c,v 1.80 2008/05/04 16:18:32 fabiankeil Exp $"; +const char cgisimple_rcs[] = "$Id: cgisimple.c,v 1.82 2008/05/10 20:01:47 fabiankeil Exp $"; /********************************************************************* * * File : $Source: /cvsroot/ijbswa/current/cgisimple.c,v $ @@ -36,6 +36,15 @@ const char cgisimple_rcs[] = "$Id: cgisimple.c,v 1.80 2008/05/04 16:18:32 fabian * * Revisions : * $Log: cgisimple.c,v $ + * Revision 1.82 2008/05/10 20:01:47 fabiankeil + * Fix an assertion that could erroneously + * trigger in case of memory shortage. + * + * Revision 1.81 2008/05/05 09:54:39 fabiankeil + * In cgi_show_url_info(), make sure ftp URLs are + * declared invalid. Also simplify the code that adds + * "http://" if no protocol has been specified. + * * Revision 1.80 2008/05/04 16:18:32 fabiankeil * Provide parse_http_url() with a third parameter to specify * whether or not URLs without protocol are acceptable. @@ -1405,7 +1414,7 @@ jb_err cgi_show_url_info(struct client_state *csp, url_param[0] = '\0'; } } - else if (NULL == strstr(url_param, "://")) + else if ((url_param[0] != '\0') && (NULL == strstr(url_param, "://"))) { /* No prefix - assume http:// */ char *url_param_prefixed = strdup("http://"); @@ -1475,7 +1484,7 @@ jb_err cgi_show_url_info(struct client_state *csp, memset(url_to_query, '\0', sizeof(url_to_query)); err = parse_http_url(url_param, url_to_query, REQUIRE_PROTOCOL); - assert(url_to_query->ssl == !strncmp(url_param, "https://", 8)); + assert((err != JB_ERR_OK) || (url_to_query->ssl == !strncmp(url_param, "https://", 8))); free(url_param);