From: Lee <ler762@users.sourceforge.net>
Date: Wed, 7 Jul 2021 03:15:34 +0000 (-0400)
Subject: nit: remove compiler warnings
X-Git-Tag: v_3_0_33~72
X-Git-Url: http://www.privoxy.org/gitweb/%22https:/faq/@default-cgi@/user-manual/static/@default-cgi@show-url-info?a=commitdiff_plain;h=2feb45cfe654463d3e52715e170deb5eccd8d429;p=privoxy.git
nit: remove compiler warnings
"log_error(LOG_LEVEL_FATAL, ..." doesn't return but apparently the compiler doesn't know that.
Get rid of several "this statement may fall through [-Wimplicit-fallthrough=]" warnings.
i686-w64-mingw32-gcc -c -Imbedtls/include -pipe -O2 -fstack-protector-strong -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-missing-field-initializers -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-but-set-variable -Wformat=2 -Wlogical-op -Wshadow -DNDEBUG -DWINVER=0x501 -I/source/pcre-8.44/ -I/source/mbedtls-2.16.10/include -I/source/brotli-1.0.9/c/include -mwindows -Wall jcc.c -o jcc.o
jcc.c: In function ‘bind_port_helper’:
jcc.c:5820:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
5820 | log_error(LOG_LEVEL_FATAL,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
5821 | "can't bind to %s:%d: There may be another Privoxy "
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5822 | "or some other proxy running on port %d",
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5823 | bind_address, hport, hport);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
jcc.c:5825:10: note: here
5825 | case -2:
| ^~~~
---
diff --git a/jcc.c b/jcc.c
index 5bd09351..df8ddd1a 100644
--- a/jcc.c
+++ b/jcc.c
@@ -5821,15 +5821,18 @@ static jb_socket bind_port_helper(const char *haddr, int hport, int backlog)
"can't bind to %s:%d: There may be another Privoxy "
"or some other proxy running on port %d",
bind_address, hport, hport);
+ exit(-1);
case -2:
log_error(LOG_LEVEL_FATAL,
"can't bind to %s:%d: The hostname is not resolvable",
bind_address, hport);
+ exit(-1);
default:
log_error(LOG_LEVEL_FATAL, "can't bind to %s:%d: %E",
bind_address, hport);
+ exit(-1);
}
/* shouldn't get here */