From: Fabian Keil <fk@fabiankeil.de>
Date: Wed, 26 Aug 2020 13:45:08 +0000 (+0200)
Subject: ssl_verify_callback(): Handle html_encode() failures
X-Git-Tag: v_3_0_29~196
X-Git-Url: http://www.privoxy.org/gitweb/%22https:/faq/@default-cgi@/static/@default-cgi@toggle?a=commitdiff_plain;h=7c7eac4808f49d1b7bba67ade896788d25f7baa6;p=privoxy.git

ssl_verify_callback(): Handle html_encode() failures

Sponsored by: Robert Klemme
---

diff --git a/ssl.c b/ssl.c
index 30b6f583..1eb6e827 100644
--- a/ssl.c
+++ b/ssl.c
@@ -1726,6 +1726,12 @@ static int ssl_verify_callback(void *csp_void, mbedtls_x509_crt *crt,
 
       mbedtls_x509_crt_info(buf, sizeof(buf), CERT_INFO_PREFIX, crt);
       encoded_text = html_encode(buf);
+      if (encoded_text == NULL)
+      {
+         log_error(LOG_LEVEL_ERROR,
+            "Failed to HTML-encode the certificate information");
+         return -1;
+      }
       strlcpy(last->info_buf, encoded_text, sizeof(last->info_buf));
       freez(encoded_text);
    }